New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755709 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 730232



Sign in to add a comment

Select + drag and drop only works when starting select on file name

Project Member Reported by mcirimele@chromium.org, Aug 15 2017

Issue description

What steps will reproduce the problem?
(1) Select a file in Files app by long pressing somewhere on the row outside of the thumbnail and file name.
(2) Immediately start dragging file

What is the expected result?
Drag shadow (chip) is shown and the file can be dragged and dropped.

What happens instead?
Nothing happens, file can not be dragged. Not that this only happens if you move straight into dragging from selecting. If I select, then lift my finger, then long press and drag it works.

 
Blocking: 730232
Labels: OS-Chrome
Labels: -Pri-3 M-61 Pri-1
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ae9bf4f7a9879aeba58c1c856ab08cecb7b1b33

commit 6ae9bf4f7a9879aeba58c1c856ab08cecb7b1b33
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Thu Aug 17 05:29:28 2017

Select and drag file(s) by long-touch and slide anywhere on a file row.

Dragging other parts of the row than filename / icon before selecting it
is treated as range-select if done by mouse.
We don't support this way to range-select by touch, but instead allow
select and drag the item in one action.

Bug:  755709 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If29e8d08ba9a06ae188aa3b65f626c963ba2e0a2
Reviewed-on: https://chromium-review.googlesource.com/618310
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495083}
[modify] https://crrev.com/6ae9bf4f7a9879aeba58c1c856ab08cecb7b1b33/ui/file_manager/file_manager/foreground/js/ui/file_table.js

Labels: Merge-Request-61
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 18 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/431735d6b19b1633d91477eee349052a67556d27

commit 431735d6b19b1633d91477eee349052a67556d27
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Fri Aug 18 02:39:06 2017

Select and drag file(s) by long-touch and slide anywhere on a file row.

Dragging other parts of the row than filename / icon before selecting it
is treated as range-select if done by mouse.
We don't support this way to range-select by touch, but instead allow
select and drag the item in one action.

TBR=yamaguchi@chromium.org

(cherry picked from commit 6ae9bf4f7a9879aeba58c1c856ab08cecb7b1b33)

Bug:  755709 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If29e8d08ba9a06ae188aa3b65f626c963ba2e0a2
Reviewed-on: https://chromium-review.googlesource.com/618310
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495083}
Reviewed-on: https://chromium-review.googlesource.com/620366
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#669}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/431735d6b19b1633d91477eee349052a67556d27/ui/file_manager/file_manager/foreground/js/ui/file_table.js

Status: Fixed (was: Started)
Cc: yamaguchi@chromium.org
 Issue 753831  has been merged into this issue.

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment