Tapping file thumbnail should select file |
||||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Tap thumbnail of file (in list view) What is the expected result? The file is selected (same behavior as with mouse). What happens instead? The file is opened
,
Aug 15 2017
,
Aug 16 2017
,
Aug 16 2017
,
Aug 16 2017
What should happen when tapping the icon of a directory item in the grid view mode? I think selecting the item in this case would be more consistent with the existing UI, although it might look like there are 2 different types of interactions in the grid view items.
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdb29caeef4fe23ca224e10cb72ef8b3fe2570d6 commit cdb29caeef4fe23ca224e10cb72ef8b3fe2570d6 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Aug 16 08:17:53 2017 Toggle select when tapping on thumbnail/icon, instead of opening it. Bug: 755695 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If0cff9f42e5bc023608bdbd174c1f1a88e33e3b0 Reviewed-on: https://chromium-review.googlesource.com/616580 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#494723} [modify] https://crrev.com/cdb29caeef4fe23ca224e10cb72ef8b3fe2570d6/ui/file_manager/file_manager/foreground/js/main_window_component.js [modify] https://crrev.com/cdb29caeef4fe23ca224e10cb72ef8b3fe2570d6/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js
,
Aug 16 2017
Reassigning for the question in #5.
,
Aug 17 2017
,
Aug 17 2017
,
Aug 17 2017
,
Aug 17 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 17 2017
Approving merge to M61 Chrome OS.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63d13978b8cb201e60c79b19b199de960cb2d0f8 commit 63d13978b8cb201e60c79b19b199de960cb2d0f8 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Fri Aug 18 14:26:15 2017 Toggle select when tapping on thumbnail/icon, instead of opening it. TBR=yamaguchi@chromium.org (cherry picked from commit cdb29caeef4fe23ca224e10cb72ef8b3fe2570d6) Bug: 755695 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If0cff9f42e5bc023608bdbd174c1f1a88e33e3b0 Reviewed-on: https://chromium-review.googlesource.com/616580 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#494723} Reviewed-on: https://chromium-review.googlesource.com/620351 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#672} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/63d13978b8cb201e60c79b19b199de960cb2d0f8/ui/file_manager/file_manager/foreground/js/main_window_component.js [modify] https://crrev.com/63d13978b8cb201e60c79b19b199de960cb2d0f8/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js
,
Aug 22 2017
Regarding comment #5 I agree that tapping a folder icon in thumbnail view should select it to keep consistency with mouse click targets.
,
Aug 23 2017
,
Jan 22 2018
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by mcirimele@chromium.org
, Aug 15 2017