Include glibc in standalone chromiumos-sdk tarballs |
||
Issue descriptionCurrently the per-architecture chromiumos-sdk standalone toolchain tarballs include prebuilt versions of libstdc++ and libc++ (presumably with generic flags for each architecture)... however glibc is not included. Instead, in order to build basically anything, a sysroot must be obtained from elsewhere. There are certainly advantages to using the libraries built from the sysroot (such as mtune/mcpu), but it would also be useful for a less-optimized architecture-generic version of glibc to be available in the chromiumos-sdk standalone tarball to make it more usable, complete, and consistent.
,
Aug 17 2017
so glibc isn't usable w/out kernel headers (since many of its headers include linux/ and asm/ headers). i think we'll need to delete the 'kernel' filtering too.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/df524b531529ff466a3b884397d65b14d8bb250e commit df524b531529ff466a3b884397d65b14d8bb250e Author: Yunlian Jiang <yunlian@google.com> Date: Fri Aug 18 01:42:31 2017 Include glibc in standalone chromiumos-sdk tarball This include glibc and linux headers in the standalone chormiumos-sdk tarball. BUG= chromium:755693 TEST=sudo /mnt/host/source/chromite/bin/cros_setup_toolchains -t x86_64-cros-linux-gnu --create-packages Change-Id: I0abbf817c1d7d3cd8ebde82dbbc83de235589f06 Reviewed-on: https://chromium-review.googlesource.com/619045 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Bailey Forrest <bcf@chromium.org> Reviewed-by: Alan Jones <alanjones@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/df524b531529ff466a3b884397d65b14d8bb250e/scripts/cros_setup_toolchains.py
,
Aug 28 2017
BTW, this is working now. Thanks!!! This cleanup already helped me find a real problem where we were using the wrong versions of some header files I failed to clean up in our import. Soso happy. |
||
►
Sign in to add a comment |
||
Comment 1 by vapier@chromium.org
, Aug 17 2017yunlian suggested: --- a/scripts/cros_setup_toolchains.py +++ b/scripts/cros_setup_toolchains.py @@ -899,7 +899,7 @@ def _GetFilesForTarget(target, root='/'): # Find all the files owned by the packages for this target. for pkg in GetTargetPackages(target): # Ignore packages that are part of the target sysroot. - if pkg in ('kernel', 'libc'): + if pkg in ('kernel'): continue # Skip Go compiler from redistributable packages.