New issue
Advanced search Search tips

Issue 755692 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

RTL: Download progress string different in RTL

Project Member Reported by a...@chromium.org, Aug 15 2017

Issue description

Compare the two attached images from a file download in 62.0.3186.0. On the second line is the progress string.

In English, the string has, in order:
1) progress in bytes/total
2) estimated time remaining

In Hebrew, the string has, in order:
1) estimated time remaining
2) progress in bytes/total

We're building the string incorrectly. In fact, take a look at the string. Do you see the little tick mark next to the beginning of the string in the Hebrew version? That should be at the end, which shows that we're breaking the RTL algorithm.
 
Screen Shot 2017-08-15 at 4.19.59 PM.png
10.4 KB View Download
Screen Shot 2017-08-15 at 4.21.06 PM.png
8.2 KB View Download

Comment 1 by a...@chromium.org, Aug 15 2017

DownloadItemModel::GetInProgressStatusString() needs work.

Comment 2 by a...@chromium.org, Aug 15 2017

I think the problem is that the start of the string is all numeric, which has weak directionality, and the first character with strong directionality is the "GB", which gives the string the wrong overall directionality.

Comment 3 by a...@chromium.org, Aug 15 2017

OK, not so sure about that. Arabic has the same problem and they're not using the "GB" like Hebrew does. Do we have RTL experts here?
Screen Shot 2017-08-15 at 4.44.07 PM.png
7.9 KB View Download
Owner: xingliu@chromium.org
Status: Assigned (was: Untriaged)
Can you take a look?  Thanks!

Sign in to add a comment