New issue
Advanced search Search tips

Issue 755676 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename AutoLocker to GraphLocker

Project Member Reported by rtoy@chromium.org, Aug 15 2017

Issue description

BaseAudioContext::AutoLocker sets a mutex that indicates that audio graph is owned by the following code.  But the check is named isGraphOwner.  This is really confusing.

Rename BaseAudioContext::AutoLocker to GraphLocker to make this clearly what is actually intended to be locked.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304

commit 7fc32c124b6a1ad8dbb7351b7c7934886cdd7304
Author: Raymond Toy <rtoy@chromium.org>
Date: Tue Sep 19 19:01:58 2017

Rename AutoLocker to GraphAutoLocker

The AutoLocker is really the mutex to establish graph ownership.
Rename to make it clearer that this is what the lock is really doing.

No functional changes.

Conversion done by script:
for f in *.h *.cpp
do
  sed -i 's/\([^a-zA-Z]\)AutoLocker/\1GraphAutoLocker/g' $f
done


Bug:  755676 
Change-Id: Ie4f3c1c92e88d001a83443b106529a462f5cc397
Reviewed-on: https://chromium-review.googlesource.com/621876
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502905}
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/ConvolverNodeTest.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.h
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNodeTest.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNodeTest.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/StereoPannerNodeTest.cpp
[modify] https://crrev.com/7fc32c124b6a1ad8dbb7351b7c7934886cdd7304/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp

Comment 2 by rtoy@chromium.org, Sep 25 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment