New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755675 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----

Blocking:
issue 756580



Sign in to add a comment

Clean up extra pak files under WebView apps

Project Member Reported by zpeng@chromium.org, Aug 15 2017

Issue description

Forked from  crbug.com/752510 

Clean up unnecessary pak files under WebView apps that look like these:
./app_webview/paks
./app_webview/paks/en-GB.pak@15de69e1c5e
./app_webview/paks/en-US.pak@15de69e1c5e
 

Comment 1 by zpeng@chromium.org, Aug 17 2017

Blocking: 756580
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb8ba65e8150c82259ec8c07b37db279011a06b8

commit eb8ba65e8150c82259ec8c07b37db279011a06b8
Author: Felix <zpeng@chromium.org>
Date: Fri Aug 18 15:55:13 2017

Clean up unnecessary extra pak files for WebView apps.

This CL cleans up unnecessary extra pak files for WebView apps by
removing "paks" directory from "app_webview" directory if it exists.

We have following Chrome versions for testings: (as 2017/08/17)
Stable (60, extracting extra pak files)
Dev (61, extracting extra pak files)
Canary (62, no longer extracting extra pak files, no clean up)
Debug (62, no longer extracting extra pak files, with clean up)

Tested with Gmail and WebView shell browser:
Test 1:
Open app with Stable -> extra paks generated
Switch to Debug -> extra paks removed
Test 2:
Open app with Stable -> extra paks generated
Switch to Dev -> extra paks persist
Test 3:
Open app with Stable -> extra paks generated
Switch to Canary -> extra paks persist

Bug:  755675 
Change-Id: I220d1c8857b16a14566458c4bf9f1c37f3ee5655
Reviewed-on: https://chromium-review.googlesource.com/619179
Commit-Queue: Felix <zpeng@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495556}
[modify] https://crrev.com/eb8ba65e8150c82259ec8c07b37db279011a06b8/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

Comment 3 by zpeng@chromium.org, Aug 18 2017

Status: Fixed (was: Assigned)

Sign in to add a comment