New issue
Advanced search Search tips

Issue 755674 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[OOBE flow] New Network not available screen is still not in.

Project Member Reported by mkarkada@chromium.org, Aug 15 2017

Issue description

Chrome OS version: 62.0.3186.0, dev build
Platform version: 9843.0.0, dev channel cave device
M-62 build

Steps to reproduce the problem:
According to launch bug Issue 705566.

1. During the OOBE flow, disable WiFi or disable the network.
2. Network not available screen is displayed .
3. But, this screen is not the latest one. Still, the old Network not available screen (dinosaur picture embed) is shown up.

What is the expected behavior?
Old network not available screen should be replaced with the new screen

Please refer the attachments.
 
Expected_new_screen.png
249 KB View Download
Actual_old_screen.JPG
2.2 MB View Download
By simple change we can update screen to this: 
https://screenshot.googleplex.com/Rqa2dMC3TXr.png

It still lacks 7 buttons (3 can be shown at a time), but I am still working on that.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5ab3d2d311fd67851ec89f24bd718709cb34a21

commit d5ab3d2d311fd67851ec89f24bd718709cb34a21
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 23 20:42:32 2017

Chrome OS: Implement MD Error screen.

This CL updates Error screen to Material design.

Bug:  755674 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0ac85a917031dd72df49988d4d91acdd50842184
Reviewed-on: https://chromium-review.googlesource.com/627498
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496797}
[modify] https://crrev.com/d5ab3d2d311fd67851ec89f24bd718709cb34a21/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/d5ab3d2d311fd67851ec89f24bd718709cb34a21/chrome/browser/resources/chromeos/login/oobe_buttons.js
[modify] https://crrev.com/d5ab3d2d311fd67851ec89f24bd718709cb34a21/chrome/browser/resources/chromeos/login/screen_error_message.css
[modify] https://crrev.com/d5ab3d2d311fd67851ec89f24bd718709cb34a21/chrome/browser/resources/chromeos/login/screen_error_message.html
[modify] https://crrev.com/d5ab3d2d311fd67851ec89f24bd718709cb34a21/chrome/browser/resources/chromeos/login/screen_error_message.js
[modify] https://crrev.com/d5ab3d2d311fd67851ec89f24bd718709cb34a21/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/d5ab3d2d311fd67851ec89f24bd718709cb34a21/chromeos/chromeos_switches.cc
[modify] https://crrev.com/d5ab3d2d311fd67851ec89f24bd718709cb34a21/chromeos/chromeos_switches.h

Status: Fixed (was: Untriaged)
Labels: -M-62 M-61 Merge-Request-61
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 23 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 23 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69d665e45fe98a787ea4cf2c1b12d3137ccc702b

commit 69d665e45fe98a787ea4cf2c1b12d3137ccc702b
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 23 22:23:49 2017

Chrome OS: Implement MD Error screen.

This CL updates Error screen to Material design.

TBR=alemate@chromium.org

(cherry picked from commit d5ab3d2d311fd67851ec89f24bd718709cb34a21)

Bug:  755674 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0ac85a917031dd72df49988d4d91acdd50842184
Reviewed-on: https://chromium-review.googlesource.com/627498
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496797}
Reviewed-on: https://chromium-review.googlesource.com/630246
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#837}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/69d665e45fe98a787ea4cf2c1b12d3137ccc702b/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/69d665e45fe98a787ea4cf2c1b12d3137ccc702b/chrome/browser/resources/chromeos/login/oobe_buttons.js
[modify] https://crrev.com/69d665e45fe98a787ea4cf2c1b12d3137ccc702b/chrome/browser/resources/chromeos/login/screen_error_message.css
[modify] https://crrev.com/69d665e45fe98a787ea4cf2c1b12d3137ccc702b/chrome/browser/resources/chromeos/login/screen_error_message.html
[modify] https://crrev.com/69d665e45fe98a787ea4cf2c1b12d3137ccc702b/chrome/browser/resources/chromeos/login/screen_error_message.js
[modify] https://crrev.com/69d665e45fe98a787ea4cf2c1b12d3137ccc702b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/69d665e45fe98a787ea4cf2c1b12d3137ccc702b/chromeos/chromeos_switches.cc
[modify] https://crrev.com/69d665e45fe98a787ea4cf2c1b12d3137ccc702b/chromeos/chromeos_switches.h

I see the new screen landed, but it still lacks image in it. 

Also, I'm seeing 2 versions of this new screen during OOBE. Please refer the attachments for more clarity.  
IMG_1591.JPG
2.1 MB View Download
IMG_1599.jpg
1.5 MB View Download
Tested on: Chrome OS 9765.49.0, 61.0.3163.72 beta build. 
Status: Verified (was: Fixed)

Sign in to add a comment