New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755669 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Full payloads are missing on M61

Project Member Reported by abod...@chromium.org, Aug 15 2017

Issue description

Owner: nxia@chromium.org
+deputy

Comment 2 by nxia@chromium.org, Aug 15 2017

Cc: dgarr...@chromium.org
dgarrett@, can you please take a look?
Cc: kbleicher@chromium.org
According to the logs, these are the payloads generated.

01:01:45: INFO: All payloads for the build:
01:01:45: INFO:   1: chromeos_9765.29.0_asuka_dev-channel_full_mp.bin-e39065ac409465ac74447bb03a85a672.signed
01:01:45: INFO:   2: chromeos_9765.29.0_asuka_dev-channel_full_test.bin-2370fa2a64b1d255684419de88d99ec9
01:01:45: INFO:   3: chromeos_9765.29.0-9765.29.0_asuka_dev-channel_delta_test.bin-0eaadc86821a717c325343ac95968100
01:01:45: INFO:   4: chromeos_9765.21.0-9765.29.0_asuka_dev-channel_delta_mp.bin-2b91821a8c129645ff58a498737587fc.signed
01:01:45: INFO:   5: chromeos_9765.21.0-9765.29.0_asuka_dev-channel_delta_test.bin-526fd2a808033804aa1fc60b81d567fc


I see:
  Full Signed
  Full Test
  N2N Delta Test
  N-1 Delta Signed
  N-1 Delta Test

When I check the build artifacts, I see the same thing.
The test suite run shows a test for each of the three test payloads listed above.

http://cautotest.corp.google.com/afe/#tab_id=view_job&object_id=135159321

Based on that, I believe the correct payloads were generated and tested, but perhaps not correctly communicated to GE.
Wait... rechecking the list of tests run..... versus expectations.....
The only full test run was an N2N full payload update.

GE says the N-1 full payload update test is missing. Checking paygen.json to see if it was specified there.


Checking paygen.json, this is the only entry for auron_paine dev channel.

It specifies to generate and test the N-1 delta, but not to test the N-1 full payload.

    {
      "board": {
        "public_codename": "auron-paine",
        "is_active": true,
        "builder_name": "auron_paine"
      },
      "delta_type": "OMAHA",
      "channel": "dev",
      "chrome_os_version": "9765.21.0",
      "chrome_version": "61.0.3163.38",
      "milestone": 61,
      "generate_delta": true,
      "delta_payload_tests": true,
      "full_payload_tests": false
    },

I believe the paygen code on the Chromite side did the right thing (whew!!!).


Note, I filed this bug against myself to improve Paygen logging for tests scheduled. https://crbug.com/755713
Cc: leecy@chromium.org moisesos...@chromium.org
Owner: moisesos...@chromium.org
Status: Started (was: Untriaged)
Filed http://b/64728302 for internal tracking, will update here once pushed to prod.
Status: Fixed (was: Started)
Fix is live on prod and indicating Paygen to run the full test on N-1:
    {
      "board": {
        "public_codename": "auron-paine",
        "is_active": true,
        "builder_name": "auron_paine"
      },
      "delta_type": "OMAHA",
      "channel": "dev",
      "chrome_os_version": "9765.21.0",
      "chrome_version": "61.0.3163.38",
      "milestone": 61,
      "generate_delta": true,
      "delta_payload_tests": true,
      "full_payload_tests": true
    },

New payloads should do the right thing.
Status: Verified (was: Fixed)

Sign in to add a comment