New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755668 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 634542



Sign in to add a comment

Reduce color correction tolerance for PutImageData on color managed canvas

Project Member Reported by zakerinasab@chromium.org, Aug 15 2017

Issue description

As detected in https://chromium-review.googlesource.com/c/615031, the required color correction tolerance to pass PutImageData test on color corrected SRGB canvas is very high (5, instead of 1). Investigate this problem and resolve it.

 
Labels: -Type-Bug Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a493e977da564efbe6012947f9342d7471c4103e

commit a493e977da564efbe6012947f9342d7471c4103e
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Sat Aug 26 02:15:24 2017

Fix SRGB color correction tolerance in CRC2D color correction unit test

This change sets the color correction tolerance for SRGB canvas in
putImageData/getImageData turnaround test to 1 (previously 5).
After digging it seems that the higher error in this test was due
to unpremul->premul->unpremul conversion error in clamped uint8.
To fix this, one of the alpha values of the test data is increased
and some additional minor corrections are applied.

Bug:  755668 
Change-Id: Ifb0c55531e151ae93e775da9de3dbfcec5e271fe
Reviewed-on: https://chromium-review.googlesource.com/635403
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497636}
[modify] https://crrev.com/a493e977da564efbe6012947f9342d7471c4103e/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

Status: Fixed (was: Assigned)
Blocking: 634542

Sign in to add a comment