New issue
Advanced search Search tips

Issue 755661 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 4
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Regression with large range doesn't show up in group_report?rev=XXX page

Project Member Reported by sullivan@chromium.org, Aug 15 2017

Issue description

In  bug 755391 , pcc asks why the rasterize_and_record_micro.top_25 regression here: https://chromeperf.appspot.com/group_report?sid=255d2c21b0aa150e6596aeb9a8425c48b09c2058c42bee9efb82c9e7ca5c77e9

Doesn't show up here:
https://chromeperf.appspot.com/group_report?rev=480144

The revision range is 477411 - 488973, which overlaps with 480144. Simon, any ideas?
 
I think this is largely due to how we query for ranges. Since AppEngine doesn't support  multiple inequality filters on a single query, we have trouble doing true range overlap queries. The workaround right now is to query for all alerts with end_revision >= revision, ordered by end_revision, and then manually test to see if their start_revision <= rev. The query is capped at 500 (for display).

Since there's nearly 9k commits between 480144 and 488973, there's going to be a tonne of alerts to sort through (most of which won't overlap the specified revision.

I think make this better, we need to revisit this query and either move to something that does support the query, or investigate something like geohashing.
Demo: https://dev-simonhatch-4d75053b-dot-chromeperf.appspot.com/group_report?rev=480144

I bumped up the limits to absurd amounts here. The regression in question doesn't show up, but some others with massive ranges do.
I think bumping the limits a bit sounds good for now!
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f27e44dcf49e79d287d0068bab57e3824cdb9fe

commit 5f27e44dcf49e79d287d0068bab57e3824cdb9fe
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Aug 16 19:51:00 2017

Roll src/third_party/catapult/ 818332ed8..18998c1fd (2 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/818332ed8043..18998c1fd0cc

$ git log 818332ed8..18998c1fd --date=short --no-merges --format='%ad %ae %s'
2017-08-16 simonhatch Dashboard - Bump alert limits for group_report.
2017-08-16 charliea Move atexit_with_log into py_utils and make BattOrWrapper use it

Created with:
  roll-dep src/third_party/catapult
BUG= 755661 ,755981


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: If9400d60d42f1e6dc8c413231386c43170a7f4c4
Reviewed-on: https://chromium-review.googlesource.com/617269
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494906}
[modify] https://crrev.com/5f27e44dcf49e79d287d0068bab57e3824cdb9fe/DEPS

Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)
We bumped the limits, so closing.

Sign in to add a comment