New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 757933
issue 845191

Blocking:
issue 908001



Sign in to add a comment
link

Issue 755660: Make WebRTC Perf and Baremetal bots run on swarming.

Reported by ehmaldonado@chromium.org, Aug 15 2017 Project Member

Issue description

Make the WebRTC Perf and Baremetal bots execute the tests on swarming.

This will make migration to LUCI much easier, and might even help with getting rid of some hacks.
 
Showing comments 52 - 151 of 151 Older

Comment 53 by bugdroid1@chromium.org, Dec 7 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/bd70b99b9dfd4b56ae39cbd8c636d26a1f99736e

commit bd70b99b9dfd4b56ae39cbd8c636d26a1f99736e
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Thu Dec 07 15:45:57 2017

WebRTC: Use AndroidTest instead of SwarmingPerfTest for Android perf tests.

It looks like using SwarmingPerfTest doesn't work, and I'm not sure why.
I want to try this too.

TBR=phoglund@chromium.org

Bug: 755660
Change-Id: I784da49d7d7f6071e948ea2808a4b3d15901d11f
Reviewed-on: https://chromium-review.googlesource.com/813921
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/bd70b99b9dfd4b56ae39cbd8c636d26a1f99736e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_perf__swarming_.json
[modify] https://crrev.com/bd70b99b9dfd4b56ae39cbd8c636d26a1f99736e/scripts/slave/recipe_modules/webrtc/steps.py

Comment 54 by bugdroid1@chromium.org, Dec 8 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1dac041266cfdbc658835aa20c528479d0f518ea

commit 1dac041266cfdbc658835aa20c528479d0f518ea
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Fri Dec 08 12:13:42 2017

WebRTC: Don't specify bot-id for Android Perf bot.

The bot (build39-b3) seems to be having problems, so we don't
specify any bot to unblock progress.
Also, specify a gtest_filter, so the bot doesn't take as long and
we can fix problems faster.

TBR=phoglund@chromium.org

Bug: 755660
Change-Id: Icee5c4a620049cc02e3e9416eb23f1799b8e7643
Reviewed-on: https://chromium-review.googlesource.com/817114
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/1dac041266cfdbc658835aa20c528479d0f518ea/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/1dac041266cfdbc658835aa20c528479d0f518ea/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_perf__swarming_.json
[modify] https://crrev.com/1dac041266cfdbc658835aa20c528479d0f518ea/scripts/slave/recipe_modules/webrtc/steps.py

Comment 57 by bugdroid1@chromium.org, Jan 11 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f6802ed96d8c9db05158f72577024716a1828fc2

commit f6802ed96d8c9db05158f72577024716a1828fc2
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Thu Jan 11 10:02:32 2018

WebRTC: Add git_revision property.

This will be used when generating expectations for the
Android perf bot.

Bug: 755660
Change-Id: I8fe113cc1d4fe2181b3310b8dd6741e0156ee22c
Reviewed-on: https://chromium-review.googlesource.com/860362
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_builder.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__n_pixel_.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__large_tests_.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.py
[modify] https://crrev.com/f6802ed96d8c9db05158f72577024716a1828fc2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release__large_tests_.json

Comment 58 by bugdroid1@chromium.org, Jan 11 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/6555dc07635e1262d09f93c90a7e02d013975a7a

commit 6555dc07635e1262d09f93c90a7e02d013975a7a
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Thu Jan 11 14:13:53 2018

WebRTC: Set got_revision_cp property on expectations.

Will also be used to generate expectations for the code that uploads
perf results on Android.

Bug: 755660
Change-Id: I01aa003e2536bc70ce9ce69e19736df6592adf95
Reviewed-on: https://chromium-review.googlesource.com/860931
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_builder.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__n_pixel_.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__large_tests_.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.py
[modify] https://crrev.com/6555dc07635e1262d09f93c90a7e02d013975a7a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release__large_tests_.json

Comment 60 by bugdroid1@chromium.org, Jan 11 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f35d488ae90f508fd8fb1c2e03c25f1f321d1542

commit f35d488ae90f508fd8fb1c2e03c25f1f321d1542
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Thu Jan 11 15:29:03 2018

WebRTC: Fix path to perf results JSON file.

Looks like the shard number ('0') is part of the path too.

TBR=phoglund@chromium.org

Bug: 755660
Change-Id: I433c0c5f1e2d15b2794af4cb730f7041b442960e
Reviewed-on: https://chromium-review.googlesource.com/860648
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/f35d488ae90f508fd8fb1c2e03c25f1f321d1542/scripts/slave/recipe_modules/webrtc/steps.py

Comment 61 by bugdroid1@chromium.org, Jan 11 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/29e1b94894c6c2790acfb21d9c6e0e360b0ffff8

commit 29e1b94894c6c2790acfb21d9c6e0e360b0ffff8
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Thu Jan 11 16:10:04 2018

WebRTC: Parse JSON file from perf_result.json.

TBR=phoglund@chromium.org

Bug: 755660
Change-Id: I4ed61be3da6b108d4b0a8d20fb9ff346590ff5e1
Reviewed-on: https://chromium-review.googlesource.com/860653
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/29e1b94894c6c2790acfb21d9c6e0e360b0ffff8/scripts/slave/recipe_modules/webrtc/steps.py

Comment 63 by bugdroid1@chromium.org, Jan 15 2018

Project Member

Comment 64 by bugdroid1@chromium.org, Jan 15 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/b4017712c5cc04d28eda5e81fc54955d72ecfb26

commit b4017712c5cc04d28eda5e81fc54955d72ecfb26
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Mon Jan 15 15:24:09 2018

Store JSON perf results for low_bandwidth_audio_test.

Bug: chromium:755660
Change-Id: I87c19f8dde14772e75f93c723f11408702ca8c8e
Reviewed-on: https://webrtc-review.googlesource.com/39515
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21615}
[modify] https://crrev.com/b4017712c5cc04d28eda5e81fc54955d72ecfb26/audio/test/low_bandwidth_audio_test.py

Comment 66 by bugdroid1@chromium.org, Jan 16 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/98d4036f5a983ba7f64a2a65fafe441709c8c395

commit 98d4036f5a983ba7f64a2a65fafe441709c8c395
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Tue Jan 16 11:42:17 2018

Make it possible to run low_bandwidth_audio_test on Android swarming.

R=phoglund@webrtc.org, solenberg@webrtc.org

Bug: chromium:755660
Change-Id: I8755a9c9df92fe8157c870cc7519130291441b25
Reviewed-on: https://webrtc-review.googlesource.com/39780
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21634}
[modify] https://crrev.com/98d4036f5a983ba7f64a2a65fafe441709c8c395/audio/BUILD.gn
[modify] https://crrev.com/98d4036f5a983ba7f64a2a65fafe441709c8c395/tools_webrtc/mb/mb.py

Comment 68 by bugdroid1@chromium.org, Jan 16 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/d8b041cc543aebf6a36635be762c1302e4c50def

commit d8b041cc543aebf6a36635be762c1302e4c50def
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Tue Jan 16 14:07:54 2018

Ignore extra arguments in low_bandwidth_audio_test.

R=phoglund@webrtc.org
TBR=solenberg@webrtc.org

Bug: chromium:755660
Change-Id: I39488f6905875bdc08b006619b972d3f1af2fce1
Reviewed-on: https://webrtc-review.googlesource.com/39924
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21641}
[modify] https://crrev.com/d8b041cc543aebf6a36635be762c1302e4c50def/audio/test/low_bandwidth_audio_test.py

Comment 69 by bugdroid1@chromium.org, Jan 16 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/50de2fde5990e7a7f2cb3bd676d8fd1d3960dc43

commit 50de2fde5990e7a7f2cb3bd676d8fd1d3960dc43
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Tue Jan 16 20:34:34 2018

WebRTC: Fix path to adb on Android Perf swarming.

ADB_PATH is not defined, so we have to set it manually.
There seems to be no easy way to get the adb path otherwise, and
Chromium is hard-coding it in a roundabout way in [1].

[1] https://cs.chromium.org/chromium/src/build/android/devil_chromium.json?l=17

TBR=phoglund@chromium.org

Bug: 755660'
Change-Id: I1cdccb255b0475592656a7e42b47de83eed1ed86
Reviewed-on: https://chromium-review.googlesource.com/868511
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/50de2fde5990e7a7f2cb3bd676d8fd1d3960dc43/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_perf__swarming_.json
[modify] https://crrev.com/50de2fde5990e7a7f2cb3bd676d8fd1d3960dc43/scripts/slave/recipe_modules/webrtc/steps.py

Comment 70 by bugdroid1@chromium.org, Jan 22 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/1175ecd09599194caa05ecafdc4503e940809fc9

commit 1175ecd09599194caa05ecafdc4503e940809fc9
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Mon Jan 22 14:40:28 2018

Make it possible to run video_quality_loopback_test in swarming.

I made two changes to video_quality_loopback_test to make it possible
to run it on swarming.

1. We need to know the path to frame_analyzer when we're generating
   the build files, and it must be already present.
   I made frame_analyzer a resource, so it's downloaded to a known path
   before generating the build files.
2. The .zip files for apprtc and golang are downloaded and isolated.
   The script now extracts them and installs AppRTC.

Passing task:
 https://chromium-swarm.appspot.com/task?id=3b230bcc04128210

Bug: chromium:755660
Change-Id: I34090897402421d5b7e29f21fbed354551197f92
Reviewed-on: https://webrtc-review.googlesource.com/40920
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21716}
[modify] https://crrev.com/1175ecd09599194caa05ecafdc4503e940809fc9/.gitignore
[modify] https://crrev.com/1175ecd09599194caa05ecafdc4503e940809fc9/examples/BUILD.gn
[modify] https://crrev.com/1175ecd09599194caa05ecafdc4503e940809fc9/examples/androidtests/video_quality_loopback_test.py
[modify] https://crrev.com/1175ecd09599194caa05ecafdc4503e940809fc9/tools_webrtc/mb/gn_isolate_map.pyl
[add] https://crrev.com/1175ecd09599194caa05ecafdc4503e940809fc9/tools_webrtc/video_quality_toolchain/linux/frame_analyzer.sha1

Comment 71 by bugdroid1@chromium.org, Jan 22 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a

commit 8356bbe2e56bb1cbaa4af5c2718c8790d3be843a
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Mon Jan 22 16:00:05 2018

WebRTC: Download video quality toolchain on Android.

Needed because video_quality_loopback_test.py no longer downloads the toolchain.

TBR=phoglund@chromium.org

Bug: 755660
Change-Id: Id4508724df8ad416e973cc3603c63da6870844d7
Reviewed-on: https://chromium-review.googlesource.com/878822
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_builder.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.py
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder_forced.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/README.recipes.md
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_perf__swarming_.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__n_pixel_.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder.json
[modify] https://crrev.com/8356bbe2e56bb1cbaa4af5c2718c8790d3be843a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced_invalid.json

Comment 72 by bugdroid1@chromium.org, Jan 22 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/323cfa6411462574b2e07683abf543c60ef47682

commit 323cfa6411462574b2e07683abf543c60ef47682
Author: Edward Lesmes <ehmaldonado@chromium.org>
Date: Mon Jan 22 16:11:56 2018

Revert "WebRTC: Download video quality toolchain on Android."

This reverts commit 8356bbe2e56bb1cbaa4af5c2718c8790d3be843a.

Reason for revert: Breaks the bots.

Original change's description:
> WebRTC: Download video quality toolchain on Android.
> 
> Needed because video_quality_loopback_test.py no longer downloads the toolchain.
> 
> TBR=phoglund@chromium.org
> 
> Bug: 755660
> Change-Id: Id4508724df8ad416e973cc3603c63da6870844d7
> Reviewed-on: https://chromium-review.googlesource.com/878822
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

TBR=phoglund@chromium.org,ehmaldonado@chromium.org

Change-Id: I13bcc422a5071d97dcac6852a4f33606e527f0b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 755660
Reviewed-on: https://chromium-review.googlesource.com/878823
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_builder.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.py
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder_forced.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/README.recipes.md
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_perf__swarming_.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__n_pixel_.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder.json
[modify] https://crrev.com/323cfa6411462574b2e07683abf543c60ef47682/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced_invalid.json

Comment 73 by bugdroid1@chromium.org, Jan 22 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/9c1848952ede411846df43a143e3a2628f58c329

commit 9c1848952ede411846df43a143e3a2628f58c329
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Mon Jan 22 16:12:10 2018

Revert "Make it possible to run video_quality_loopback_test in swarming."

This reverts commit 1175ecd09599194caa05ecafdc4503e940809fc9.

Reason for revert: Breaks the bots.

Original change's description:
> Make it possible to run video_quality_loopback_test in swarming.
> 
> I made two changes to video_quality_loopback_test to make it possible
> to run it on swarming.
> 
> 1. We need to know the path to frame_analyzer when we're generating
>    the build files, and it must be already present.
>    I made frame_analyzer a resource, so it's downloaded to a known path
>    before generating the build files.
> 2. The .zip files for apprtc and golang are downloaded and isolated.
>    The script now extracts them and installs AppRTC.
> 
> Passing task:
>  https://chromium-swarm.appspot.com/task?id=3b230bcc04128210
> 
> Bug: chromium:755660
> Change-Id: I34090897402421d5b7e29f21fbed354551197f92
> Reviewed-on: https://webrtc-review.googlesource.com/40920
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21716}

TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org

Change-Id: Id25d26adc547ff6f9ab178601e37527459c8b5ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/42800
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21723}
[modify] https://crrev.com/9c1848952ede411846df43a143e3a2628f58c329/.gitignore
[modify] https://crrev.com/9c1848952ede411846df43a143e3a2628f58c329/examples/BUILD.gn
[modify] https://crrev.com/9c1848952ede411846df43a143e3a2628f58c329/examples/androidtests/video_quality_loopback_test.py
[modify] https://crrev.com/9c1848952ede411846df43a143e3a2628f58c329/tools_webrtc/mb/gn_isolate_map.pyl
[delete] https://crrev.com/1723cf9fa2e5b215e9a45923aaa264c1b9dd7dcb/tools_webrtc/video_quality_toolchain/linux/frame_analyzer.sha1

Comment 74 by bugdroid1@chromium.org, Jan 23 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4c9c4dd6473acb088d48f3af9a30e41c55c968ab

commit 4c9c4dd6473acb088d48f3af9a30e41c55c968ab
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Tue Jan 23 12:19:42 2018

Reland "WebRTC: Download video quality toolchain on Android."

This is a reland of 8356bbe2e56bb1cbaa4af5c2718c8790d3be843a.

I had uploaded the files to the wrong bucket, that was why it was failing.

Original change's description:
> WebRTC: Download video quality toolchain on Android.
>
> Needed because video_quality_loopback_test.py no longer downloads the toolchain.
>
> TBR=phoglund@chromium.org
>
> Bug: 755660
> Change-Id: Id4508724df8ad416e973cc3603c63da6870844d7
> Reviewed-on: https://chromium-review.googlesource.com/878822
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 755660
Change-Id: I38a5313d516dfb31d13f06eb187171ddcc6f6f26
Reviewed-on: https://chromium-review.googlesource.com/878702
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_builder.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.py
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder_forced.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/README.recipes.md
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_perf__swarming_.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__n_pixel_.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder.json
[modify] https://crrev.com/4c9c4dd6473acb088d48f3af9a30e41c55c968ab/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced_invalid.json

Comment 75 by bugdroid1@chromium.org, Jan 23 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/70ba9b453cccc958899ea948f25f093ebea11c5d

commit 70ba9b453cccc958899ea948f25f093ebea11c5d
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Tue Jan 23 13:03:17 2018

Reland "Make it possible to run video_quality_loopback_test in swarming."

This is a reland of 1175ecd09599194caa05ecafdc4503e940809fc9.

Original change's description:
> Make it possible to run video_quality_loopback_test in swarming.
> 
> I made two changes to video_quality_loopback_test to make it possible
> to run it on swarming.
> 
> 1. We need to know the path to frame_analyzer when we're generating
>    the build files, and it must be already present.
>    I made frame_analyzer a resource, so it's downloaded to a known path
>    before generating the build files.
> 2. The .zip files for apprtc and golang are downloaded and isolated.
>    The script now extracts them and installs AppRTC.
> 
> Passing task:
>  https://chromium-swarm.appspot.com/task?id=3b230bcc04128210
> 
> Bug: chromium:755660
> Change-Id: I34090897402421d5b7e29f21fbed354551197f92
> Reviewed-on: https://webrtc-review.googlesource.com/40920
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21716}

Bug: chromium:755660
Change-Id: Ie3ca62d64b4fe856485287b7d9d3d9e3f75dc091
Reviewed-on: https://webrtc-review.googlesource.com/42860
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21733}
[modify] https://crrev.com/70ba9b453cccc958899ea948f25f093ebea11c5d/.gitignore
[modify] https://crrev.com/70ba9b453cccc958899ea948f25f093ebea11c5d/examples/BUILD.gn
[modify] https://crrev.com/70ba9b453cccc958899ea948f25f093ebea11c5d/examples/androidtests/video_quality_loopback_test.py
[modify] https://crrev.com/70ba9b453cccc958899ea948f25f093ebea11c5d/tools_webrtc/mb/gn_isolate_map.pyl
[add] https://crrev.com/70ba9b453cccc958899ea948f25f093ebea11c5d/tools_webrtc/video_quality_toolchain/linux/frame_analyzer.sha1

Comment 76 by bugdroid1@chromium.org, Jan 25 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/c9e4522656275f0215836fd44d5ae501115211f4

commit c9e4522656275f0215836fd44d5ae501115211f4
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Thu Jan 25 15:07:54 2018

Add an option to print perf results to a file.

video_quality_analysis unittests need to print perf results to a file [1].
Add an option to make this possible.

[1] https://webrtc.googlesource.com/src/+/master/rtc_tools/frame_analyzer/video_quality_analysis_unittest.cc#72

R=kwiberg@webrtc.org, oprypin@webrtc.org
TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: Ife83c4f026cc5a65dd0a430ddc9ff12eb27ae77c
Reviewed-on: https://webrtc-review.googlesource.com/43460
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21763}
[modify] https://crrev.com/c9e4522656275f0215836fd44d5ae501115211f4/test/testsupport/perf_test.cc
[modify] https://crrev.com/c9e4522656275f0215836fd44d5ae501115211f4/test/testsupport/perf_test.h

Comment 77 by bugdroid1@chromium.org, Jan 25 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/3a5653af1cf7cacd01918adb19d8eded2e002593

commit 3a5653af1cf7cacd01918adb19d8eded2e002593
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Thu Jan 25 17:46:14 2018

Use FILE* instead of const FILE* in perf_test.h

TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: I5e4c808668c8a376d4bd518236ae969c693f979b
Reviewed-on: https://webrtc-review.googlesource.com/43960
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21765}
[modify] https://crrev.com/3a5653af1cf7cacd01918adb19d8eded2e002593/test/testsupport/perf_test.h

Comment 78 by bugdroid1@chromium.org, Jan 30 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/2e5966b3d3f010e1c93ffb9d3db01f7a91ac52ed

commit 2e5966b3d3f010e1c93ffb9d3db01f7a91ac52ed
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Tue Jan 30 16:48:59 2018

Store video_quality_loopback_test perf results in Chart JSON format.

Adds a flag to store the perf results in a JSON file using the Chart
JSON format [1].

[1] https://github.com/catapult-project/catapult/blob/master/dashboard/docs/data-format.md

TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: I6a896654a4a558df217ddefa4e8a52a487cdbebd
Reviewed-on: https://webrtc-review.googlesource.com/43180
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21809}
[modify] https://crrev.com/2e5966b3d3f010e1c93ffb9d3db01f7a91ac52ed/examples/androidtests/video_quality_loopback_test.py
[modify] https://crrev.com/2e5966b3d3f010e1c93ffb9d3db01f7a91ac52ed/rtc_tools/BUILD.gn
[modify] https://crrev.com/2e5966b3d3f010e1c93ffb9d3db01f7a91ac52ed/rtc_tools/compare_videos.py
[modify] https://crrev.com/2e5966b3d3f010e1c93ffb9d3db01f7a91ac52ed/rtc_tools/frame_analyzer/frame_analyzer.cc
[modify] https://crrev.com/2e5966b3d3f010e1c93ffb9d3db01f7a91ac52ed/rtc_tools/frame_analyzer/video_quality_analysis.cc
[modify] https://crrev.com/2e5966b3d3f010e1c93ffb9d3db01f7a91ac52ed/rtc_tools/frame_analyzer/video_quality_analysis.h
[modify] https://crrev.com/2e5966b3d3f010e1c93ffb9d3db01f7a91ac52ed/rtc_tools/frame_analyzer/video_quality_analysis_unittest.cc
[modify] https://crrev.com/2e5966b3d3f010e1c93ffb9d3db01f7a91ac52ed/test/BUILD.gn

Comment 79 by bugdroid1@chromium.org, Jan 30 2018

Project Member

Comment 80 by bugdroid1@chromium.org, Jan 31 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/21a35bc1889a9c4476ba919fc3841938ba48d351

commit 21a35bc1889a9c4476ba919fc3841938ba48d351
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Wed Jan 31 13:50:09 2018

Ignore Chromium-specific flags on video_quality_loopback_test.

TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: I71409a569995708bc4c54b9bbcb2a119feed4be9
Reviewed-on: https://webrtc-review.googlesource.com/46524
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21827}
[modify] https://crrev.com/21a35bc1889a9c4476ba919fc3841938ba48d351/examples/androidtests/video_quality_loopback_test.py

Comment 81 by bugdroid1@chromium.org, Jan 31 2018

Project Member

Comment 82 by bugdroid1@chromium.org, Feb 1 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/d5e17d6831cbfa6735a055efa80b59f9abf8afe6

commit d5e17d6831cbfa6735a055efa80b59f9abf8afe6
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Thu Feb 01 13:27:41 2018

Don't run video_quality_loopback_test from the src dir.

When executed on swarming, the script is run from //out/<android build dir>,
so it's better to keep that convention.

Given that all paths are given, cwd doesn't seem to be needed.

TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: Iabf6603983ff88b1281e8113da1aad3320967b72
Reviewed-on: https://webrtc-review.googlesource.com/46142
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21843}
[modify] https://crrev.com/d5e17d6831cbfa6735a055efa80b59f9abf8afe6/examples/androidtests/video_quality_loopback_test.py

Comment 83 by bugdroid1@chromium.org, Feb 5 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/686ca2e94614173cd3b06658ba477b04c17965f0

commit 686ca2e94614173cd3b06658ba477b04c17965f0
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Mon Feb 05 18:17:27 2018

WebRTC: Request Android M for video_quality_perf_test.

It doesn't work on Android K.

TBR=phoglund@chromium.org

Bug: 755660
Change-Id: I62f20ee21a4c9950db5e6cb6214de3dd6143ff75
Reviewed-on: https://chromium-review.googlesource.com/897862
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/686ca2e94614173cd3b06658ba477b04c17965f0/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/686ca2e94614173cd3b06658ba477b04c17965f0/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_perf__swarming_.json

Comment 84 by bugdroid1@chromium.org, Feb 5 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f56f84ffba7dea4c1c0e2aaa8878672492fda6a5

commit f56f84ffba7dea4c1c0e2aaa8878672492fda6a5
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Mon Feb 05 20:39:18 2018

WebRTC: Get perf results from the right directory in Windows

TBR=phoglund@chromium.org

Bug: 755660
Change-Id: I84ad24d06a6a6e3e3aadab27177d412a3e39a852
Reviewed-on: https://chromium-review.googlesource.com/902542
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/f56f84ffba7dea4c1c0e2aaa8878672492fda6a5/scripts/slave/recipe_modules/webrtc/steps.py

Comment 85 by bugdroid1@chromium.org, Feb 6 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/71d766eb4bd10277faafa1a3a47ebdc1dc4bd716

commit 71d766eb4bd10277faafa1a3a47ebdc1dc4bd716
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Tue Feb 06 11:09:49 2018

Pass the right flag to Android video quality test.

Pass --isolated-script-test-output instead of --chartjson-result-file.

TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: I6b55a4461428526de77bf192600de81b8cc029b2
Reviewed-on: https://webrtc-review.googlesource.com/48180
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21909}
[modify] https://crrev.com/71d766eb4bd10277faafa1a3a47ebdc1dc4bd716/examples/androidtests/video_quality_loopback_test.py

Comment 86 by bugdroid1@chromium.org, Feb 7 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/e4275901feb8e3a3dcdafbd54d554180f0a1a002

commit e4275901feb8e3a3dcdafbd54d554180f0a1a002
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Wed Feb 07 16:33:06 2018

Update frame_analyzer binary.

Update frame_analyzer binary, so that it includes changes to the
perf flags.

Bug: chromium:755660
Change-Id: I9e30cd83b807d2d4fa74a677dc5a69f8985a4ce2
Reviewed-on: https://webrtc-review.googlesource.com/48622
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21946}
[modify] https://crrev.com/e4275901feb8e3a3dcdafbd54d554180f0a1a002/tools_webrtc/video_quality_toolchain/linux/frame_analyzer.sha1

Comment 87 by bugdroid1@chromium.org, Feb 8 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/2b67f5c65f7a331650df868148a495c921b970f8

commit 2b67f5c65f7a331650df868148a495c921b970f8
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Thu Feb 08 19:37:19 2018

MB: Add a way to run tests on swarming without using gtest-parallel.

Adds a new test_type 'raw' to run tests on swarming without wrapping it
on gtest-parallel.

This will be used to run webrtc_perf_tests directly.

Bug: chromium:755660
Change-Id: I8558faadf242d1db1ad3e13083941886c92b1bd9
Reviewed-on: https://webrtc-review.googlesource.com/49360
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21962}
[modify] https://crrev.com/2b67f5c65f7a331650df868148a495c921b970f8/tools_webrtc/mb/mb.py
[modify] https://crrev.com/2b67f5c65f7a331650df868148a495c921b970f8/tools_webrtc/mb/mb_unittest.py

Comment 88 by bugdroid1@chromium.org, Feb 12 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/0c15a092937b1409dbc1dab3151ed7847ac8eaf2

commit 0c15a092937b1409dbc1dab3151ed7847ac8eaf2
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Mon Feb 12 13:10:04 2018

Don't use gtest-parallel when running webrtc_perf_tests.

When we run webrtc_perf_tests with gtest-parallel, each test is run
individually, and this results in the file with the perf results being
overwritten each time.

To avoid this, we won't use gtest-parallel when running webrtc_perf_tests,
so we will simply run the binary directly.

TBR=phoglund@chromium.org

Bug: chromium:755660
Change-Id: I24db36e512fcf604a3de2adf4d0b4325b2c3d1ae
Reviewed-on: https://webrtc-review.googlesource.com/49340
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21982}
[modify] https://crrev.com/0c15a092937b1409dbc1dab3151ed7847ac8eaf2/modules/audio_coding/codecs/isac/fix/test/kenny.cc
[modify] https://crrev.com/0c15a092937b1409dbc1dab3151ed7847ac8eaf2/test/test_main.cc
[modify] https://crrev.com/0c15a092937b1409dbc1dab3151ed7847ac8eaf2/tools_webrtc/gtest-parallel-wrapper.py
[modify] https://crrev.com/0c15a092937b1409dbc1dab3151ed7847ac8eaf2/tools_webrtc/mb/gn_isolate_map.pyl

Comment 90 by bugdroid1@chromium.org, Feb 13 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c5d4687359408a5348501572cfd67e0f4a532a24

commit c5d4687359408a5348501572cfd67e0f4a532a24
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Tue Feb 13 12:16:35 2018

WebRTC: Trigger a simple task in Android Perf (swarming)

Trigger a simple task in Android Perf (swarming) instead of a GTest task.

As it is, it complains because we don't produce an output.json file
with the execution time and success status for each test we ran, and makes
the build purple even though the task succeeded.

Triggering a simple task, we don't check for that file and simply collect
the task results.

Bug: 755660
Change-Id: I11e2332815d022e3a8dafe7651d0e16fa10cda37
Reviewed-on: https://chromium-review.googlesource.com/913578
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/c5d4687359408a5348501572cfd67e0f4a532a24/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_perf__swarming_.json
[modify] https://crrev.com/c5d4687359408a5348501572cfd67e0f4a532a24/scripts/slave/recipe_modules/webrtc/steps.py

Comment 91 by bugdroid1@chromium.org, Mar 2 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7a82f3423de7b15e79da06ca637230c7cab42c8

commit d7a82f3423de7b15e79da06ca637230c7cab42c8
Author: Edward Lesmes <ehmaldonado@chromium.org>
Date: Fri Mar 02 20:47:31 2018

Rename chartjson_result_file flag.

Rename the --chartjson-result-file flag to --isolated-script-test-perf-output.
We started using SwarmingIsolatedScriptTest, which passes that flag instead.

Bug: 755660
Change-Id: I8244e251b0225b0b0ef863f638f72ef2e75a138d
Reviewed-on: https://chromium-review.googlesource.com/914761
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540618}
[modify] https://crrev.com/d7a82f3423de7b15e79da06ca637230c7cab42c8/build/android/pylib/gtest/gtest_test_instance.py
[modify] https://crrev.com/d7a82f3423de7b15e79da06ca637230c7cab42c8/build/android/pylib/local/device/local_device_gtest_run.py
[modify] https://crrev.com/d7a82f3423de7b15e79da06ca637230c7cab42c8/build/android/test_runner.py

Comment 92 by phoglund@chromium.org, Mar 8 2018

Owner: phoglund@chromium.org

Comment 93 by bugdroid1@chromium.org, Mar 9 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ab4a6ed2d7d2210e9c45a111e0af8e53f1c1c266

commit ab4a6ed2d7d2210e9c45a111e0af8e53f1c1c266
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Mar 09 14:44:24 2018

Don't retry perf test failures for WebRTC; re-enable isac_fix.

This sends an arg to src/build/android/test_runner.py so it doesn't
attempt to retry failed tests. The default is 2 retries.

The problem is that webrtc_perf_tests writes a .json, but the android
test runner retry mechanism invokes the binary again, with the test
filter set to the remaining failed tests. Therefore, the .json is
overwritten and the results from the first run are lost.

We may want to allow retries later, but then we must slightly
re-design perf result handling in the WebRTC binaries.

I also re-enable isac_fix_test here since I forgot that earlier.

Bug: chromium:755660
Change-Id: Ia6be0bc4138268c33c063173229724ec69f16ee7
Reviewed-on: https://chromium-review.googlesource.com/956046
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/ab4a6ed2d7d2210e9c45a111e0af8e53f1c1c266/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android_perf__swarming_.json
[modify] https://crrev.com/ab4a6ed2d7d2210e9c45a111e0af8e53f1c1c266/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/ab4a6ed2d7d2210e9c45a111e0af8e53f1c1c266/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/ab4a6ed2d7d2210e9c45a111e0af8e53f1c1c266/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/ab4a6ed2d7d2210e9c45a111e0af8e53f1c1c266/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_win7.json

Comment 94 by bugdroid1@chromium.org, Mar 12 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/5b9c6840b1d92db03108a4f6fe0d94a73aa17d43

commit 5b9c6840b1d92db03108a4f6fe0d94a73aa17d43
Author: Edward Lesmes <ehmaldonado@webrtc.org>
Date: Mon Mar 12 19:51:09 2018

Add num-retries flag to Android perf tests.

Add a flag to Android perf tests, so we can specify the number of
retries.

Bug: chromium:755660
Change-Id: Ic498373421b7e0fdf779a4659a0c79d47a59fbde
Reviewed-on: https://webrtc-review.googlesource.com/61103
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22390}
[modify] https://crrev.com/5b9c6840b1d92db03108a4f6fe0d94a73aa17d43/audio/test/low_bandwidth_audio_test.py
[modify] https://crrev.com/5b9c6840b1d92db03108a4f6fe0d94a73aa17d43/examples/androidtests/video_quality_loopback_test.py

Comment 95 by bugdroid1@chromium.org, Mar 12 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/9599fd44144f34022ea85d2b5201ea25255af6e4

commit 9599fd44144f34022ea85d2b5201ea25255af6e4
Author: Edward Lesmes <ehmaldonado@webrtc.org>
Date: Mon Mar 12 21:19:51 2018

Make num-retries default a string.

TBR=phoglund@webrtc.org

Bug: chromium:755660
Change-Id: I770a79a78721a312b603aec40d23689245a48001
Reviewed-on: https://webrtc-review.googlesource.com/61343
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22392}
[modify] https://crrev.com/9599fd44144f34022ea85d2b5201ea25255af6e4/audio/test/low_bandwidth_audio_test.py
[modify] https://crrev.com/9599fd44144f34022ea85d2b5201ea25255af6e4/examples/androidtests/video_quality_loopback_test.py

Comment 96 by bugdroid1@chromium.org, Mar 13 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f15d03b241df6036fca7426af631ae7a91d26bd6

commit f15d03b241df6036fca7426af631ae7a91d26bd6
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Tue Mar 13 13:13:58 2018

WebRTC: Dowload quality measuring tools only if needed

These are only used in performance tests and never for building

Bug: chromium:755660, chromium:749655
Change-Id: I89f2850a22fc4bd2a03eb285047cd5ed1c3a9f4b
Reviewed-on: https://chromium-review.googlesource.com/960023
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__gcc_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_dbg.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release__arm_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder_forced.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_linux__stable_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug__arm_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__stable_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_experimental.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_builder.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/README.recipes.md
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__clang_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gcc_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__arm_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__clang_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_asan.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_experimental.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__arm_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_dbg.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug__clang_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_dbg.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__beta_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_dbg.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_dbg.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__stable_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_experimental.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_dbg.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_rel.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/f15d03b241df6036fca7426af631ae7a91d26bd6/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_linux__beta_.json

Comment 97 by bugdroid1@chromium.org, Mar 14 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/52b62a8611c3b194750a6ca25b781f69bbcbee10

commit 52b62a8611c3b194750a6ca25b781f69bbcbee10
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Mar 14 07:52:18 2018

Revert "WebRTC: Dowload quality measuring tools only if needed"

This reverts commit f15d03b241df6036fca7426af631ae7a91d26bd6.

Reason for revert: Causes flaky failures in the test isolate step: isolate: isolate C:\b\c\b\Win32_Debug\src\out\Debug\low_bandwidth_audio_test.isolate: partitioning deps: GetFileAttributesEx C:\b\c\b\Win32_Debug\src\tools_webrtc\audio_quality\win\PolqaOem64.dll: The system cannot find the file specified. https://build.chromium.org/p/client.webrtc/builders/Win32%20Debug/builds/16979

Original change's description:
> WebRTC: Dowload quality measuring tools only if needed
> 
> These are only used in performance tests and never for building
> 
> Bug: chromium:755660, chromium:749655
> Change-Id: I89f2850a22fc4bd2a03eb285047cd5ed1c3a9f4b
> Reviewed-on: https://chromium-review.googlesource.com/960023
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Oleh Prypin <oprypin@chromium.org>

TBR=phoglund@chromium.org,machenbach@chromium.org,oprypin@chromium.org

Change-Id: Ieee5bfb424dc687b77aa22e155ffd1f69c80947b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660, chromium:749655
Reviewed-on: https://chromium-review.googlesource.com/962024
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>

[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__gcc_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_dbg.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release__arm_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder_forced.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_linux__stable_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug__arm_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__stable_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_experimental.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_builder.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/README.recipes.md
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__clang_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gcc_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__arm_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__clang_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_asan.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_experimental.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__arm_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_dbg.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug__clang_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_dbg.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__beta_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_dbg.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_dbg.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__stable_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_experimental.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_dbg.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_rel.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/52b62a8611c3b194750a6ca25b781f69bbcbee10/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_linux__beta_.json

Comment 98 by bugdroid1@chromium.org, Mar 15 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/4bbc150b18e961811991e3e524378e703b6d5b31

commit 4bbc150b18e961811991e3e524378e703b6d5b31
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu Mar 15 10:22:56 2018

Split perf-test-specific resources in low_bandwidth_audio_test

Bug: chromium:755660
Change-Id: I7c60a47b26ad86892218497f28a09a04574077e6
Reviewed-on: https://webrtc-review.googlesource.com/61961
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22439}
[modify] https://crrev.com/4bbc150b18e961811991e3e524378e703b6d5b31/audio/BUILD.gn
[modify] https://crrev.com/4bbc150b18e961811991e3e524378e703b6d5b31/tools_webrtc/mb/gn_isolate_map.pyl

Comment 99 by bugdroid1@chromium.org, Mar 15 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/aaa882cea5dc42532e44d8ed9b1eaeb064a249a1

commit aaa882cea5dc42532e44d8ed9b1eaeb064a249a1
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu Mar 15 10:47:47 2018

Revert "Split perf-test-specific resources in low_bandwidth_audio_test"

This reverts commit 4bbc150b18e961811991e3e524378e703b6d5b31.

Reason for revert: Breaks on perf Mac bot
https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/5696

Original change's description:
> Split perf-test-specific resources in low_bandwidth_audio_test
> 
> Bug: chromium:755660
> Change-Id: I7c60a47b26ad86892218497f28a09a04574077e6
> Reviewed-on: https://webrtc-review.googlesource.com/61961
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22439}

TBR=phoglund@webrtc.org,oprypin@webrtc.org

Change-Id: I235301020417416745c1e754b4dd57726dfb27ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/61980
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22442}
[modify] https://crrev.com/aaa882cea5dc42532e44d8ed9b1eaeb064a249a1/audio/BUILD.gn
[modify] https://crrev.com/aaa882cea5dc42532e44d8ed9b1eaeb064a249a1/tools_webrtc/mb/gn_isolate_map.pyl

Comment 100 by bugdroid1@chromium.org, Mar 15 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/b3808dcc36e4dca8b3d2b68c79e20c5888397690

commit b3808dcc36e4dca8b3d2b68c79e20c5888397690
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu Mar 15 13:04:57 2018

Reland "Split perf-test-specific resources in low_bandwidth_audio_test"

This is a reland of 4bbc150b18e961811991e3e524378e703b6d5b31

Now using rtc_source_set to be able to generate runtime deps

Original change's description:
> Split perf-test-specific resources in low_bandwidth_audio_test
>
> Bug: chromium:755660
> Change-Id: I7c60a47b26ad86892218497f28a09a04574077e6
> Reviewed-on: https://webrtc-review.googlesource.com/61961
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22439}

No-Try: True
Bug: chromium:755660
Change-Id: I66eda6f016c98e2a8a99f230d9e0323cc09e4976
Reviewed-on: https://webrtc-review.googlesource.com/62020
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22450}
[modify] https://crrev.com/b3808dcc36e4dca8b3d2b68c79e20c5888397690/audio/BUILD.gn
[modify] https://crrev.com/b3808dcc36e4dca8b3d2b68c79e20c5888397690/tools_webrtc/mb/gn_isolate_map.pyl

Comment 101 by bugdroid1@chromium.org, Mar 15 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/650a826cdabb4bd6a4174439d4985195f017c678

commit 650a826cdabb4bd6a4174439d4985195f017c678
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu Mar 15 13:52:47 2018

Revert "Reland "Split perf-test-specific resources in low_bandwidth_audio_test""

This reverts commit b3808dcc36e4dca8b3d2b68c79e20c5888397690.

Reason for revert: Still fails to generate runtime_deps

Original change's description:
> Reland "Split perf-test-specific resources in low_bandwidth_audio_test"
> 
> This is a reland of 4bbc150b18e961811991e3e524378e703b6d5b31
> 
> Now using rtc_source_set to be able to generate runtime deps
> 
> Original change's description:
> > Split perf-test-specific resources in low_bandwidth_audio_test
> >
> > Bug: chromium:755660
> > Change-Id: I7c60a47b26ad86892218497f28a09a04574077e6
> > Reviewed-on: https://webrtc-review.googlesource.com/61961
> > Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> > Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#22439}
> 
> No-Try: True
> Bug: chromium:755660
> Change-Id: I66eda6f016c98e2a8a99f230d9e0323cc09e4976
> Reviewed-on: https://webrtc-review.googlesource.com/62020
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22450}

TBR=phoglund@webrtc.org,oprypin@webrtc.org

Change-Id: I781e3172416164e6d313574a31e4c982de8bcd9c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/62120
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22454}
[modify] https://crrev.com/650a826cdabb4bd6a4174439d4985195f017c678/audio/BUILD.gn
[modify] https://crrev.com/650a826cdabb4bd6a4174439d4985195f017c678/tools_webrtc/mb/gn_isolate_map.pyl

Comment 102 by bugdroid1@chromium.org, Mar 19 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/8cf0a87bc3877f75bad7136a1c5b2b0c1186841c

commit 8cf0a87bc3877f75bad7136a1c5b2b0c1186841c
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Mon Mar 19 09:30:01 2018

Reland "Split perf-test-specific resources in low_bandwidth_audio_test"

This is a reland of 4bbc150b18e961811991e3e524378e703b6d5b31

Now with explicitly specified `write_runtime_deps`

Original change's description:
> Split perf-test-specific resources in low_bandwidth_audio_test
>
> Bug: chromium:755660
> Change-Id: I7c60a47b26ad86892218497f28a09a04574077e6
> Reviewed-on: https://webrtc-review.googlesource.com/61961
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22439}

Bug: chromium:755660
TBR: phoglund@webrtc.org
Change-Id: I3d4bcc5156ee25de399ab23773ecb73cd995075c
Reviewed-on: https://webrtc-review.googlesource.com/62660
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22483}
[modify] https://crrev.com/8cf0a87bc3877f75bad7136a1c5b2b0c1186841c/audio/BUILD.gn
[modify] https://crrev.com/8cf0a87bc3877f75bad7136a1c5b2b0c1186841c/tools_webrtc/mb/gn_isolate_map.pyl

Comment 103 by bugdroid1@chromium.org, Mar 19 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/7b2676fee9bd1f8b491f3832ff688a13261d610b

commit 7b2676fee9bd1f8b491f3832ff688a13261d610b
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Mon Mar 19 10:54:11 2018

Fix low_bandwidth_audio_perf_test binary dependency on Windows

The split in https://webrtc-review.googlesource.com/c/src/+/62660
broke it.

No-Try: True
Bug: chromium:755660
Change-Id: I664f022cac9f8e7e0bb64a7cb59992f030543aa6
Reviewed-on: https://webrtc-review.googlesource.com/62801
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22486}
[modify] https://crrev.com/7b2676fee9bd1f8b491f3832ff688a13261d610b/audio/BUILD.gn

Comment 104 by bugdroid1@chromium.org, Mar 19 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ba55b44d0aa894cbb4f1f0e9955996751b8468fe

commit ba55b44d0aa894cbb4f1f0e9955996751b8468fe
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Mon Mar 19 12:24:05 2018

Reland "WebRTC: Dowload quality measuring tools only if needed"

This is a reland of f15d03b241df6036fca7426af631ae7a91d26bd6

Isolate is fixed in https://webrtc-review.googlesource.com/c/src/+/62660

Original change's description:
> WebRTC: Dowload quality measuring tools only if needed
>
> These are only used in performance tests and never for building
>
> Bug: chromium:755660, chromium:749655
> Change-Id: I89f2850a22fc4bd2a03eb285047cd5ed1c3a9f4b
> Reviewed-on: https://chromium-review.googlesource.com/960023
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Oleh Prypin <oprypin@chromium.org>

Bug: chromium:755660, chromium:749655
Change-Id: If07e6a27aeadb7ff199e042ed3d04e2051b43bb3
Reviewed-on: https://chromium-review.googlesource.com/963424
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>

[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__gcc_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_dbg.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release__arm_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder_forced.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_linux__stable_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug__arm_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__stable_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_experimental.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_builder.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/README.recipes.md
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__clang_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gcc_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__arm_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__clang_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_asan.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_experimental.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__arm_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_dbg.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug__clang_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_dbg.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__beta_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_dbg.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_dbg.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_mac__stable_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_experimental.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_dbg.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_win__beta_.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_rel.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/ba55b44d0aa894cbb4f1f0e9955996751b8468fe/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_branches_linux__beta_.json

Comment 105 by bugdroid1@chromium.org, Mar 19 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/9c1ee368e071bf31650806289248c644095aa1df

commit 9c1ee368e071bf31650806289248c644095aa1df
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Mon Mar 19 15:02:51 2018

Fix low_bandwidth_audio_perf_test resource dependency on Android

The executable that's pushed to the device must depend on all
files that need to be on the device.

No-Try: True
TBR: phoglund@webrtc.org
Bug: chromium:755660
Change-Id: Iee041bd51e789e3ce6612fbda1582286a5cf4680
Reviewed-on: https://webrtc-review.googlesource.com/62961
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22494}
[modify] https://crrev.com/9c1ee368e071bf31650806289248c644095aa1df/audio/BUILD.gn

Comment 106 by bugdroid1@chromium.org, Mar 20 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/345d5f1b785f1d80d9d07d4b70811f61756b99d6

commit 345d5f1b785f1d80d9d07d4b70811f61756b99d6
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Mar 20 14:02:47 2018

Roll src/third_party/webrtc/ d2c8332e2..9047dac75 (23 commits)

https://webrtc.googlesource.com/src.git/+log/d2c8332e2b03..9047dac7576d

$ git log d2c8332e2..9047dac75 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:None,chromium:None,chromium:822799,chromium:680172,chromium:None,chromium:755660,chromium:None,chromium:None,chromium:None,chromium:755660


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia063873eca78ba81cec927cf4374423586bb338f
Reviewed-on: https://chromium-review.googlesource.com/970723
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544347}
[modify] https://crrev.com/345d5f1b785f1d80d9d07d4b70811f61756b99d6/DEPS

Comment 107 by bugdroid1@chromium.org, May 14 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/807d05a0ac6a4112f604b0c619e10f115cabbc9f

commit 807d05a0ac6a4112f604b0c619e10f115cabbc9f
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Mon May 14 06:47:43 2018

Remove client.webrtc baremetal bots

The machines will be migrated to swarming and the tests will be re-added to normal release bots

Bug: chromium:755660
Change-Id: I29ce7f7a5bfcc44500d790e79fecab9291abda0c
Reviewed-on: https://chromium-review.googlesource.com/1053771
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/807d05a0ac6a4112f604b0c619e10f115cabbc9f/masters/master.client.webrtc/master_mac_cfg.py
[modify] https://crrev.com/807d05a0ac6a4112f604b0c619e10f115cabbc9f/masters/master.client.webrtc/master_win_cfg.py
[modify] https://crrev.com/807d05a0ac6a4112f604b0c619e10f115cabbc9f/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/807d05a0ac6a4112f604b0c619e10f115cabbc9f/masters/master.client.webrtc/master_linux_cfg.py
[delete] https://crrev.com/677b29788aedb625fdbfd5b75cd09cbbc406fb72/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release__large_tests_.json
[delete] https://crrev.com/677b29788aedb625fdbfd5b75cd09cbbc406fb72/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__large_tests_.json
[modify] https://crrev.com/807d05a0ac6a4112f604b0c619e10f115cabbc9f/masters/master.client.webrtc/slaves.cfg
[delete] https://crrev.com/677b29788aedb625fdbfd5b75cd09cbbc406fb72/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json

Comment 108 by oprypin@google.com, May 14 2018

Bootstrapped swarming on these machines:

build7-b3.labs
build4-b3.labs
build20-b3.labs

Comment 109 by bugdroid1@chromium.org, May 14 2018

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/48dde797a867734d214e92eebaab093e7dda2e2a

commit 48dde797a867734d214e92eebaab093e7dda2e2a
Author: Oleh Prypin <oprypin@google.com>
Date: Mon May 14 08:08:03 2018

Comment 110 by oprypin@google.com, May 14 2018

Cc: oprypin@chromium.org
Owner: oprypin@chromium.org

Comment 111 by oprypin@google.com, May 14 2018

Status: Started (was: Assigned)

Comment 113 by bugdroid1@chromium.org, May 14 2018

Project Member

Comment 114 by bugdroid1@chromium.org, May 14 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/c1a8603a005259a9f7c7c35ca6eb9652a9960595

commit c1a8603a005259a9f7c7c35ca6eb9652a9960595
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Mon May 14 12:31:59 2018

Add video_capture_tests to isolate map

TBR: phoglund@webrtc.org
No-Try: True
Bug: chromium:755660
Change-Id: Ib2a63835e4184f6cdf2ed6ff76b78f3f818c0336
Reviewed-on: https://webrtc-review.googlesource.com/76541
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23214}
[modify] https://crrev.com/c1a8603a005259a9f7c7c35ca6eb9652a9960595/tools_webrtc/mb/gn_isolate_map.pyl

Comment 115 by bugdroid1@chromium.org, May 14 2018

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/50514d393b934f86a269d6a3803c72ed0b22c460

commit 50514d393b934f86a269d6a3803c72ed0b22c460
Author: Oleh Prypin <oprypin@google.com>
Date: Mon May 14 12:50:19 2018

Comment 116 by bugdroid1@chromium.org, May 14 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/69ba82342ae3e9ae78b190b3a36d67c7338cd7f3

commit 69ba82342ae3e9ae78b190b3a36d67c7338cd7f3
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Mon May 14 13:28:43 2018

WebRTC: Don't specify gpu:none for baremetal tests

The default for chrome is to specify 'gpu': 'none', while 'gpu': None means "don't specify it".
Our baremetal bots don't have this dimension, so tests couldn't find a machine.

Bug: chromium:755660
Change-Id: I63270ace0e702b91c3d957d23af89eba6a8ad0e5
Reviewed-on: https://chromium-review.googlesource.com/1057568
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>

[modify] https://crrev.com/69ba82342ae3e9ae78b190b3a36d67c7338cd7f3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json
[modify] https://crrev.com/69ba82342ae3e9ae78b190b3a36d67c7338cd7f3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json
[modify] https://crrev.com/69ba82342ae3e9ae78b190b3a36d67c7338cd7f3/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/69ba82342ae3e9ae78b190b3a36d67c7338cd7f3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json

Comment 118 by oprypin@google.com, May 15 2018

--------
client.webrtc is done.
Now for tryserver.
--------

Comment 119 by bugdroid1@chromium.org, May 15 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e39e50eb90db719e9d818d4824cd6054df9af00e

commit e39e50eb90db719e9d818d4824cd6054df9af00e
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Tue May 15 08:51:21 2018

WebRTC: Remove obsolete baremetal builders from LKGR

Bug: chromium:755660
Change-Id: I8bfd35ed47269a953dea0140686918870b0f372c
Reviewed-on: https://chromium-review.googlesource.com/1059107
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/e39e50eb90db719e9d818d4824cd6054df9af00e/infra/services/lkgr_finder/config/webrtc_cfg.pyl

Comment 120 by bugdroid1@chromium.org, May 15 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93f29b0977bdc193c10eb987eaca75db3c2e0e08

commit 93f29b0977bdc193c10eb987eaca75db3c2e0e08
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue May 15 11:45:43 2018

Roll src/third_party/webrtc/ 8a150d9c2..5702736f7 (21 commits)

https://webrtc.googlesource.com/src.git/+log/8a150d9c2134..5702736f7e46

$ git log 8a150d9c2..5702736f7 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:none,chromium:None,chromium:none,chromium:None,chromium:None,chromium:None,chromium:755660


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib0593ca5d9f2ccf1eb7f7df04b2df6faa21eeb94
Reviewed-on: https://chromium-review.googlesource.com/1059014
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558662}
[modify] https://crrev.com/93f29b0977bdc193c10eb987eaca75db3c2e0e08/DEPS

Comment 121 by bugdroid1@chromium.org, May 17 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/cd469a4ce5315fee62bb77b5e781a18a99da506d

commit cd469a4ce5315fee62bb77b5e781a18a99da506d
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu May 17 11:13:01 2018

Add support for launching webcam software for use in recipes

* Copy ensure_webcam_is_running.py from recipes repo
* Turn it into a wrapper that can launch another script
  (fix_python_path is copied from test_env.py as _ForcePythonInterpreter)
* Support it in mb.py
* Add it to video_capture_unittests

No-Try: True
Bug: chromium:755660
Change-Id: I376724a77e443620724add7818592e9368d02079
Reviewed-on: https://webrtc-review.googlesource.com/77320
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23275}
[add] https://crrev.com/cd469a4ce5315fee62bb77b5e781a18a99da506d/tools_webrtc/ensure_webcam_is_running.py
[modify] https://crrev.com/cd469a4ce5315fee62bb77b5e781a18a99da506d/tools_webrtc/mb/gn_isolate_map.pyl
[modify] https://crrev.com/cd469a4ce5315fee62bb77b5e781a18a99da506d/tools_webrtc/mb/mb.py
[modify] https://crrev.com/cd469a4ce5315fee62bb77b5e781a18a99da506d/tools_webrtc/mb/mb_unittest.py

Comment 122 by bugdroid1@chromium.org, May 17 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/e62e18fe13f9d7f08c355295adc4b197a648d739

commit e62e18fe13f9d7f08c355295adc4b197a648d739
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu May 17 11:24:01 2018

Revert "Add support for launching webcam software for use in recipes"

This reverts commit cd469a4ce5315fee62bb77b5e781a18a99da506d.

Reason for revert: ImportError: No module named psutil

Original change's description:
> Add support for launching webcam software for use in recipes
> 
> * Copy ensure_webcam_is_running.py from recipes repo
> * Turn it into a wrapper that can launch another script
>   (fix_python_path is copied from test_env.py as _ForcePythonInterpreter)
> * Support it in mb.py
> * Add it to video_capture_unittests
> 
> No-Try: True
> Bug: chromium:755660
> Change-Id: I376724a77e443620724add7818592e9368d02079
> Reviewed-on: https://webrtc-review.googlesource.com/77320
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23275}

TBR=phoglund@webrtc.org,oprypin@webrtc.org

Change-Id: I611e49e1c8d8668fe405e462ec4b83e364c3d6e7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/77440
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23278}
[delete] https://crrev.com/eeaa8f929cd12c87d673527624ce31ae38f12e65/tools_webrtc/ensure_webcam_is_running.py
[modify] https://crrev.com/e62e18fe13f9d7f08c355295adc4b197a648d739/tools_webrtc/mb/gn_isolate_map.pyl
[modify] https://crrev.com/e62e18fe13f9d7f08c355295adc4b197a648d739/tools_webrtc/mb/mb.py
[modify] https://crrev.com/e62e18fe13f9d7f08c355295adc4b197a648d739/tools_webrtc/mb/mb_unittest.py

Comment 123 by bugdroid1@chromium.org, May 17 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/739b8169ef7d8e21d2c9fde42096c8f9cfeabe24

commit 739b8169ef7d8e21d2c9fde42096c8f9cfeabe24
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu May 17 11:42:21 2018

Reland "Add support for launching webcam software for use in recipes"

This is a reland of cd469a4ce5315fee62bb77b5e781a18a99da506d
With vpython specified

Original change's description:
> Add support for launching webcam software for use in recipes
>
> * Copy ensure_webcam_is_running.py from recipes repo
> * Turn it into a wrapper that can launch another script
>   (fix_python_path is copied from test_env.py as _ForcePythonInterpreter)
> * Support it in mb.py
> * Add it to video_capture_unittests
>
> No-Try: True
> Bug: chromium:755660
> Change-Id: I376724a77e443620724add7818592e9368d02079
> Reviewed-on: https://webrtc-review.googlesource.com/77320
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#23275}

No-Try: True
Bug: chromium:755660
Change-Id: Ibf4fbe3fea4b003a23b12332b3a6078a2db99a8d
Reviewed-on: https://webrtc-review.googlesource.com/77460
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23279}
[add] https://crrev.com/739b8169ef7d8e21d2c9fde42096c8f9cfeabe24/tools_webrtc/ensure_webcam_is_running.py
[modify] https://crrev.com/739b8169ef7d8e21d2c9fde42096c8f9cfeabe24/tools_webrtc/mb/gn_isolate_map.pyl
[modify] https://crrev.com/739b8169ef7d8e21d2c9fde42096c8f9cfeabe24/tools_webrtc/mb/mb.py
[modify] https://crrev.com/739b8169ef7d8e21d2c9fde42096c8f9cfeabe24/tools_webrtc/mb/mb_unittest.py

Comment 124 by bugdroid1@chromium.org, May 17 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/09ec3cf7c63f25a11679bcc3e01d5a51a4dff073

commit 09ec3cf7c63f25a11679bcc3e01d5a51a4dff073
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu May 17 14:26:01 2018

Fix logic for camera check. Still run the test if webcam is found

TBR: phoglund@webrtc.org
No-Try: True
Bug: chromium:755660
Change-Id: Iea1ae4a599a644aca18181f68fe155a659163766
Reviewed-on: https://webrtc-review.googlesource.com/77426
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23286}
[modify] https://crrev.com/09ec3cf7c63f25a11679bcc3e01d5a51a4dff073/tools_webrtc/ensure_webcam_is_running.py

Comment 125 by bugdroid1@chromium.org, May 17 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a37b9be2202fae823677bd09849dd7a3be506b7d

commit a37b9be2202fae823677bd09849dd7a3be506b7d
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 17 18:08:33 2018

Roll src/third_party/webrtc/ ef75ebef5..f8d8d6d00 (39 commits)

https://webrtc.googlesource.com/src.git/+log/ef75ebef5520..f8d8d6d00c16

$ git log ef75ebef5..f8d8d6d00 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:840536,chromium:755660,chromium:755660,chromium:755660,chromium:None,chromium:None,chromium:None,chromium:None,chromium:836790,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iec936924677ed8093fba2631fdef8a0041ad403c
Reviewed-on: https://chromium-review.googlesource.com/1064318
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559607}
[modify] https://crrev.com/a37b9be2202fae823677bd09849dd7a3be506b7d/DEPS

Comment 126 by bugdroid1@chromium.org, May 18 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/0ab95b97c8874b98e424cc596869c73836151636

commit 0ab95b97c8874b98e424cc596869c73836151636
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Fri May 18 07:03:32 2018

Remove all baremetal bots, baremetal tests will be part of *_rel

See https://chromium-review.googlesource.com/c/chromium/tools/build/+/1058799
After the baremetal machines are moved to swarming, that CL will add the tasks that were previously in *_baremetal bots to *_rel bots. *_rel bots will run all the same tasks as before on a pool of generic machines, but also run a few tests on dedicated baremetal machines (pool:WebRTC-baremetal-try).

No-Try: True
Bug: chromium:755660
Change-Id: I99d62a84aac631b1c127bf661546baecb2a3ae9a
Reviewed-on: https://webrtc-review.googlesource.com/76721
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23290}
[modify] https://crrev.com/0ab95b97c8874b98e424cc596869c73836151636/infra/config/cq.cfg
[modify] https://crrev.com/0ab95b97c8874b98e424cc596869c73836151636/tools_webrtc/mb/mb_config.pyl

Comment 127 by bugdroid1@chromium.org, May 18 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2265493342581025e4b8216e08cc9112e8d5658e

commit 2265493342581025e4b8216e08cc9112e8d5658e
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Fri May 18 07:28:33 2018

Remove tryserver.webrtc baremetal bots

The machines will be migrated to swarming and the tests will be re-added to normal release bots.

Also remove remaining references to baremetal test configs.

Note: "ensure webcam is running" is served by mb config instead since https://webrtc-review.googlesource.com/c/src/+/77460

Bug: chromium:755660
Change-Id: Ie14f587824b15e5ad63624daeafba62e29afb189
Reviewed-on: https://chromium-review.googlesource.com/1058791
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/2265493342581025e4b8216e08cc9112e8d5658e/masters/master.tryserver.webrtc/slaves.cfg
[modify] https://crrev.com/2265493342581025e4b8216e08cc9112e8d5658e/scripts/slave/recipe_modules/webrtc/builders.py
[delete] https://crrev.com/26d9e83f511acf7d86d4be624235b10c523e56d6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json
[delete] https://crrev.com/26d9e83f511acf7d86d4be624235b10c523e56d6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json
[modify] https://crrev.com/2265493342581025e4b8216e08cc9112e8d5658e/masters/master.tryserver.webrtc/master.cfg
[delete] https://crrev.com/26d9e83f511acf7d86d4be624235b10c523e56d6/scripts/slave/recipe_modules/webrtc/resources/ensure_webcam_is_running.py
[modify] https://crrev.com/2265493342581025e4b8216e08cc9112e8d5658e/scripts/slave/README.recipes.md
[modify] https://crrev.com/2265493342581025e4b8216e08cc9112e8d5658e/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/2265493342581025e4b8216e08cc9112e8d5658e/scripts/slave/recipe_modules/webrtc/gclient_config.py
[modify] https://crrev.com/2265493342581025e4b8216e08cc9112e8d5658e/scripts/slave/recipe_modules/webrtc/api.py
[delete] https://crrev.com/26d9e83f511acf7d86d4be624235b10c523e56d6/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json

Comment 128 by bugdroid1@chromium.org, May 18 2018

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/25619192e31406961451026fd557b642b9b8956b

commit 25619192e31406961451026fd557b642b9b8956b
Author: Oleh Prypin <oprypin@google.com>
Date: Fri May 18 07:45:42 2018

Comment 129 by oprypin@chromium.org, May 18 2018

Bootstrapped swarming on these machines:
build115-b4 build138-b4 build144-b4  build116-b4 build133-b4 build135-b4 build139-b4 build143-b4  build123-b4 build124-b4

Comment 131 by bugdroid1@chromium.org, May 18 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/174e952f9e74ad974a5b66c2b9317edc6ebb62f2

commit 174e952f9e74ad974a5b66c2b9317edc6ebb62f2
Author: Oleh Prypin <oprypin@chromium.org>
Date: Fri May 18 09:13:14 2018

Revert "WebRTC: Run baremetal swarming tasks together with *_rel trybots"

This reverts commit 29e606322e43d0d1b6c3036280fc7f4a3d50a863.

Reason for revert: win_rel fails webrtc_perf_tests

Original change's description:
> WebRTC: Run baremetal swarming tasks together with *_rel trybots
> 
> Bug: chromium:755660
> Change-Id: I59423f679a37a9bff6506b26bee8dd223ccffc17
> Reviewed-on: https://chromium-review.googlesource.com/1058799
> Commit-Queue: Oleh Prypin <oprypin@chromium.org>
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>

TBR=phoglund@chromium.org,oprypin@chromium.org

Change-Id: Ia819c99ae5483d483e43c0cda8868089d441e7fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:755660
Reviewed-on: https://chromium-review.googlesource.com/1065812
Reviewed-by: Oleh Prypin <oprypin@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/174e952f9e74ad974a5b66c2b9317edc6ebb62f2/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/174e952f9e74ad974a5b66c2b9317edc6ebb62f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json
[modify] https://crrev.com/174e952f9e74ad974a5b66c2b9317edc6ebb62f2/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/174e952f9e74ad974a5b66c2b9317edc6ebb62f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/174e952f9e74ad974a5b66c2b9317edc6ebb62f2/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json

Comment 132 by bugdroid1@chromium.org, May 18 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56035060edd273dc02a435269e3be77971cc3386

commit 56035060edd273dc02a435269e3be77971cc3386
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri May 18 11:24:32 2018

Roll src/third_party/webrtc/ f8d8d6d00..4639d46ea (9 commits)

https://webrtc.googlesource.com/src.git/+log/f8d8d6d00c16..4639d46eaaa7

$ git log f8d8d6d00..4639d46ea --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:749664,chromium:None,chromium:755660,chromium:none,chromium:755660


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I756a4a2a935296d3c20dd926253dd1517393b4e0
Reviewed-on: https://chromium-review.googlesource.com/1065795
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559861}
[modify] https://crrev.com/56035060edd273dc02a435269e3be77971cc3386/DEPS

Comment 133 by bugdroid1@chromium.org, May 21 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/7a2c64309c629e0aa4b63406f48b83840cdc46b5

commit 7a2c64309c629e0aa4b63406f48b83840cdc46b5
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Mon May 21 06:34:55 2018

Reland "WebRTC: Run baremetal swarming tasks together with *_rel trybots"

This is a reland of 29e606322e43d0d1b6c3036280fc7f4a3d50a863
with the broken test disabled.

Original change's description:
> WebRTC: Run baremetal swarming tasks together with *_rel trybots
>
> Bug: chromium:755660
> Change-Id: I59423f679a37a9bff6506b26bee8dd223ccffc17
> Reviewed-on: https://chromium-review.googlesource.com/1058799
> Commit-Queue: Oleh Prypin <oprypin@chromium.org>
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>

Bug: chromium:755660, webrtc:9290
Change-Id: I447918d248b108318b54d759687416f0fa2646cb
Reviewed-on: https://chromium-review.googlesource.com/1065931
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/7a2c64309c629e0aa4b63406f48b83840cdc46b5/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/7a2c64309c629e0aa4b63406f48b83840cdc46b5/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json
[modify] https://crrev.com/7a2c64309c629e0aa4b63406f48b83840cdc46b5/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/7a2c64309c629e0aa4b63406f48b83840cdc46b5/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/7a2c64309c629e0aa4b63406f48b83840cdc46b5/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json

Comment 134 by oprypin@chromium.org, May 21 2018

Blockedon: 845191

Comment 135 by oprypin@chromium.org, Jun 28 2018

Issue 814652 has been merged into this issue.

Comment 136 by bugdroid1@chromium.org, Sep 24

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/9931ddbbc830249dd45ea8ab10448c3078126e39

commit 9931ddbbc830249dd45ea8ab10448c3078126e39
Author: Yves Gerey <yvesg@webrtc.org>
Date: Mon Sep 24 16:14:09 2018

ResultsContainer: Initialize fields.

Make msan happier. Prevent flakiness.

Bug: chromium:755660
Bug: webrtc:9767
Change-Id: I911ff9ccc65af3f0a6faf9358a0111f4bf927baa
Reviewed-on: https://webrtc-review.googlesource.com/101361
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24805}
[modify] https://crrev.com/9931ddbbc830249dd45ea8ab10448c3078126e39/rtc_tools/frame_analyzer/video_quality_analysis.h

Comment 137 by bugdroid1@chromium.org, Sep 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76346c9b0afb2febbf2bf3c8d2785ce342e8ad0e

commit 76346c9b0afb2febbf2bf3c8d2785ce342e8ad0e
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Sep 24 23:40:00 2018

Roll src/third_party/webrtc 645512ba5966..a36631cdb571 (26 commits)

https://webrtc.googlesource.com/src.git/+log/645512ba5966..a36631cdb571


git log 645512ba5966..a36631cdb571 --date=short --no-merges --format='%ad %ae %s'
2018-09-24 danilchap@webrtc.org Expect late delayed task is deleted.
2018-09-24 buildbot@webrtc.org Roll chromium_revision c92470b71e..695c43e432 (593506:593611)
2018-09-24 niklas.enbom@webrtc.org Revert "Bug in histogram metric reporting."
2018-09-24 srte@webrtc.org Don't reset initial constraints in congestion controller.
2018-09-24 orphis@webrtc.org Add dummy implementation for SetCodecPReferences.
2018-09-24 terelius@webrtc.org Add helper class to process RtcEventLog events in order.
2018-09-24 yvesg@webrtc.org ResultsContainer: Initialize fields.
2018-09-24 yvesg@webrtc.org Auto roller: [unittest cleanup] Proper patching mechanism.
2018-09-24 kwiberg@webrtc.org TestStereo: Don't rely on the ACM to create encoders
2018-09-24 gustaf@webrtc.org AEC3: Delay estimator adapts even when estimated echo saturates
2018-09-24 kron@webrtc.org Refactor to remove direct memory dependency on kMaxId
2018-09-24 aleloi@webrtc.org Bug in histogram metric reporting.
2018-09-24 buildbot@webrtc.org Roll chromium_revision a7544fa319..c92470b71e (592771:593506)
2018-09-24 sprang@webrtc.org Revert "Reland "Enable simulcast screenshare by default""
2018-09-24 phensman@webrtc.org Include stringutils to allow build on chromium
2018-09-24 devicentepena@webrtc.org AEC3: Bounding the nearend spectrum used as input for the suppressor gain computation
2018-09-24 artit@webrtc.org Disabled TestPacketBuffer.SeqNumWrapOneFrame test due to clang update
2018-09-24 nisse@webrtc.org Delete unused Url class.
2018-09-24 nisse@webrtc.org Delete unused HttpData methods.
2018-09-24 kwiberg@webrtc.org AudioCodingModuleTest.TestStereo: Delete write-only variables
2018-09-24 mflodman@webrtc.org Don't throttle key-frame requests per layer.
2018-09-24 jonasolsson@webrtc.org Make fewer copies when using StringBuilder.
2018-09-24 asapersson@webrtc.org Android: Add maxFramerate to RtpParameters.
2018-09-24 artit@webrtc.org Revert "Added support of getting coverage on mac"
2018-09-24 phensman@webrtc.org Add WriteVideoToFile to video_file_reader.
2018-09-24 henrika@webrtc.org Ensures that ADM unittest uses default audio devices for all platforms.


Created with:
  gclient setdep -r src/third_party/webrtc@a36631cdb571

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:755660,chromium:855108,chromium:None,chromium:690537,chromium:887464,chromium:844647
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I906ee8f2b3f7798a61aef95bce71fbcbe0d81221
Reviewed-on: https://chromium-review.googlesource.com/1241517
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593747}
[modify] https://crrev.com/76346c9b0afb2febbf2bf3c8d2785ce342e8ad0e/DEPS

Comment 138 by oprypin@chromium.org, Nov 23

Blocking: 908001

Comment 139 by bugdroid1@chromium.org, Dec 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9d545df5c03ff1965ef651d31ffec1e48d818ca0

commit 9d545df5c03ff1965ef651d31ffec1e48d818ca0
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu Dec 06 22:26:52 2018

WebRTC: Improve Swarming perf test handling

* Re-enable retries, I intend to fix the mentioned problem src-side.
* Don't try to upload performance results if the task failed, that causes an infra failure.

Bug: 755660
Change-Id: Ib68868837ca1e60dd907deef662978460942746d
Reviewed-on: https://chromium-review.googlesource.com/c/1364190
Auto-Submit: Oleh Prypin <oprypin@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/9d545df5c03ff1965ef651d31ffec1e48d818ca0/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus6_.json
[modify] https://crrev.com/9d545df5c03ff1965ef651d31ffec1e48d818ca0/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__n_nexus6_.json
[modify] https://crrev.com/9d545df5c03ff1965ef651d31ffec1e48d818ca0/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus5_.json
[modify] https://crrev.com/9d545df5c03ff1965ef651d31ffec1e48d818ca0/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus4_.json
[modify] https://crrev.com/9d545df5c03ff1965ef651d31ffec1e48d818ca0/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__k_nexus5_.json
[modify] https://crrev.com/9d545df5c03ff1965ef651d31ffec1e48d818ca0/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__n_pixel_.json
[modify] https://crrev.com/9d545df5c03ff1965ef651d31ffec1e48d818ca0/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus7_2_.json
[modify] https://crrev.com/9d545df5c03ff1965ef651d31ffec1e48d818ca0/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/9d545df5c03ff1965ef651d31ffec1e48d818ca0/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__l_nexus9_.json

Comment 140 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/31255d6b52b946d308860a572f485f66873a967a

commit 31255d6b52b946d308860a572f485f66873a967a
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Mon Dec 10 11:27:57 2018

WebRTC: Increase timeout for Android perf, like for desktop

Bug: 755660
Change-Id: I65a4536938ff6e26ab2e3886e2145cfe9f6600e2
Reviewed-on: https://chromium-review.googlesource.com/c/1370046
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/31255d6b52b946d308860a572f485f66873a967a/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus6_.json
[modify] https://crrev.com/31255d6b52b946d308860a572f485f66873a967a/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__n_nexus6_.json
[modify] https://crrev.com/31255d6b52b946d308860a572f485f66873a967a/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus5_.json
[modify] https://crrev.com/31255d6b52b946d308860a572f485f66873a967a/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus4_.json
[modify] https://crrev.com/31255d6b52b946d308860a572f485f66873a967a/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__k_nexus5_.json
[modify] https://crrev.com/31255d6b52b946d308860a572f485f66873a967a/scripts/slave/recipe_modules/webrtc/builders.py
[modify] https://crrev.com/31255d6b52b946d308860a572f485f66873a967a/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__n_pixel_.json
[modify] https://crrev.com/31255d6b52b946d308860a572f485f66873a967a/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus7_2_.json
[modify] https://crrev.com/31255d6b52b946d308860a572f485f66873a967a/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__l_nexus9_.json

Comment 141 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/df4cfe20469c333bf65c4a76ecf5d8942feb3379

commit df4cfe20469c333bf65c4a76ecf5d8942feb3379
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Mon Dec 10 12:18:11 2018

WebRTC: Disable a test on Android K

This is copying the exclusion that's currently applied on Buildbot builders.

Bug: 755660
Change-Id: Ic46a2cf26607e299e9c2b75755a62e0939d21fe2
Reviewed-on: https://chromium-review.googlesource.com/c/1370045
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>

[modify] https://crrev.com/df4cfe20469c333bf65c4a76ecf5d8942feb3379/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/df4cfe20469c333bf65c4a76ecf5d8942feb3379/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__k_nexus5_.json

Comment 142 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d43bac39964ca4a6335786b2fcd5bb91197c4f6b

commit d43bac39964ca4a6335786b2fcd5bb91197c4f6b
Author: Oleh Prypin <oprypin@chromium.org>
Date: Tue Dec 11 15:13:48 2018

Pull isolated perf output files for all retries instead of clobbering

The Android test runner, when retries were enabled, previously would overwrite the isolated-script-test-perf-output JSON file with the latest try, which means that all previous results would be lost. Now it will still write to the provided 'file-name.json' first, but then for following tries it will write to 'file-name_1.json', 'file-name_2.json', etc., which can allow to salvage the results in post-processing.

Unrelated change in behavior due to refactoring: --app-data-file previously used this naming scheme for outputs: ['file-name_0.ext', 'file-name_1.ext', ...]; now it's ['file-name.ext', 'file-name_1.ext', ...].

Bug: 755660
Change-Id: Id8ecb506ef91504b925178b433544faa3db8c476
Reviewed-on: https://chromium-review.googlesource.com/c/1371426
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615525}
[modify] https://crrev.com/d43bac39964ca4a6335786b2fcd5bb91197c4f6b/build/android/pylib/local/device/local_device_gtest_run.py

Comment 143 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/e05d720f1c8848aef216777d3d02afba0cb2d1e2

commit e05d720f1c8848aef216777d3d02afba0cb2d1e2
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Fri Dec 14 14:46:48 2018

Switch to logdog binary provided by IMPLIED_CIPD_BINARIES

https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/swarming/api.py?q=IMPLIED_CIPD_BINARIES
to stop having to specify it in
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/webrtc/steps.py?q=ANDROID_CIPD_PACKAGES

Bug: chromium:755660
Change-Id: I1c69b0bada145ce830c4f62d6e99cc928cd29024
Reviewed-on: https://webrtc-review.googlesource.com/c/114426
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26015}
[modify] https://crrev.com/e05d720f1c8848aef216777d3d02afba0cb2d1e2/tools_webrtc/mb/mb.py
[modify] https://crrev.com/e05d720f1c8848aef216777d3d02afba0cb2d1e2/tools_webrtc/mb/mb_unittest.py

Comment 144 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/5bb1afd5c3fd0d45377b61db3a4cfdee92594eb7

commit 5bb1afd5c3fd0d45377b61db3a4cfdee92594eb7
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Fri Dec 14 16:13:26 2018

Revert "Switch to logdog binary provided by IMPLIED_CIPD_BINARIES"

This reverts commit e05d720f1c8848aef216777d3d02afba0cb2d1e2.

Reason for revert: Cannot find logdog at that path

Original change's description:
> Switch to logdog binary provided by IMPLIED_CIPD_BINARIES
> 
> https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/swarming/api.py?q=IMPLIED_CIPD_BINARIES
> to stop having to specify it in
> https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/webrtc/steps.py?q=ANDROID_CIPD_PACKAGES
> 
> Bug: chromium:755660
> Change-Id: I1c69b0bada145ce830c4f62d6e99cc928cd29024
> Reviewed-on: https://webrtc-review.googlesource.com/c/114426
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#26015}

TBR=mbonadei@webrtc.org,oprypin@webrtc.org

Change-Id: I6ab6a9c4b53e1d2eb90d0294706ca71700f79177
No-Try: true
Bug: chromium:755660
Reviewed-on: https://webrtc-review.googlesource.com/c/114428
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26018}
[modify] https://crrev.com/5bb1afd5c3fd0d45377b61db3a4cfdee92594eb7/tools_webrtc/mb/mb.py
[modify] https://crrev.com/5bb1afd5c3fd0d45377b61db3a4cfdee92594eb7/tools_webrtc/mb/mb_unittest.py

Comment 145 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54a631f03d888aadfd1a5d3af371f4748412a99f

commit 54a631f03d888aadfd1a5d3af371f4748412a99f
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Dec 14 20:32:43 2018

Roll src/third_party/webrtc d96b275cd686..24779d82292e (15 commits)

https://webrtc.googlesource.com/src.git/+log/d96b275cd686..24779d82292e


git log d96b275cd686..24779d82292e --date=short --no-merges --format='%ad %ae %s'
2018-12-14 terelius@webrtc.org Missing packet send time should not cause BWE backoff.
2018-12-14 oprypin@webrtc.org Switch to logdog binary provided by IMPLIED_CIPD_BINARIES
2018-12-14 henrikg@webrtc.org Revert "Reland "Default to dlopening the PipeWire.""
2018-12-14 tikuta@google.com Use output_dir instead of output_name
2018-12-14 kron@webrtc.org Refactor creation of ColorSpace test data
2018-12-14 nisse@webrtc.org Delete log severity LS_SENSITIVE
2018-12-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 55b877610b..6d37479eb8 (615952:616603)
2018-12-14 tikuta@google.com update luci-go client
2018-12-14 steveanton@webrtc.org Use unique_ptr in DataChannel PacketQueue
2018-12-13 steveanton@webrtc.org Remove unused cryptoparams.h header
2018-12-13 zstein@webrtc.org Set LoggedIceCandidatePairEvent.transaction_id to default value if missing.
2018-12-13 benwright@webrtc.org Adding fuzzing configuration files for Rtp Replay Fuzzing.
2018-12-13 tomas.popela@gmail.com Reland "Default to dlopening the PipeWire."
2018-12-13 jeroendb@webrtc.org Adding metrics for hostname candidate use.
2018-12-13 kron@webrtc.org Reorder methods and members of HdrMetadata


Created with:
  gclient setdep -r src/third_party/webrtc@24779d82292e

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:755660,chromium:682122,chromium:914264,chromium:None,chromium:894045,chromium:914164,chromium:None,chromium:None,chromium:682122
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I5286b9abd8b5c2110cdcc85633079001b3689e71
Reviewed-on: https://chromium-review.googlesource.com/c/1378445
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616810}
[modify] https://crrev.com/54a631f03d888aadfd1a5d3af371f4748412a99f/DEPS

Comment 146 by bugdroid1@chromium.org, Dec 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/875487e89a33953fc4083422916861621767e0ef

commit 875487e89a33953fc4083422916861621767e0ef
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sat Dec 15 06:30:26 2018

Roll src/third_party/webrtc 94f107454e3e..adae52b58844 (4 commits)

https://webrtc.googlesource.com/src.git/+log/94f107454e3e..adae52b58844


git log 94f107454e3e..adae52b58844 --date=short --no-merges --format='%ad %ae %s'
2018-12-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 84fedb7e68..31225b9c5f (616714:616901)
2018-12-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6d37479eb8..84fedb7e68 (616603:616714)
2018-12-14 ivoc@webrtc.org Added new feature to print a text log to neteq_rtpplay
2018-12-14 oprypin@webrtc.org Revert "Switch to logdog binary provided by IMPLIED_CIPD_BINARIES"


Created with:
  gclient setdep -r src/third_party/webrtc@adae52b58844

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:b/116685514,chromium:755660
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I04cb1cceee652c9ba5249358d331fe4b0f1bdf3e
Reviewed-on: https://chromium-review.googlesource.com/c/1379328
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616961}
[modify] https://crrev.com/875487e89a33953fc4083422916861621767e0ef/DEPS

Comment 147 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/36599c1e803dd42819bda266380fec8bea47b809

commit 36599c1e803dd42819bda266380fec8bea47b809
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu Jan 10 07:55:46 2019

WebRTC: Minor improvements related to performance upload

* Mark performance upload as an infra step.
* Stop adding Results Dashboard, it only points to one arbitrary graph.
* Stop specifying benchmark_name, it is only a fallback, per https://cs.chromium.org/chromium/src/third_party/catapult/dashboard/dashboard/add_point.py?l=260&rcl=f173ec2b100335b02f292f31f6249abb5da31f38

TBR: jbudorick
Bug: chromium:755660
Change-Id: I0187fd4ebe216a88f16f816144e90ea7f8f28fe9
Reviewed-on: https://chromium-review.googlesource.com/c/1377537
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus6_.json
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_mac_10_11.json
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_linux_trusty.json
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__n_nexus6_.json
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus5_.json
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus4_.json
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__k_nexus5_.json
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__n_pixel_.json
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipe_modules/webrtc/test_api.py
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_win7.json
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus7_2_.json
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__l_nexus9_.json
[modify] https://crrev.com/36599c1e803dd42819bda266380fec8bea47b809/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_win7.json

Comment 148 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a53512f33454a992d9d165ed3005e3cead919b15

commit a53512f33454a992d9d165ed3005e3cead919b15
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu Jan 10 14:50:00 2019

WebRTC: Refactor performance upload code (mainly Android)

* Fix badly overridden methods that had chunks of code copied from chromium_tests.
* Fail dashboard upload only if the test itself succeeds. Otherwise rely on composite step failure.
* Remove 'idempotent' config, specify it by default.
* Remove 'add_adb_path' config, specify the command line arg directly.

Note:
* "validate_task_results" doesn't sound like the right place to *process* the results, but it's the most suitable place to hook into chromium_tests, certainly better than the previous overridden private method.

Bug: chromium:755660
Change-Id: I2beaeb135b8624b6c752a6af8fb6c8a2d679aa6e
Reviewed-on: https://chromium-review.googlesource.com/c/1377536
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[add] https://crrev.com/a53512f33454a992d9d165ed3005e3cead919b15/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus5__failing_test.json
[modify] https://crrev.com/a53512f33454a992d9d165ed3005e3cead919b15/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus6_.json
[modify] https://crrev.com/a53512f33454a992d9d165ed3005e3cead919b15/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__n_nexus6_.json
[modify] https://crrev.com/a53512f33454a992d9d165ed3005e3cead919b15/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus5_.json
[modify] https://crrev.com/a53512f33454a992d9d165ed3005e3cead919b15/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus4_.json
[modify] https://crrev.com/a53512f33454a992d9d165ed3005e3cead919b15/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__k_nexus5_.json
[delete] https://crrev.com/68f199581bd4f37f1500718a943344f9edf671c2/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/a53512f33454a992d9d165ed3005e3cead919b15/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__n_pixel_.json
[modify] https://crrev.com/a53512f33454a992d9d165ed3005e3cead919b15/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/a53512f33454a992d9d165ed3005e3cead919b15/scripts/slave/recipes/webrtc/standalone.py
[modify] https://crrev.com/a53512f33454a992d9d165ed3005e3cead919b15/scripts/slave/recipe_modules/webrtc/test_api.py
[modify] https://crrev.com/a53512f33454a992d9d165ed3005e3cead919b15/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android32__l_nexus7_2_.json
[modify] https://crrev.com/a53512f33454a992d9d165ed3005e3cead919b15/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_android64__l_nexus9_.json
[add] https://crrev.com/a53512f33454a992d9d165ed3005e3cead919b15/scripts/slave/recipes/webrtc/standalone.expected/luci_webrtc_perf_perf_linux_trusty_failing_test.json

Comment 149 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/80ca1afb9c96ada8c31728282918d8d36c213b03

commit 80ca1afb9c96ada8c31728282918d8d36c213b03
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu Jan 24 17:07:29 2019

WebRTC: Fix perf dashboard upload code

* Generalize the file name pattern.
* Support uploading results from multiple attempts.
  (followup to https://chromium-review.googlesource.com/1371426)
* Fix code that invokes InfraFailure.

TBR: jbudorick
Bug: 755660
Change-Id: I3d5ea8d63e75fce75a80013dc726520d165e9eb8
Reviewed-on: https://chromium-review.googlesource.com/c/1434415
Reviewed-by: Oleh Prypin <oprypin@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/80ca1afb9c96ada8c31728282918d8d36c213b03/scripts/slave/recipe_modules/webrtc/steps.py

Comment 150 by oprypin@chromium.org, Jan 25

Status: Fixed (was: Started)

Comment 151 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b117193b64665ecc7bda54282ecc5eb5025ea83f

commit b117193b64665ecc7bda54282ecc5eb5025ea83f
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Fri Jan 25 10:47:09 2019

WebRTC: Correctly detect test failures before perf upload

`retcode` reports the status of the Swarming client, which is successful even if the isolated test failed.

TBR: jbudorick
Bug: 755660
Change-Id: Ibb6eba0221b950f55593afd108e91e519d14f9e8
Reviewed-on: https://chromium-review.googlesource.com/c/1436255
Reviewed-by: Oleh Prypin <oprypin@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/b117193b64665ecc7bda54282ecc5eb5025ea83f/scripts/slave/recipe_modules/webrtc/steps.py
Showing comments 52 - 151 of 151 Older

Sign in to add a comment