Issue metadata
Sign in to add a comment
|
Cannot click and drag scrollbar on element with translateZ(0) |
||||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Open attached html page or go to https://jsfiddle.net/mowq15q7/ (2) Try to click and drag the scrollbar What is the expected result? Should scroll What happens instead? Does not scroll, change color on hover, and scroll arrows do not work. Bisect: https://chromium.googlesource.com/chromium/src/+log/1a8af52d8dc2f6daa13b4e23501abb6d71018b5e..339480b39644cb3c98c57a69d183f04acdd5d2c5 Suspect: https://chromium.googlesource.com/chromium/src/+/2a88dac7dd3caf5155d4e82f08c86d12484dbf18
,
Aug 15 2017
,
Aug 15 2017
It issue is caused by we apply coordinate change for translate in https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/paint/PaintLayer.cpp?rcl=269992390713d49a4780f7ac3aff1b4585c90243&l=2338 Then apply twice before hit test scroll. https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/paint/PaintLayer.cpp?rcl=411fb85ffd1c2478c78e9f6e6105d4c88f38ad96&l=2087 Instead, I can just use the hit_test_location in HitTestResult.
,
Aug 15 2017
Sounds good, please make sure you add a test for this case when you reland.
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5019fe1f30c52750571f3c1cced543ca01c16495 commit 5019fe1f30c52750571f3c1cced543ca01c16495 Author: chaopeng <chaopeng@chromium.org> Date: Wed Aug 16 14:10:04 2017 Fix Hit Test for Scrollbar of translateZ element This issue is caused by we apply coordinate change for translate in PaintLayer::HitTestLayerByApplyingTransform, then we apply twice in PaintLayer::HitTestLayer before HitTestOverflows. In this patch, I can use the hit_test_location in HitTestResult to HitTestOverflows. Bug: 755645 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iad7c0a9037f94e37d6769008050c049e5b764c98 Reviewed-on: https://chromium-review.googlesource.com/616446 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#494768} [modify] https://crrev.com/5019fe1f30c52750571f3c1cced543ca01c16495/third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp [modify] https://crrev.com/5019fe1f30c52750571f3c1cced543ca01c16495/third_party/WebKit/Source/core/paint/PaintLayer.cpp
,
Aug 16 2017
Issue 755844 has been merged into this issue.
,
Aug 17 2017
,
Aug 17 2017
The fix is landed in 62.0.3189.0. And I just confirm it works correct at that version.
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ab0f4625ee12a425b4b14a5e07435b11931a1e6 commit 4ab0f4625ee12a425b4b14a5e07435b11931a1e6 Author: Jianpeng Chao <chaopeng@chromium.org> Date: Wed Aug 23 19:37:17 2017 Revert "Fix Hit Test for Scrollbar of translateZ element" This reverts commit 5019fe1f30c52750571f3c1cced543ca01c16495. Reason for revert: Regression 756740 Original change's description: > Fix Hit Test for Scrollbar of translateZ element > > This issue is caused by we apply coordinate change for translate in > PaintLayer::HitTestLayerByApplyingTransform, then we apply twice in > PaintLayer::HitTestLayer before HitTestOverflows. > > In this patch, I can use the hit_test_location in HitTestResult to > HitTestOverflows. > > Bug: 755645 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Iad7c0a9037f94e37d6769008050c049e5b764c98 > Reviewed-on: https://chromium-review.googlesource.com/616446 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#494768} TBR=pdr@chromium.org,chaopeng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 755645 Change-Id: I336e8805deecb0793f37f3ceb2eaf78b2c1c62e5 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/629296 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#496767} [modify] https://crrev.com/4ab0f4625ee12a425b4b14a5e07435b11931a1e6/third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp [modify] https://crrev.com/4ab0f4625ee12a425b4b14a5e07435b11931a1e6/third_party/WebKit/Source/core/paint/PaintLayer.cpp |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by l...@chromium.org
, Aug 15 2017Owner: chaopeng@chromium.org