media.mse_cases failing on chromium.perf/Android Nexus6 WebView Perf |
||
Issue descriptionmedia.mse_cases failing on chromium.perf/Android Nexus6 WebView Perf Builders failed on: - Android Nexus6 WebView Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20WebView%20Perf
,
Aug 15 2017
Seeing a lot of this:
Locals:
_ : None
args : ['/b/swarming/w/ir/third_party/catapult/third_party/vinn/third_party/v8/linux/x86_64/d8', '/b/swarming/w/itbPjStW/tmptFiZzf/_tmp_boostrap.js', '--js_arguments', '/b/swarming/w/ir/third_party/catapult/third_party/vinn/third_party/v8/linux/x86_64/d8', '/b/swarming/w/itbPjStW/tmpwFj8Uo']
full_js_args : ['/b/swarming/w/ir/third_party/catapult/third_party/vinn/third_party/v8/linux/x86_64/d8', '/b/swarming/w/itbPjStW/tmpwFj8Uo']
js_args : ['/b/swarming/w/itbPjStW/tmpwFj8Uo']
js_file_path : '/b/swarming/w/itbPjStW/tmptFiZzf/_tmp_boostrap.js'
out : 'undefined:1: SyntaxError: Unexpected token N in JSON at position 3195\n{"label": null, "benchmarkStartMs": 1502762376181.867, "trace_rerun_options": [], "benchmark_metadata": {"rerun_options": [], "type": "telemetry_benchmark", "name": "media.mse_cases", "description": "Obtains media metrics for key media source extensions functions."}, "format_version": "0.1", "benchmark_description": "Obtains media metrics for key media source extensions functions.", "enabled": true, "charts": {"test_total": {"startup ... ^\nSyntaxError: Unexpected token N in JSON at position 3195\n at JSON.parse (<anonymous>)\n at eval (/b/swarming/w/ir/third_party/catapult/tracing/tracing/value/convert_chart_json_cmdline.html:17:23)\n at Object.loadHTMLFile (/b/swarming/w/ir/third_party/catapult/third_party/vinn/vinn/html_imports_loader.js:140:5)\n at /b/swarming/w/ir/third_party/catapult/third_party/vinn/vinn/d8_bootstrap.js:151:19\n\n' (truncated)
,
Aug 15 2017
It's complaining about the "values" attribute of list_of_scalar_values object having value [NaN]. '''' "type": "list_of_scalar_values", "important": true, "values": [NaN], "units": "ms", "page_id": 10}, '''' apparently that isn't appropriate JSON. Now the question is why NaN is being outputted in the first place.
,
Aug 15 2017
Here's the whole thing:
"startup_test.html?testType=A&doNotWaitForBodyOnLoad=true": {"std": 0.0, "name": "body_onload_delay.A_buffer_pre_load", "type": "list_of_scalar_values", "important": true, "values": [NaN], "units": "ms", "page_id": 10}
So the buggy test is "startup_test.html?testType=A&doNotWaitForBodyOnLoad=true"
,
Aug 15 2017
Awesome! I can go and disable that for now.
,
Aug 15 2017
Yeah, but the real fix here is to fix the code to not output NaN but instead fail the test if it gets NaN.
,
Aug 15 2017
Also, please only disable for Webview.
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42ce2a929c24d4e6e27ac3409e95458a968d746f commit 42ce2a929c24d4e6e27ac3409e95458a968d746f Author: Simon <simonhatch@chromium.org> Date: Tue Aug 15 21:21:23 2017 Disable media.mse_cases on Webview. TBR=rnephew@chromium.org Bug: 755639 Change-Id: I93dfcfbc6379a057159803e602a106e412098f89 Reviewed-on: https://chromium-review.googlesource.com/615781 Reviewed-by: Simon Hatch <simonhatch@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#494551} [modify] https://crrev.com/42ce2a929c24d4e6e27ac3409e95458a968d746f/tools/perf/benchmarks/media.py
,
Oct 6 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by crouleau@chromium.org
, Aug 15 2017