New issue
Advanced search Search tips

Issue 755631 link

Starred by 1 user
Status: Assigned
Owner:
lpalmaro@chromium.org
Cc:
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Accessibility system tray menu shows when no features enabled if a feature was enabled at login screen

Project Member Reported by jamescook@chromium.org, Aug 15 2017 
chrome r494397

* Run chrome --login-manager
* Sign in to an account. Make sure no accessibility features are enabled. Make sure "show accessibility menu in tray" is turned off in prefs.
* Sign out.
* Run chrome --login-manager again
* From system tray menu, turn on large cursor
* Sign in to a session

Cursor goes back to small, which is expected, because the user doesn't have the pref set.

Accessibility menu is still visible, even though no features are enabled and the pref to show it is turned off.

Is this a bug or expected behavior?

Comment 1 by dmazz...@chromium.org, Aug 16 2017

Owner: lpalmaro@chromium.org
Status: Assigned (was: Untriaged)
Seems like possibly intended behavior.

If someone enabled an accessibility feature on the login screen there's a good chance they'll want it once they sign in.

Might be an annoyance for a shared machine, but seems like an okay tradeoff.

@lpalmaro to verify
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc97f0a9755699124c5f8d0886ac275c6276827c

commit fc97f0a9755699124c5f8d0886ac275c6276827c
Author: James Cook <jamescook@chromium.org>
Date: Wed Aug 16 20:05:35 2017

cros: Move accessibility prefs code out of SystemTrayDelegate

For go/mustash code in ash and code in chrome run in different processes,
so ash cannot use SystemTrayDelegate to call back into chrome.

Move the code that monitors prefs into AccessibilityManager, where other
prefs are monitored. AccessibilityManager is already doing the profile
switch monitoring for login and multiprofile, so this reduces code
duplication and consolidates all the prefs code in one place.

Bug:  647412 , 755631
Test: existing browser_tests
Change-Id: Id71a601f5ffe741a6a4bc19c8d901cb47f749a4e
Reviewed-on: https://chromium-review.googlesource.com/615680
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494914}
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/ash/system/accessibility_observer.h
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/ash/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/ash/system/tray/system_tray_delegate.h
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/fc97f0a9755699124c5f8d0886ac275c6276827c/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
►

Sign in to add a comment