New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755630 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update uma proto field names to match server-side code

Project Member Reported by holte@chromium.org, Aug 15 2017

Issue description

Some of the field and type names are out of sync with the server code.

Update their uses in chromium.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1cd47738b1750c11957e7bc3e46ed635544af4f

commit e1cd47738b1750c11957e7bc3e46ed635544af4f
Author: Steven Holte <holte@google.com>
Date: Tue Aug 15 20:14:25 2017

Update PerfStatLine proto to match server.

Bug:  755630 

Change-Id: Id5c0ccf79e5d2ecabb56f0de7db7679f695a1273
Reviewed-on: https://chromium-review.googlesource.com/614655
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494520}
[modify] https://crrev.com/e1cd47738b1750c11957e7bc3e46ed635544af4f/chrome/browser/metrics/perf/perf_provider_chromeos_unittest.cc
[modify] https://crrev.com/e1cd47738b1750c11957e7bc3e46ed635544af4f/components/metrics/proto/perf_stat.proto

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a4a1e353edf9a2483b7b692bec43f2d5bc598f5

commit 6a4a1e353edf9a2483b7b692bec43f2d5bc598f5
Author: Steven Holte <holte@google.com>
Date: Tue Aug 15 20:29:15 2017

Fix server/client time field name mismatch.

These fields are named time_sec in the server proto, update these version to match.

Bug:  755630 

Change-Id: I1cb74f284bfc794a3eb553a4f1ecaca371dfaa91
Reviewed-on: https://chromium-review.googlesource.com/614763
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494522}
[modify] https://crrev.com/6a4a1e353edf9a2483b7b692bec43f2d5bc598f5/components/metrics/metrics_log.cc
[modify] https://crrev.com/6a4a1e353edf9a2483b7b692bec43f2d5bc598f5/components/metrics/proto/omnibox_event.proto
[modify] https://crrev.com/6a4a1e353edf9a2483b7b692bec43f2d5bc598f5/components/metrics/proto/user_action_event.proto
[modify] https://crrev.com/6a4a1e353edf9a2483b7b692bec43f2d5bc598f5/components/omnibox/browser/omnibox_metrics_provider.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3696c941c167037fd0f81c9391cf31d7cf854b6d

commit 3696c941c167037fd0f81c9391cf31d7cf854b6d
Author: Steven Holte <holte@google.com>
Date: Thu Aug 24 18:38:03 2017

Rename OmniboxInputType proto enum to match server.

Bug:  755630 

TBR=pkasting,rohitrao

Change-Id: Ic300e8db69ca048d8137f0ae54bc470c40ad4c20
Reviewed-on: https://chromium-review.googlesource.com/614768
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497136}
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/metrics/proto/omnibox_event.proto
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/metrics/proto/omnibox_input_type.proto
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/autocomplete_input.cc
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/autocomplete_input.h
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/autocomplete_input_unittest.cc
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/autocomplete_provider_unittest.cc
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/autocomplete_result.cc
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/autocomplete_scheme_classifier.h
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/history_url_provider_unittest.cc
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/keyword_provider.cc
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/keyword_provider.h
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/keyword_provider_unittest.cc
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/omnibox_edit_unittest.cc
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/omnibox_log.cc
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/omnibox_log.h
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/search_provider.cc
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/search_provider.h
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/test_scheme_classifier.cc
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/omnibox/browser/test_scheme_classifier.h
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/search_engines/template_url.h
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/components/search_engines/template_url_unittest.cc
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/ios/chrome/browser/autocomplete/autocomplete_scheme_classifier_impl.h
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/ios/chrome/browser/autocomplete/autocomplete_scheme_classifier_impl.mm
[modify] https://crrev.com/3696c941c167037fd0f81c9391cf31d7cf854b6d/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7d6931f108d91c19995253ef3680aafd08cbdc4

commit d7d6931f108d91c19995253ef3680aafd08cbdc4
Author: Steven Holte <holte@google.com>
Date: Fri Aug 25 22:53:15 2017

Update build_fingerprint field name.

Bug:  755630 
Change-Id: I5554dc2645be5d76a1cf1fda79a71f430decdb4f
Reviewed-on: https://chromium-review.googlesource.com/636452
Commit-Queue: Steven Holte <holte@chromium.org>
Commit-Queue: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497576}
[modify] https://crrev.com/d7d6931f108d91c19995253ef3680aafd08cbdc4/components/metrics/metrics_log.cc
[modify] https://crrev.com/d7d6931f108d91c19995253ef3680aafd08cbdc4/components/metrics/metrics_log_unittest.cc
[modify] https://crrev.com/d7d6931f108d91c19995253ef3680aafd08cbdc4/components/metrics/proto/system_profile.proto

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7d6931f108d91c19995253ef3680aafd08cbdc4

commit d7d6931f108d91c19995253ef3680aafd08cbdc4
Author: Steven Holte <holte@google.com>
Date: Fri Aug 25 22:53:15 2017

Update build_fingerprint field name.

Bug:  755630 
Change-Id: I5554dc2645be5d76a1cf1fda79a71f430decdb4f
Reviewed-on: https://chromium-review.googlesource.com/636452
Commit-Queue: Steven Holte <holte@chromium.org>
Commit-Queue: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497576}
[modify] https://crrev.com/d7d6931f108d91c19995253ef3680aafd08cbdc4/components/metrics/metrics_log.cc
[modify] https://crrev.com/d7d6931f108d91c19995253ef3680aafd08cbdc4/components/metrics/metrics_log_unittest.cc
[modify] https://crrev.com/d7d6931f108d91c19995253ef3680aafd08cbdc4/components/metrics/proto/system_profile.proto

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a2dbeb753b09253fdf082905c6c05b861060ca5

commit 9a2dbeb753b09253fdf082905c6c05b861060ca5
Author: Steven Holte <holte@google.com>
Date: Wed Sep 06 23:48:43 2017

Remove ExternalAccessPoint.vendor_prefix field.

This was never added server side.

Bug:  755630 
Change-Id: I0b0c0e402b6b1c3dc1f68fd5d44c7462314031fb
Reviewed-on: https://chromium-review.googlesource.com/653360
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500132}
[modify] https://crrev.com/9a2dbeb753b09253fdf082905c6c05b861060ca5/components/metrics/proto/system_profile.proto

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe90980b87640867384ac7677bcd407efec81ad5

commit fe90980b87640867384ac7677bcd407efec81ad5
Author: Steven Holte <holte@google.com>
Date: Mon Oct 02 20:51:28 2017

Update UMA protos from server side versions.

Bug:  755630 
Change-Id: I7b6c1c890a68870311411b5f6c7e084052d80f7c
Reviewed-on: https://chromium-review.googlesource.com/609588
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505777}
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/call_stack_profile.proto
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/chrome_user_metrics_extension.proto
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/execution_context.proto
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/histogram_event.proto
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/omnibox_event.proto
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/omnibox_input_type.proto
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/printer_event.proto
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/sampled_profile.proto
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/system_profile.proto
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/translate_event.proto
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/ukm/entry.proto
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/ukm/report.proto
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/ukm/source.proto
[modify] https://crrev.com/fe90980b87640867384ac7677bcd407efec81ad5/components/metrics/proto/user_action_event.proto

Comment 8 by holte@chromium.org, Dec 8 2017

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69419f61a03b0230ed492f37588ab250a2933a92

commit 69419f61a03b0230ed492f37588ab250a2933a92
Author: Lakshman Annadorai <lakshmana@chromium.org>
Date: Fri Aug 31 21:07:12 2018

Update UMA protos from server side versions.

Bug:  755630 
Change-Id: Ia5940e7be3821200a38a2405c2676ef37326bcf7
Reviewed-on: https://chromium-review.googlesource.com/1199485
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Lakshman Annadorai <lakshmana@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588165}
[modify] https://crrev.com/69419f61a03b0230ed492f37588ab250a2933a92/third_party/metrics_proto/README.chromium
[modify] https://crrev.com/69419f61a03b0230ed492f37588ab250a2933a92/third_party/metrics_proto/perf_data.proto

Sign in to add a comment