Remora enrollment timing out on Oobe.remoraRequisitionForTesting() starting with M62 9842.0.0 |
||||||
Issue description
The enrollment test works on 9841.0.0 but is broken starting with M62 9842.0.0 build. It is able to get past the initial welcome screen and switch to the remora welcome screen (i.e. ctrl + alt + h) but is not able to proceed from that screen on wards.
Was there some recent change that broke this?
08/15 01:44:09.836 DEBUG|inspector_websocke:0097| sent [{
"id": 5,
"method": "Runtime.evaluate",
"params": {
"expression": "Oobe.remoraRequisitionForTesting();; 0;",
"returnByValue": true
}
}]
08/15 01:44:09.926 DEBUG|inspector_websocke:0164| got [{
"method": "Page.domContentEventFired",
"params": {
"timestamp": 34.000390000000003
}
}]
08/15 01:44:09.936 DEBUG|inspector_websocke:0164| got [{
"id": 5,
"result": {
"result": {
"description": "0",
"type": "number",
"value": 0
}
}
}]
08/15 01:44:09.950 DEBUG| cros_interface:0363| ListProcesses(<predicate>)->[171 processes]
08/15 01:44:10.072 DEBUG| cros_interface:0363| ListProcesses(<predicate>)->[166 processes]
08/15 01:44:39.974 ERROR| utils:2737| Timed out waiting for unnamed condition
08/15 01:44:39.985 DEBUG| cros_interface:0363| ListProcesses(<predicate>)->[174 processes]
08/15 01:44:39.994 DEBUG| cros_interface:0363| ListProcesses(<predicate>)->[174 processes]
08/15 01:44:39.994 INFO | browser:0268| Closing browser (pid=3082) ...
08/15 01:44:39.995 INFO | cros_interface:0546| (Re)starting the ui (logs the user out)
08/15 01:44:40.002 DEBUG| cros_interface:0439| IsServiceRunning(ui)->True
08/15 01:44:40.003 DEBUG| cros_interface:0058| sh -c restart ui
08/15 01:44:44.340 DEBUG| cros_interface:0067| > stdout=[ui start/running, process 3573
], stderr=[]
08/15 01:44:44.341 DEBUG| cros_interface:0058| sh -c cryptohome-path user 'test@test.test'
08/15 01:44:44.348 DEBUG| cros_interface:0067| > stdout=[/home/user/753e202909d07816f46f875f57e4555b93ff53c8
], stderr=[]
08/15 01:44:44.349 DEBUG| cros_interface:0058| sh -c /bin/df --output=source,target /home/user/753e202909d07816f46f875f57e4555b93ff53c8
08/15 01:44:44.354 DEBUG| cros_interface:0067| > stdout=[], stderr=[df: /home/user/753e202909d07816f46f875f57e4555b93ff53c8: No such file or directory
]
08/15 01:44:44.355 INFO | browser:0283| Browser is closed.
08/15 01:44:44.355 DEBUG| test:0389| Test failed due to Timed out waiting for unnamed condition. Exception log follows the after_iteration_hooks.
08/15 01:44:44.355 DEBUG| test:0392| starting after_iteration_hooks
08/15 01:44:44.356 DEBUG| utils:0212| Running 'mkdir -p /usr/local/autotest/results/default/enterprise_RemoraRequisition/sysinfo/iteration.1/var/spool'
08/15 01:44:44.361 DEBUG| utils:0212| Running 'rsync --no-perms --chmod=ugo+r -a --safe-links --exclude=/crash/**autoserv* --exclude=/crash/*.core /var/spool/crash /usr/local/autotest/results/default/enterprise_RemoraRequisition/sysinfo/iteration.1/var/spool'
08/15 01:44:44.368 DEBUG| utils:0212| Running 'rm -rf /var/spool/crash/*'
08/15 01:44:44.373 DEBUG| utils:0212| Running 'logger "autotest finished iteration /usr/local/autotest/results/default/enterprise_RemoraRequisition/sysinfo/iteration.1"'
08/15 01:44:44.380 DEBUG| test:0395| after_iteration_hooks completed
08/15 01:44:44.381 WARNI| test:0612| The test failed with the following exception
Traceback (most recent call last):
File "/usr/local/autotest/common_lib/test.py", line 606, in _exec
_call_test_function(self.execute, *p_args, **p_dargs)
File "/usr/local/autotest/common_lib/test.py", line 806, in _call_test_function
return func(*args, **dargs)
File "/usr/local/autotest/common_lib/test.py", line 470, in execute
dargs)
File "/usr/local/autotest/common_lib/test.py", line 347, in _call_run_once_with_retry
postprocess_profiled_run, args, dargs)
File "/usr/local/autotest/common_lib/test.py", line 380, in _call_run_once
self.run_once(*args, **dargs)
File "/usr/local/autotest/tests/enterprise_RemoraRequisition/enterprise_RemoraRequisition.py", line 29, in run_once
enrollment.RemoraEnrollment(cr.browser, user_id, password)
File "/usr/local/autotest/common_lib/cros/enrollment.py", line 37, in RemoraEnrollment
SwitchToRemora(browser)
File "/usr/local/autotest/common_lib/cros/enrollment.py", line 27, in SwitchToRemora
utils.poll_for_condition(lambda: browser.oobe_exists, timeout=30)
File "/usr/local/autotest/common_lib/utils.py", line 2738, in poll_for_condition
raise TimeoutError(desc)
TimeoutError: Timed out waiting for unnamed condition
,
Aug 16 2017
Achuith - could you please take a look at this. Its breaking all CFM end to end tests.
,
Aug 22 2017
More logs from bad run...
08/22 01:46:05.842 DEBUG|inspector_websocke:0097| sent [{
"id": 4,
"method": "Runtime.evaluate",
"params": {
"expression": "typeof Oobe !== 'undefined'",
"returnByValue": true
}
}]
08/22 01:46:06.090 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameAttached",
"params": {
"frameId": "3031.2",
"parentFrameId": "3031.1"
}
}]
08/22 01:46:06.090 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameStartedLoading",
"params": {
"frameId": "3031.2"
}
}]
08/22 01:46:06.091 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameNavigated",
"params": {
"frame": {
"id": "3031.2",
"loaderId": "3031.1",
"mimeType": "text/html",
"name": "cros-eula-frame",
"parentId": "3031.1",
"securityOrigin": "://", <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< This should be chrome://oobe
"url": "about:blank"
}
}
}]
08/22 01:46:06.093 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameAttached",
"params": {
"frameId": "3031.3",
"parentFrameId": "3031.1",
"stack": {
"callFrames": [
{
"columnNumber": 16,
"functionName": "_createLocalRoot",
"lineNumber": 2075,
"scriptId": "50",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js"
},
{
"columnNumber": 5,
"functionName": "_setupRoot",
"lineNumber": 1775,
"scriptId": "50",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js"
},
{
"columnNumber": 5,
"functionName": "_ready",
"lineNumber": 129,
"scriptId": "50",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js"
},
{
"columnNumber": 5,
"functionName": "_tryReady",
"lineNumber": 120,
"scriptId": "50",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js"
},
{
"columnNumber": 5,
"functionName": "_initFeatures",
"lineNumber": 4088,
"scriptId": "53",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-extracted.js"
},
{
"columnNumber": 5,
"functionName": "__initialize",
"lineNumber": 225,
"scriptId": "49",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-micro-extracted.js"
},
{
"columnNumber": 5,
"functionName": "createdCallback",
"lineNumber": 208,
"scriptId": "49",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-micro-extracted.js"
}
]
}
}
}]
08/22 01:46:06.093 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameStartedLoading",
"params": {
"frameId": "3031.3"
}
}]
08/22 01:46:06.094 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameStoppedLoading",
"params": {
"frameId": "3031.2"
}
}]
08/22 01:46:06.094 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameAttached",
"params": {
"frameId": "3031.4",
"parentFrameId": "3031.1"
}
}]
08/22 01:46:06.095 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameStartedLoading",
"params": {
"frameId": "3031.4"
}
}]
08/22 01:46:06.095 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameNavigated",
"params": {
"frame": {
"id": "3031.4",
"loaderId": "3031.2",
"mimeType": "text/html",
"name": "oem-eula-frame",
"parentId": "3031.1",
"securityOrigin": "://", <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< This should be chrome://oobe
"url": "about:blank"
}
}
}]
08/22 01:46:06.096 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameStoppedLoading",
"params": {
"frameId": "3031.4"
}
}]
08/22 01:46:06.096 DEBUG|inspector_websocke:0164| got [{
"id": 4,
"result": {
"result": {
"type": "boolean",
"value": true
}
}
}]
08/22 01:46:06.097 DEBUG|inspector_websocke:0097| sent [{
"id": 5,
"method": "Runtime.evaluate",
"params": {
"expression": "Oobe.remoraRequisitionForTesting();; 0;",
"returnByValue": true
}
}]
08/22 01:46:06.188 DEBUG|inspector_websocke:0164| got [{
"method": "Page.domContentEventFired",
"params": {
"timestamp": 32.411029999999997
}
}]
08/22 01:46:06.196 DEBUG|inspector_websocke:0164| got [{
"method": "Inspector.detached",
"params": {
"reason": "Render process gone."
}
}]
08/22 01:46:06.201 DEBUG|inspector_websocke:0164| got [{
"method": "Inspector.detached",
"params": {
"reason": "target_closed"
}
}]
,
Aug 22 2017
Logs from good run...
08/22 15:35:35.244 DEBUG|inspector_websocke:0097| sent [{
"id": 5,
"method": "Runtime.evaluate",
"params": {
"expression": "typeof Oobe !== 'undefined'",
"returnByValue": true
}
}]
08/22 15:35:35.602 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameAttached",
"params": {
"frameId": "2695.2",
"parentFrameId": "2695.1"
}
}]
08/22 15:35:35.602 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameStartedLoading",
"params": {
"frameId": "2695.2"
}
}]
08/22 15:35:35.603 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameNavigated",
"params": {
"frame": {
"id": "2695.2",
"loaderId": "2695.1",
"mimeType": "text/html",
"name": "cros-eula-frame",
"parentId": "2695.1",
"securityOrigin": "chrome://oobe",
"url": "about:blank"
}
}
}]
08/22 15:35:35.605 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameAttached",
"params": {
"frameId": "2695.3",
"parentFrameId": "2695.1",
"stack": {
"callFrames": [
{
"columnNumber": 16,
"functionName": "_createLocalRoot",
"lineNumber": 2075,
"scriptId": "50",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js"
},
{
"columnNumber": 5,
"functionName": "_setupRoot",
"lineNumber": 1775,
"scriptId": "50",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js"
},
{
"columnNumber": 5,
"functionName": "_ready",
"lineNumber": 129,
"scriptId": "50",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js"
},
{
"columnNumber": 5,
"functionName": "_tryReady",
"lineNumber": 120,
"scriptId": "50",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js"
},
{
"columnNumber": 5,
"functionName": "_initFeatures",
"lineNumber": 4088,
"scriptId": "53",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-extracted.js"
},
{
"columnNumber": 5,
"functionName": "__initialize",
"lineNumber": 225,
"scriptId": "49",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-micro-extracted.js"
},
{
"columnNumber": 5,
"functionName": "createdCallback",
"lineNumber": 208,
"scriptId": "49",
"url": "chrome://resources/polymer/v1_0/polymer/polymer-micro-extracted.js"
}
]
}
}
}]
08/22 15:35:35.606 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameStartedLoading",
"params": {
"frameId": "2695.3"
}
}]
08/22 15:35:35.606 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameStoppedLoading",
"params": {
"frameId": "2695.2"
}
}]
08/22 15:35:35.607 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameAttached",
"params": {
"frameId": "2695.4",
"parentFrameId": "2695.1"
}
}]
08/22 15:35:35.607 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameStartedLoading",
"params": {
"frameId": "2695.4"
}
}]
08/22 15:35:35.608 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameNavigated",
"params": {
"frame": {
"id": "2695.4",
"loaderId": "2695.2",
"mimeType": "text/html",
"name": "oem-eula-frame",
"parentId": "2695.1",
"securityOrigin": "chrome://oobe",
"url": "about:blank"
}
}
}]
08/22 15:35:35.608 DEBUG|inspector_websocke:0164| got [{
"method": "Page.frameStoppedLoading",
"params": {
"frameId": "2695.4"
}
}]
08/22 15:35:35.609 DEBUG|inspector_websocke:0164| got [{
"id": 5,
"result": {
"result": {
"type": "boolean",
"value": true
}
}
}]
08/22 15:35:35.609 DEBUG|inspector_websocke:0097| sent [{
"id": 6,
"method": "Runtime.evaluate",
"params": {
"expression": "Oobe.remoraRequisitionForTesting();; 0;",
"returnByValue": true
}
}]
08/22 15:35:35.724 DEBUG|inspector_websocke:0164| got [{
"method": "Page.domContentEventFired",
"params": {
"timestamp": 17.214476000000001
}
}]
08/22 15:35:35.728 DEBUG|inspector_websocke:0164| got [{ <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< This is missing in failure case.
"method": "Page.frameNavigated",
"params": {
"frame": {
"id": "2695.3",
"loaderId": "2695.3",
"mimeType": "text/html",
"name": "crosEulaFrame",
"parentId": "2695.1",
"securityOrigin": "chrome://terms",
"url": "chrome://terms/"
}
}
}]
08/22 15:35:35.761 DEBUG|inspector_websocke:0164| got [{
"method": "Inspector.detached",
"params": {
"reason": "Render process gone."
}
}]
08/22 15:35:35.767 DEBUG|inspector_websocke:0164| got [{
"method": "Inspector.detached",
"params": {
"reason": "target_closed"
}
}]
08/22 15:35:35.793 DEBUG| cros_interface:0363| ListProcesses(<predicate>)->[180 processes]
08/22 15:35:35.911 DEBUG| cros_interface:0363| ListProcesses(<predicate>)->[177 processes]
08/22 15:35:36.032 DEBUG| cros_interface:0363| ListProcesses(<predicate>)->[173 processes]
08/22 15:35:41.166 DEBUG| cros_interface:0363| ListProcesses(<predicate>)->[182 processes]
08/22 15:35:41.169 DEBUG| inspector_backend:0066| InspectorBackend._Connect() to ws://127.0.0.1:60417/devtools/page/f1fef925-fb3f-4a3a-be64-5b236eba0de4
08/22 15:35:41.171 DEBUG|inspector_websocke:0097| sent [{
"id": 0,
"method": "Page.enable"
}]
08/22 15:35:41.172 DEBUG|inspector_websocke:0164| got [{
"id": 0,
"result": {}
}]
08/22 15:35:41.172 INFO | oobe:0039| Invoking Oobe.skipToLoginForTesting
08/22 15:35:41.173 DEBUG|inspector_websocke:0097| sent [{
"id": 1,
"method": "Runtime.evaluate",
"params": {
"expression": "typeof Oobe == 'function' && Oobe.readyForTesting",
"returnByValue": true
}
}]
08/22 15:35:41.177 DEBUG|inspector_websocke:0164| got [{
"id": 1,
"result": {
"result": {
"type": "boolean",
"value": true
}
}
}]
,
Aug 23 2017
Issue 758184 has been merged into this issue.
,
Aug 24 2017
achuith@ - any update here? Please help fix this as soon as possible. The enrollment test is also part of the hotrod pre-cq and this failure has resulted in ALL CFM tests failing for the last week and a half on ToT. This test is critical for overall CFM test automation efforts, so it'll be great if you can prioritize the fix.
,
Aug 24 2017
Friendly ping
,
Aug 24 2017
https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/634208
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95d3ef0e9c58dd9509745f5feaa5f209e11378ac commit 95d3ef0e9c58dd9509745f5feaa5f209e11378ac Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Fri Aug 25 02:02:51 2017 Roll src/third_party/catapult/ ab4d571fa..e37aa9d60 (2 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ab4d571fa25e..e37aa9d6016b $ git log ab4d571fa..e37aa9d60 --date=short --no-merges --format='%ad %ae %s' 2017-08-24 benjhayden Make TraceEventImporter autoclose legacy async events. 2017-08-24 achuith Fix for chromeos enterprise tests. Created with: roll-dep src/third_party/catapult BUG= 755621 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic8b43a9ed1d02fc3f4516b27f2bf32a29e5186eb Reviewed-on: https://chromium-review.googlesource.com/633874 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#497299} [modify] https://crrev.com/95d3ef0e9c58dd9509745f5feaa5f209e11378ac/DEPS
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7ae8cae4399f3a87a4057bea757c9fbde4a53374 commit 7ae8cae4399f3a87a4057bea757c9fbde4a53374 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Aug 25 23:51:54 2017 autotest: Use browser.WaitForBrowserToComeUp After browser restarts, we need to connect to devtools again. WaitForBrowserToComeUp does this. Depends on this catapult CL: https://codereview.chromium.org/3005543002/ BUG= chromium:755621 TEST=enterprise_RemoraRequisition Change-Id: If11ef284ad92e76546542ffd4300a0f1ed6891c2 Reviewed-on: https://chromium-review.googlesource.com/634208 Commit-Ready: Harpreet Grewal <harpreet@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org> [add] https://crrev.com/7ae8cae4399f3a87a4057bea757c9fbde4a53374/client/site_tests/enterprise_KioskEnrollment/control [modify] https://crrev.com/7ae8cae4399f3a87a4057bea757c9fbde4a53374/client/site_tests/enterprise_RemoraRequisition/enterprise_RemoraRequisition.py [modify] https://crrev.com/7ae8cae4399f3a87a4057bea757c9fbde4a53374/client/common_lib/cros/chrome.py [modify] https://crrev.com/7ae8cae4399f3a87a4057bea757c9fbde4a53374/client/site_tests/enterprise_KioskEnrollment/enterprise_KioskEnrollment.py [modify] https://crrev.com/7ae8cae4399f3a87a4057bea757c9fbde4a53374/client/common_lib/cros/enrollment.py
,
Aug 27 2017
This is fixed on ToT. https://wmatrix.googleplex.com/unfiltered?releases=tot&suites=hotrod&hide_missing=True&days_back=10 If you are running automated tests on M62, please upgrade the build to ToT (9880.0.0 or higher). Along with enrollment, Achuith also fixed the app auto launch issue that only occurred for automated tests; eliminating the need to restart the browser after enrollment. Thanks Achuith!
,
Aug 28 2017
Woho, thanks a bunch!
,
Aug 29 2017
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b73bbecf0b03707a96f18987d0dc8ffc7eef83c1 commit b73bbecf0b03707a96f18987d0dc8ffc7eef83c1 Author: Denis Tosic <dtosic@chromium.org> Date: Wed Aug 30 20:04:26 2017 Don't restart the browser anymore since the app auto launches https://chromium-review.googlesource.com/634208 eliminated the need to restart the browser explicitly after enrollment. This is just a clean-up cl/ following up on this change. Also deprecated restart_chrome_for_cfm() and cleaned up tests. BUG= chromium:755621 TEST=enterprise_RemoraRequisition Change-Id: Ie06d7d181aa67f57c70c507b4da84cc496585596 Reviewed-on: https://chromium-review.googlesource.com/637790 Commit-Ready: Denis Tosic <dtosic@chromium.org> Tested-by: Denis Tosic <dtosic@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> [modify] https://crrev.com/b73bbecf0b03707a96f18987d0dc8ffc7eef83c1/server/site_tests/enterprise_CFM_USBPeripheralRebootStress/enterprise_CFM_USBPeripheralRebootStress.py [modify] https://crrev.com/b73bbecf0b03707a96f18987d0dc8ffc7eef83c1/client/cros/multimedia/cfm_facade_native.py [modify] https://crrev.com/b73bbecf0b03707a96f18987d0dc8ffc7eef83c1/server/cros/multimedia/cfm_facade_adapter.py [modify] https://crrev.com/b73bbecf0b03707a96f18987d0dc8ffc7eef83c1/server/site_tests/enterprise_CFM_RebootStress/enterprise_CFM_RebootStress.py
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7d09547f19c1b2f090f94d4279d19786fc8e8d31 commit 7d09547f19c1b2f090f94d4279d19786fc8e8d31 Author: Denis Tosic <dtosic@chromium.org> Date: Thu Aug 31 23:23:22 2017 Revert "Don't restart the browser anymore since the app auto launches" This reverts commit b73bbecf0b03707a96f18987d0dc8ffc7eef83c1. Reason for revert: Broke enrollment of CfMs, e.g. https://wmatrix.googleplex.com/testrun/unfiltered?test_ids=545362943 TESTED=enterprise_CFM_MeetAppSanity pre-cq-configs: bluestreak-pre-cq Original change's description: > Don't restart the browser anymore since the app auto launches > > https://chromium-review.googlesource.com/634208 eliminated the > need to restart the browser explicitly after enrollment. This is > just a clean-up cl/ following up on this change. > > Also deprecated restart_chrome_for_cfm() and cleaned up tests. > > BUG= chromium:755621 > TEST=enterprise_RemoraRequisition > > Change-Id: Ie06d7d181aa67f57c70c507b4da84cc496585596 > Reviewed-on: https://chromium-review.googlesource.com/637790 > Commit-Ready: Denis Tosic <dtosic@chromium.org> > Tested-by: Denis Tosic <dtosic@chromium.org> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Bug: chromium:755621 Change-Id: Ibf116bae6bd7ad18d71fe50aa0d9ceddfb7a0239 Reviewed-on: https://chromium-review.googlesource.com/646006 Reviewed-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Denis Tosic <dtosic@chromium.org> Tested-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/7d09547f19c1b2f090f94d4279d19786fc8e8d31/server/site_tests/enterprise_CFM_USBPeripheralRebootStress/enterprise_CFM_USBPeripheralRebootStress.py [modify] https://crrev.com/7d09547f19c1b2f090f94d4279d19786fc8e8d31/client/cros/multimedia/cfm_facade_native.py [modify] https://crrev.com/7d09547f19c1b2f090f94d4279d19786fc8e8d31/server/cros/multimedia/cfm_facade_adapter.py [modify] https://crrev.com/7d09547f19c1b2f090f94d4279d19786fc8e8d31/server/site_tests/enterprise_CFM_RebootStress/enterprise_CFM_RebootStress.py |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by harpreet@chromium.org
, Aug 16 2017