network service: HSTS headers aren't queryable via chrome://net-internals |
||||||||||||
Issue descriptionWith the network service enabled, HSTS is either not working properly or isn't being reflected properly in chrome://net-internals. Steps to reproduce: 1.) Visit hsts.badssl.com. 2.) Open chrome://net-internals#hsts and query for hsts.badssl.com. Expected: query returns 'dynamic_sts_domain: hsts.badssl.com' Observed: query returns "not found" I'm guessing this is part of issue 715695 so feel free to dup it in there.
,
Aug 16 2017
(Well, they aren't stored on disk, at least. We do have the default in-memory cache)
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
May 30 2018
,
Jun 4 2018
,
Jun 11 2018
Looking at the code, I see net-internals gets the HSTS states from the main URLRequestContext. https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/net_internals/net_internals_ui.cc?rcl=a8d5cbabf2a92a46daa5f0bfe30f4fe76fd20823&l=716 As mmenke@ mentioned in #2, the plan is to use chrome://net-export by default post-network servicification. We can investigate how to store the information in the logs generated through chrome://net-export, so I am marking this as Available.
,
Sep 4
,
Sep 5
I think I just rediscovered this issue in Version 71.0.3543.0 (Official Build) canary (64-bit). It works in Version 69.0.3497.81 (Official Build) (64-bit).
,
Sep 7
,
Sep 18
(Chris has a CL out for this)
,
Sep 19
To clarify, HSTS works correctly with network service. What doesn't work is chrome://net-internals reading/writing that data.
,
Sep 20
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311 commit f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311 Author: Chris Mumford <cmumford@google.com> Date: Fri Oct 26 17:37:02 2018 Switch chrome://net-internals to the network service. This change switches the implementation of the net-internals page from direct calls to //net to the network service. Bug: 876110 , 824974 , 755600 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Icf3b31d339084885761cb78c0bc929df92ee6781 Reviewed-on: https://chromium-review.googlesource.com/c/1228235 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#603135} [modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/chrome/browser/devtools/devtools_sanity_browsertest.cc [modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/chrome/browser/password_manager/password_manager_test_base.cc [modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/chrome/browser/ui/webui/net_internals/net_internals_ui.cc [modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/components/password_manager/core/browser/http_credentials_cleaner_unittest.cc [modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/expect_ct_reporter.h [modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/network_context.cc [modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/network_context.h [modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/network_context_unittest.cc [modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/public/mojom/network_context.mojom [modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/test/test_network_context.h
,
Nov 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce5a5595246180b8e9c99eaceadcf5518eaa41a6 Commit: ce5a5595246180b8e9c99eaceadcf5518eaa41a6 Author: cmumford@google.com Commiter: cmumford@chromium.org Date: 2018-11-04 14:53:39 +0000 UTC Switch chrome://net-internals to the network service. Merge to release branch. This change switches the implementation of the net-internals page from direct calls to //net to the network service. TBRing mmenke@ for review of network service_context changes. TBR=mmenke@chromium.org (cherry picked from commit f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311) Bug: 876110 , 824974 , 755600 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Icf3b31d339084885761cb78c0bc929df92ee6781 Reviewed-on: https://chromium-review.googlesource.com/c/1228235 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603135} Reviewed-on: https://chromium-review.googlesource.com/c/1316652 Reviewed-by: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#488} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce5a5595246180b8e9c99eaceadcf5518eaa41a6 commit ce5a5595246180b8e9c99eaceadcf5518eaa41a6 Author: Chris Mumford <cmumford@google.com> Date: Sun Nov 04 14:53:39 2018 Switch chrome://net-internals to the network service. Merge to release branch. This change switches the implementation of the net-internals page from direct calls to //net to the network service. TBRing mmenke@ for review of network service_context changes. TBR=mmenke@chromium.org (cherry picked from commit f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311) Bug: 876110 , 824974 , 755600 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Icf3b31d339084885761cb78c0bc929df92ee6781 Reviewed-on: https://chromium-review.googlesource.com/c/1228235 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603135} Reviewed-on: https://chromium-review.googlesource.com/c/1316652 Reviewed-by: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#488} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/chrome/browser/devtools/devtools_sanity_browsertest.cc [modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/chrome/browser/password_manager/password_manager_test_base.cc [modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/chrome/browser/ui/webui/net_internals/net_internals_ui.cc [modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/components/password_manager/core/browser/http_credentials_cleaner_unittest.cc [modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/expect_ct_reporter.h [modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/network_context.cc [modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/network_context.h [modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/network_context_unittest.cc [modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/public/mojom/network_context.mojom [modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/test/test_network_context.h
,
Nov 27
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by mmenke@chromium.org
, Aug 16 2017