For each CoreBluetooth APIs, we should create histograms to record success and error codes.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f908508fa602b8415510a9f56e6ad9ffe8d9ff7 commit 4f908508fa602b8415510a9f56e6ad9ffe8d9ff7 Author: jlebel <jlebel@chromium.org> Date: Fri Aug 18 01:00:34 2017 bluetooth: macOS: Adding histograms for NSError values BUG= 755590 Review-Url: https://codereview.chromium.org/2912633002 Cr-Commit-Position: refs/heads/master@{#495405} [modify] https://crrev.com/4f908508fa602b8415510a9f56e6ad9ffe8d9ff7/device/bluetooth/BUILD.gn [modify] https://crrev.com/4f908508fa602b8415510a9f56e6ad9ffe8d9ff7/device/bluetooth/bluetooth_adapter_mac.mm [add] https://crrev.com/4f908508fa602b8415510a9f56e6ad9ffe8d9ff7/device/bluetooth/bluetooth_adapter_mac_metrics.h [add] https://crrev.com/4f908508fa602b8415510a9f56e6ad9ffe8d9ff7/device/bluetooth/bluetooth_adapter_mac_metrics.mm [modify] https://crrev.com/4f908508fa602b8415510a9f56e6ad9ffe8d9ff7/device/bluetooth/bluetooth_low_energy_device_mac.mm [modify] https://crrev.com/4f908508fa602b8415510a9f56e6ad9ffe8d9ff7/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm [modify] https://crrev.com/4f908508fa602b8415510a9f56e6ad9ffe8d9ff7/device/bluetooth/bluetooth_remote_gatt_descriptor_mac.mm [modify] https://crrev.com/4f908508fa602b8415510a9f56e6ad9ffe8d9ff7/tools/metrics/histograms/enums.xml [modify] https://crrev.com/4f908508fa602b8415510a9f56e6ad9ffe8d9ff7/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64f3eeb15fec6ad49346ee949592df5de50c6076 commit 64f3eeb15fec6ad49346ee949592df5de50c6076 Author: Jérôme Lebel <jlebel@chromium.org> Date: Tue Aug 29 02:11:10 2017 bluetooth: macOS: Adding histograms for NSError values Patch set 1: crrev.com/2912633002 reverted by crrev.com/c/620327 Patch set 4: Adding definition of CBErrorMaxConnection when Chromium is compiled with 10.10 or earlier. Bug: 755590 Change-Id: Ifc9771816245ceb189d63f4ff59ff9de5bc1d8c5 Reviewed-on: https://chromium-review.googlesource.com/622907 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Vincent Scheib <scheib@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#497985} [modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/BUILD.gn [modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/bluetooth_adapter_mac.mm [add] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/bluetooth_adapter_mac_metrics.h [add] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/bluetooth_adapter_mac_metrics.mm [modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/bluetooth_low_energy_device_mac.mm [modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm [modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/bluetooth_remote_gatt_descriptor_mac.mm [modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/tools/metrics/histograms/enums.xml [modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/tools/metrics/histograms/histograms.xml
Comment 1 by bugdroid1@chromium.org
, Aug 18 2017