New issue
Advanced search Search tips

Issue 755590 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[macOS] needs histograms for CoreBluetooth API errors

Project Member Reported by jlebel@chromium.org, Aug 15 2017

Issue description

For each CoreBluetooth APIs, we should create histograms to record success and error codes.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 18 2017

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64f3eeb15fec6ad49346ee949592df5de50c6076

commit 64f3eeb15fec6ad49346ee949592df5de50c6076
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Tue Aug 29 02:11:10 2017

bluetooth: macOS: Adding histograms for NSError values

Patch set 1: crrev.com/2912633002 reverted by crrev.com/c/620327
Patch set 4: Adding definition of CBErrorMaxConnection when Chromium is compiled
with 10.10 or earlier.

Bug:  755590 
Change-Id: Ifc9771816245ceb189d63f4ff59ff9de5bc1d8c5
Reviewed-on: https://chromium-review.googlesource.com/622907
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497985}
[modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/BUILD.gn
[modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/bluetooth_adapter_mac.mm
[add] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/bluetooth_adapter_mac_metrics.h
[add] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/bluetooth_adapter_mac_metrics.mm
[modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/bluetooth_low_energy_device_mac.mm
[modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
[modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/device/bluetooth/bluetooth_remote_gatt_descriptor_mac.mm
[modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/64f3eeb15fec6ad49346ee949592df5de50c6076/tools/metrics/histograms/histograms.xml

Comment 3 by jlebel@chromium.org, Aug 29 2017

Status: Fixed (was: Started)

Sign in to add a comment