New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 755588 link

Starred by 2 users
Status: Fixed
Owner:
█ jming@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 747563


Participants' hotlists:
Downloads-Foreground-Service


Sign in to add a comment

[Downloads Foreground Service] Update notification immediately after interaction

Project Member Reported by jming@chromium.org, Aug 15 2017 
An intermediate step of the refactor is to make all notification interactions propagate through native. However, this makes notification updates slightly delayed when the native is not loaded. When DownloadNotificatioNService is no longer a service, invoke an immediate notification update after notification interaction.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db5b34d2ad8a7e934c083bbc14e350924dbc00cf

commit db5b34d2ad8a7e934c083bbc14e350924dbc00cf
Author: Joy Ming <jming@chromium.org>
Date: Thu Aug 24 17:12:39 2017

Update download notification immediately after interaction.

Because of the refactor that makes downloads a foreground service,
interactions with download notifications were being propagated straight
to native by DownloadBroadcastManager before manifesting in the
notifications through SystemDownloadNotifier. However, if native takes
too long to load, there can be a delay between the user action and the
notification update. This CL bridges that gap by propagating
notification updates immediately in certain cases (pause, resume,
cancel) in order to give feedback to the user.

Bug:  755588 , 747563 
Change-Id: Ie078f33189cc779825e3fc7216694db412be8eb7
Reviewed-on: https://chromium-review.googlesource.com/621786
Commit-Queue: Joy Ming <jming@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497096}
[modify] https://crrev.com/db5b34d2ad8a7e934c083bbc14e350924dbc00cf/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastManager.java
[modify] https://crrev.com/db5b34d2ad8a7e934c083bbc14e350924dbc00cf/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/db5b34d2ad8a7e934c083bbc14e350924dbc00cf/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
[modify] https://crrev.com/db5b34d2ad8a7e934c083bbc14e350924dbc00cf/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
[modify] https://crrev.com/db5b34d2ad8a7e934c083bbc14e350924dbc00cf/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java

Comment 2 by jming@chromium.org, Aug 24 2017

Status: Fixed (was: Assigned)

Comment 3 by jming@chromium.org, Aug 24 2017 

Issue 758685 has been merged into this issue.
►

Sign in to add a comment