New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 755582 link

Starred by 1 user
Status: Assigned
Owner:
mdjones@chromium.org
Cc:
█ bauerb@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Allow disabling infobar animations for tests

Project Member Reported by dgn@chromium.org, Aug 15 2017 
To have faster and less flaky instrumentation tests that verify states of the UI.

Infobars use the android framework animations rather than ChromeAnimations, so we don't currently have a way to disable all of them for individual tests. That requires using ADB to change system level animation multipliers.

As a workaround we could just disable all animations for tests by not running them at all.

+FYI mdjones@ as infobar specialist and bauerb@ as animation disabling specialist

Comment 1 by mdjones@chromium.org, Aug 15 2017 

We could expose endAnimation on InfoBarAnimation (https://codesearch.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainerLayout.java?rcl=083071a9031a9d0ffdc8ed2deb9c9e6b855ffd19&l=188)

Then the problem is that the animations are created in sequence after each previous one finishes; there isn't a list that exists. Unfortunately it seems like we would need a "in testing mode" state that immediately ends each animation as it is created.

Comment 2 by dgn@chromium.org, Aug 15 2017

Labels: -Pri-1 M-62 Pri-2
I was thinking about something like that yes, some sort of flag to skip animating. Maybe by setting the duration to 0? I'll play with it after FF.

Comment 3 by dgn@chromium.org, Feb 26 2018

Cc: -mdjones@chromium.org
Owner: mdjones@chromium.org
►

Sign in to add a comment