Set Offline Previews to default |
||||||
Issue descriptionAll of the offline previews and client side previews field trial values should be set to to the defaults for launch. The field trial should be on by default, offline previews should be on by default, the default value for non-host opt outs should be 6 instead of 4. the max effective connection type should be 2G.
,
Aug 15 2017
Can you explain in more detail what this bug means? I don't entirely understand it so I don't know which launches it should block.
,
Aug 15 2017
This blocks the full launch to stable, as moving to non-experimental requires turning the feature on by default (e.g., this needs to land, then code lands in the server that will handle M60-M61, and no field trial configs will be needed for M62+)
,
Aug 17 2017
This is blocking the full stable launch of offline previews, so blocking the launch bug.
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db1bd600b468fc62b7ef4873a876ecdf5be76771 commit db1bd600b468fc62b7ef4873a876ecdf5be76771 Author: Ryan Sturm <ryansturm@chromium.org> Date: Thu Aug 17 20:30:10 2017 Setting offline previews to default Adjusting a few params to match field trial. Also setting non-host threshold to 6 (which the field trials will soon match). This CL also splits OfflinePreviews from ClientSidePreviews. The former will either be enabled or disabled (flags, via finch). The latter will be controlled via finch to change parameters mainly related to the client side blacklist. launch bug:632865 Bug: 755581 Change-Id: Ie6807d1ef5e65064f8e8c887964a54701d1c7af8 Reviewed-on: https://chromium-review.googlesource.com/614799 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#495304} [modify] https://crrev.com/db1bd600b468fc62b7ef4873a876ecdf5be76771/chrome/browser/previews/previews_service_unittest.cc [modify] https://crrev.com/db1bd600b468fc62b7ef4873a876ecdf5be76771/components/previews/core/previews_experiments.cc [modify] https://crrev.com/db1bd600b468fc62b7ef4873a876ecdf5be76771/components/previews/core/previews_experiments_unittest.cc [modify] https://crrev.com/db1bd600b468fc62b7ef4873a876ecdf5be76771/components/previews/core/previews_features.cc [modify] https://crrev.com/db1bd600b468fc62b7ef4873a876ecdf5be76771/components/previews/core/previews_io_data_unittest.cc [modify] https://crrev.com/db1bd600b468fc62b7ef4873a876ecdf5be76771/testing/variations/fieldtrial_testing_config.json
,
Aug 21 2017
,
Sep 8 2017
Issue 750262 has been merged into this issue.
,
Dec 5 2017
,
Dec 5 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tbansal@chromium.org
, Aug 15 2017