New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755578 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Video Capture] Add test for covering issue 755248

Project Member Reported by chfremer@chromium.org, Aug 15 2017

Issue description

 Issue 755248  [1] was a regression that managed to pass all trybots and did not even fail any webrtc test as well. We need to add test coverage for this type of case in order to catch future regressions before they can land.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=755248
 
Components: Blink>GetUserMedia>Webcam

Comment 2 by guidou@chromium.org, Aug 16 2017

Components: -Blink>GetUserMedia>Webcam Blink>GetUserMedia
As explained in  issue 755248 , the root cause is invalid audio parameters sent across processes. Thus, removing the webcam label.

Comment 3 by guidou@chromium.org, Aug 16 2017

Cc: c.pa...@samsung.com
The original fix to  issue 755248  already includes one test to cover the problem, but it's a good idea to look at all places were media::AudioParameters are being sent across process as a consequence of the removal of content::AudioDeviceParameters and add more regression tests if applicable.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64f37d1e31dfe3315477f940f9a0cd48c4bc16b4

commit 64f37d1e31dfe3315477f940f9a0cd48c4bc16b4
Author: Chandan Padhi <c.padhi@samsung.com>
Date: Wed Aug 16 19:56:08 2017

Ensure media::AudioParameters used for |input| are valid

Default-constructed media::AudioParameters are invalid and therefore
not serializable. Such parameters if sent across processes result in
deserialization failures.

Bug:  755578 
Change-Id: Ia5ae18fbc4862dab4e1c5fbf8496c1bd6009b7c6
Reviewed-on: https://chromium-review.googlesource.com/616548
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#494908}
[modify] https://crrev.com/64f37d1e31dfe3315477f940f9a0cd48c4bc16b4/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/64f37d1e31dfe3315477f940f9a0cd48c4bc16b4/content/public/common/media_stream_request.cc
[modify] https://crrev.com/64f37d1e31dfe3315477f940f9a0cd48c4bc16b4/content/renderer/media/mock_media_stream_dispatcher.cc

Project Member

Comment 5 by sheriffbot@chromium.org, Aug 20

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Status: Fixed (was: Available)

Sign in to add a comment