New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755573 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

dptf: failed to build with clang

Project Member Reported by yunlian@chromium.org, Aug 15 2017

Issue description

With latest llvm.
dptf-8.4.10100-r1: x86_64-cros-linux-gnu-clang -c -O2 -pipe -O2 -pipe -march=corei7 -g       -clang-syntax -Wno-multichar -Werror -fPIE -fPIC -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -fstack-protector -I/build/terra/usr/include/dbus-1.0 -I/build/terra/usr/lib64/dbus-1.0/include   -I../../ESIF_UF/Sources -I../../ESIF_CM/Sources -I../../ESIF_WS/Sources -I../../ESIF_LIB/Sources -I../../../../Common -DESIF_ATTR_USER  -DESIF_ATTR_DAEMON -DESIF_FEAT_OPT_COMPRESS -DESIF_ATTR_OS_CHROME -DESIF_ATTR_OS_LINUX_HAVE_READLINE  -std=gnu89 -DESIF_FEAT_OPT_ACTION_SYSFS -DESIF_FEAT_OPT_DBUS -o ../../ESIF_LIB/Sources/esif_lib_istring.o ../../ESIF_LIB/Sources/esif_lib_istring.c
dptf-8.4.10100-r1: x86_64-cros-linux-gnu-clang -c -O2 -pipe -O2 -pipe -march=corei7 -g       -clang-syntax -Wno-multichar -Werror -fPIE -fPIC -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -fstack-protector -I/build/terra/usr/include/dbus-1.0 -I/build/terra/usr/lib64/dbus-1.0/include   -I../../ESIF_UF/Sources -I../../ESIF_CM/Sources -I../../ESIF_WS/Sources -I../../ESIF_LIB/Sources -I../../../../Common -DESIF_ATTR_USER  -DESIF_ATTR_DAEMON -DESIF_FEAT_OPT_COMPRESS -DESIF_ATTR_OS_CHROME -DESIF_ATTR_OS_LINUX_HAVE_READLINE  -std=gnu89 -DESIF_FEAT_OPT_ACTION_SYSFS -DESIF_FEAT_OPT_DBUS -o ../../ESIF_WS/Sources/esif_ws_algo.o ../../ESIF_WS/Sources/esif_ws_algo.c
dptf-8.4.10100-r1: ../../ESIF_UF/Sources/esif_uf_shell.c:160:9: error: unterminated '#pragma pack (push, ...)' at end of file [-Werror,-Wpragma-pack]
dptf-8.4.10100-r1: #pragma pack(push, 1)
dptf-8.4.10100-r1:         ^
dptf-8.4.10100-r1: 1 error generated.
dptf-8.4.10100-r1: make: *** [Makefile:184: ../../ESIF_UF/Sources/esif_uf_shell.o] Error 1
dptf-8.4.10100-r1: make: *** Waiting for unfinished jobs....
dptf-8.4.10100-r1: make: Leaving directory '/build/terra/tmp/portage/sys-power/dptf-8.4.10100-r1/work/dptf-8.4.10100/ESIF/Products/ESIF_UF/Linux'
dptf-8.4.10100-r1:  * ERROR: sys-power/dptf-8.4.10100-r1::chromiumos failed (compile phase):
dptf-8.4.10100-r1:  *   emake failed
 
Labels: Build-Toolchain
Owner: yunlian@chromium.org
Labels: OS-Chrome
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/79371888d07436fd62b680f923ed39087e03bea2

commit 79371888d07436fd62b680f923ed39087e03bea2
Author: Yunlian Jiang <yunlian@google.com>
Date: Tue Aug 15 21:54:13 2017

dptf: fix build warning on latest LLVM.

This fixes a build time error with latest LLVM.
unterminated '#pragma pack'

BUG= chromium:755573 
TEST=emerge-terra dptf passes with next LLVM.

Change-Id: Ic338c7483f10a2bc804b2f7447d4b9e600f26bb6
Reviewed-on: https://chromium-review.googlesource.com/614753
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Brian Bian <brian.bian@intel.com>

[add] https://crrev.com/79371888d07436fd62b680f923ed39087e03bea2/sys-power/dptf/files/dptf-fix-unterminated-pragma.patch
[rename] https://crrev.com/79371888d07436fd62b680f923ed39087e03bea2/sys-power/dptf/dptf-8.4.10100-r2.ebuild

Status: Verified (was: Untriaged)

Sign in to add a comment