New issue
Advanced search Search tips

Issue 755566 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 691782



Sign in to add a comment

Synchronize Worklet data upon script evalution

Project Member Reported by hongchan@chromium.org, Aug 15 2017

Issue description

The PR currently in review.

PR: https://github.com/WebAudio/web-audio-api/pull/1265
Preview: https://cdn.rawgit.com/WebAudio/web-audio-api/0f41913a344e2b750d2ed1d680fa9322936856df/index.html#instantiation-of-AudioWorkletNode-and-AudioWorkletProcessor

Upon the evaluation of script in AudioWorkletGlobalScope, the associated BaseAudioContext
needs to be updated with the data from the script.

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc048ad57c3f2eb6c64cf15b3a0af2a9b284a54f

commit fc048ad57c3f2eb6c64cf15b3a0af2a9b284a54f
Author: Hongchan Choi <hongchan@chromium.org>
Date: Wed Aug 30 23:28:53 2017

Synchronize AudioWorkletProcessor information upon script evaluation

Spec: https://webaudio.github.io/web-audio-api/#dfn-node-name-to-parameter-descriptor-map

Upon the evaluation of script in AudioWorkletGlobalScope, the
associated AudioWokrletMessagingProxy (which is associated
with a BaseAudioContext) needs to be updated with the data
from the script.

Bug:  755566 
Change-Id: I9013adf67710b9d8cf932efc94be27116727dd95
Reviewed-on: https://chromium-review.googlesource.com/622067
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498664}
[modify] https://crrev.com/fc048ad57c3f2eb6c64cf15b3a0af2a9b284a54f/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScope.cpp
[modify] https://crrev.com/fc048ad57c3f2eb6c64cf15b3a0af2a9b284a54f/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScope.h
[modify] https://crrev.com/fc048ad57c3f2eb6c64cf15b3a0af2a9b284a54f/third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.cpp
[modify] https://crrev.com/fc048ad57c3f2eb6c64cf15b3a0af2a9b284a54f/third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.h
[modify] https://crrev.com/fc048ad57c3f2eb6c64cf15b3a0af2a9b284a54f/third_party/WebKit/Source/modules/webaudio/AudioWorkletObjectProxy.cpp
[modify] https://crrev.com/fc048ad57c3f2eb6c64cf15b3a0af2a9b284a54f/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.h
[modify] https://crrev.com/fc048ad57c3f2eb6c64cf15b3a0af2a9b284a54f/third_party/WebKit/Source/modules/webaudio/BUILD.gn
[add] https://crrev.com/fc048ad57c3f2eb6c64cf15b3a0af2a9b284a54f/third_party/WebKit/Source/modules/webaudio/CrossThreadAudioWorkletProcessorInfo.h

Status: Fixed (was: Started)

Sign in to add a comment