SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/nQl0ORHy7sw/HNpR96sqAgAJ. We would like to migrate Cronet embedders off SDCH and unship it.
M63 is almost here according to the schedule. I start a CL to remove the code and deprecate the API.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/684711c689a09007d7cd5dc22bb75e2dae7f5d28 commit 684711c689a09007d7cd5dc22bb75e2dae7f5d28 Author: Helen Li <xunjieli@chromium.org> Date: Wed Sep 06 20:45:19 2017 [Cronet] Unship SDCH support SDCH has been disabled in Chrome since M59. For more details please see crbug.com/690070 and blink-dev@ thread linked from the bug below. This CL removes SDCH code from Cronet and deprecate CronetEngine.Builder#enableSdch() API, which is now no-op. This should not break any Cronet consumers because disabling Sdch does not affect correctness. Bug: 755561 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I909429664fc07bf0dbe92df3f050a9bdeec073f2 Reviewed-on: https://chromium-review.googlesource.com/646591 Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#500076} [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/android/BUILD.gn [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/android/api/src/org/chromium/net/CronetEngine.java [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/android/api/src/org/chromium/net/ExperimentalCronetEngine.java [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/android/cronet_url_request_context_adapter.cc [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/android/cronet_url_request_context_adapter.h [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java [delete] https://crrev.com/8669a8b3d62f1dcafb7001d56f0fac7b1f8b6219/components/cronet/android/test/assets/test/sdch/LeQxM80O_encoded [delete] https://crrev.com/8669a8b3d62f1dcafb7001d56f0fac7b1f8b6219/components/cronet/android/test/assets/test/sdch/LeQxM80O_encoded.mock-http-headers [delete] https://crrev.com/8669a8b3d62f1dcafb7001d56f0fac7b1f8b6219/components/cronet/android/test/assets/test/sdch/dict/LeQxM80O [delete] https://crrev.com/8669a8b3d62f1dcafb7001d56f0fac7b1f8b6219/components/cronet/android/test/assets/test/sdch/dict/LeQxM80O.mock-http-headers [delete] https://crrev.com/8669a8b3d62f1dcafb7001d56f0fac7b1f8b6219/components/cronet/android/test/assets/test/sdch/index [delete] https://crrev.com/8669a8b3d62f1dcafb7001d56f0fac7b1f8b6219/components/cronet/android/test/assets/test/sdch/index.mock-http-headers [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/android/test/cronet_url_request_context_config_test.cc [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java [delete] https://crrev.com/8669a8b3d62f1dcafb7001d56f0fac7b1f8b6219/components/cronet/android/test/javatests/src/org/chromium/net/SdchTest.java [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/android/test/native_test_server.cc [delete] https://crrev.com/8669a8b3d62f1dcafb7001d56f0fac7b1f8b6219/components/cronet/android/test/sdch_test_util.cc [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/android/test/src/org/chromium/net/CronetTestUtil.java [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/android/test/src/org/chromium/net/NativeTestServer.java [delete] https://crrev.com/8669a8b3d62f1dcafb7001d56f0fac7b1f8b6219/components/cronet/android/test/src/org/chromium/net/SdchObserver.java [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/cronet_prefs_manager.cc [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/cronet_prefs_manager.h [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/stale_host_resolver_unittest.cc [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/url_request_context_config.cc [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/url_request_context_config.h [modify] https://crrev.com/684711c689a09007d7cd5dc22bb75e2dae7f5d28/components/cronet/url_request_context_config_unittest.cc
Comment 1 by xunji...@chromium.org
, Aug 24 2017