New issue
Advanced search Search tips

Issue 755552 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 731302



Sign in to add a comment

HttpCache.RangeGET_ParallelValidationDifferentRanges failing in net_unittests on Fuchsia

Project Member Reported by scottmg@chromium.org, Aug 15 2017

Issue description

https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/8764
https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/8774

[00146.754] 03070.03119> [ RUN      ] HttpCache.RangeGET_ParallelValidationDifferentRanges
[00146.754] 03070.03119> ../../net/http/http_cache_unittest.cc:1737: Failure
[00146.754] 03070.03119>       Expected: 2
[00146.754] 03070.03119> To be equal to: cache.network_layer()->transaction_count()
[00146.754] 03070.03119>       Which is: 3
[00146.754] 03070.03119> [3:586038165:0815/051311.497046:142176179:ERROR:http_transaction_test_util.cc(534)] Not implemented reached in virtual void net::MockNetworkTransaction::GetConnectionAttempts(net::ConnectionAttempts *) const
[00146.754] 03070.03119> ../../net/http/http_cache_unittest.cc:1752: Failure
[00146.754] 03070.03119>       Expected: 2
[00146.754] 03070.03119> To be equal to: cache.network_layer()->transaction_count()
[00146.754] 03070.03119>       Which is: 4
[00146.754] 03070.03119> [  FAILED  ] HttpCache.RangeGET_ParallelValidationDifferentRanges (202 ms)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a09f367e2db4701a3ed5426257689f7da99933ef

commit a09f367e2db4701a3ed5426257689f7da99933ef
Author: Scott Graham <scottmg@chromium.org>
Date: Tue Aug 15 16:13:26 2017

fuchsia: filter HttpCache.RangeGET_ParallelValidationDifferentRanges in net_unittests

Has failed on waterfall a couple times with same output.

TBR: sergeyu@chromium.org
Bug:  755552 
Change-Id: Id0f2844d1fc285be08ed29c0ba77554357948db0
Reviewed-on: https://chromium-review.googlesource.com/614867
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494395}
[modify] https://crrev.com/a09f367e2db4701a3ed5426257689f7da99933ef/testing/buildbot/filters/fuchsia.net_unittests.filter

Blocking: -738275 731302
Apparently I failed at disabling this?
https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/8839 flaked again.
Yeah, looks like the comment is the problem.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e4018819b95b94dc1c92820ca14a7dbdb304b24

commit 7e4018819b95b94dc1c92820ca14a7dbdb304b24
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Aug 16 20:50:36 2017

fuchsia: move comment in net_unittests filter

End of line comments don't seem to work in .filter files.

See https://bugs.chromium.org/p/chromium/issues/detail?id=755552#c3.

It is documented this way, despite this being a bit weak: https://cs.chromium.org/chromium/src/testing/buildbot/filters/README.md?q=testing/buildbot/filters/README.md&sq=package:chromium&dr

Bug:  755552 
Change-Id: I337743b63922e347b029bcbdb323da3241585735
Reviewed-on: https://chromium-review.googlesource.com/617644
Commit-Queue: Scott Graham <scottmg@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494940}
[modify] https://crrev.com/7e4018819b95b94dc1c92820ca14a7dbdb304b24/testing/buildbot/filters/fuchsia.net_unittests.filter

Cc: -sergeyu@chromium.org
Owner: sergeyu@chromium.org
Status: Assigned (was: Untriaged)
Cc: sergeyu@chromium.org
 Issue 758221  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d720181b21811bcb8e80f49cffc5bca13fd34f0

commit 3d720181b21811bcb8e80f49cffc5bca13fd34f0
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Sep 13 01:21:57 2017

Enable RangeGet_* on Fuchsia to verify if they are still flaky

Two RangeGet tests were disabled in net_unittests on Fuchsia because
they were flaky. It's likely that these two tests were fixed with
http://crrev.com/500757 (which added IO event handling in
RunLoop::RunUntilIdle()). Enable them to see if they are still flaky.

Bug:  755552 
Change-Id: I96146aa7e8247aff764853de656d9997d3cf5028
Reviewed-on: https://chromium-review.googlesource.com/663798
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501500}
[modify] https://crrev.com/3d720181b21811bcb8e80f49cffc5bca13fd34f0/testing/buildbot/filters/fuchsia.net_unittests.filter

Status: Fixed (was: Assigned)

Sign in to add a comment