[autofill] Don't offer autofill on chrome-internal URLS |
|||||
Issue descriptionChrome should not offer autofill on chrome://..., about://, and other internal URLS.
,
Aug 16 2017
I'm not able to repro the reported issue. I am able to see autocomplete triggering on the test page, but not autofill. And the initial report from urusant@google.com came with a stack trace of a crash... which i'm unable to repro.
,
Aug 16 2017
The stack trace of the crash: [1:1:0814/105846.361500:FATAL:autofill_agent.cc(499)] Check failed: false. #0 0x7f20613b11dd base::debug::StackTrace::StackTrace() #1 0x7f20613af5ac base::debug::StackTrace::StackTrace() #2 0x7f206143fa4a logging::LogMessage::~LogMessage() #3 0x55c80c4308e4 autofill::AutofillAgent::ClearPreviewedForm() #4 0x55c8079ef73e autofill::mojom::AutofillAgentStubDispatch::Accept() #5 0x55c80c434423 autofill::mojom::AutofillAgentStub<>::Accept() #6 0x7f205fa80dd6 mojo::InterfaceEndpointClient::HandleValidatedMessage() #7 0x7f205fa7f9a1 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept() #8 0x7f205fa7dcdc mojo::FilterChain::Accept() #9 0x7f205fa83821 mojo::InterfaceEndpointClient::HandleIncomingMessage() #10 0x7f205fa9c42a mojo::internal::MultiplexRouter::ProcessIncomingMessage() #11 0x7f205fa9bb11 mojo::internal::MultiplexRouter::Accept() #12 0x7f205fa7dcdc mojo::FilterChain::Accept() #13 0x7f205fa708d4 mojo::Connector::ReadSingleMessage() #14 0x7f205fa7193a mojo::Connector::ReadAllAvailableMessages() #15 0x7f205fa716fe mojo::Connector::OnHandleReadyInternal() #16 0x7f205fa715db mojo::Connector::OnWatcherHandleReady() #17 0x7f205fa7502f _ZN4base8internal13FunctorTraitsIMN4mojo9ConnectorEFvjEvE6InvokeIPS3_JjEEEvS5_OT_DpOT0_ #18 0x7f205fa74f5f _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4mojo9ConnectorEFvjEJPS5_jEEEvOT_DpOT0_ #19 0x7f205fa74ef5 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOj #20 0x7f205fa74e34 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE3RunEPNS0_13BindStateBaseEOj #21 0x7f205fa6abac _ZNKR4base8CallbackIFvjELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEj #22 0x7f205fa73fcf mojo::SimpleWatcher::DiscardReadyState() #23 0x7f205fa74244 _ZN4base8internal13FunctorTraitsIPFvRKNS_8CallbackIFvjELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEjRKN4mojo18HandleSignalsStateEEvE6InvokeIJS8_jSC_EEEvSE_DpOT_ #24 0x7f205fa741f0 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKPFvRKNS_8CallbackIFvjELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEjRKN4mojo18HandleSignalsStateEEJSA_jSE_EEEvOT_DpOT0_ #25 0x7f205fa74190 _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_8CallbackIFvjELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEjRKN4mojo18HandleSignalsStateEEJS7_EEEFvjSD_EE7RunImplIRKSF_RKNSt3__15tupleIJS7_EEEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOjSD_ #26 0x7f205fa740c4 _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_8CallbackIFvjELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEjRKN4mojo18HandleSignalsStateEEJS7_EEEFvjSD_EE3RunEPNS0_13BindStateBaseEOjSD_ #27 0x7f205fa2387c _ZNKR4base8CallbackIFvjRKN4mojo18HandleSignalsStateEELNS_8internal8CopyModeE1ELNS6_10RepeatModeE1EE3RunEjS4_ #28 0x7f205fa22e35 mojo::SimpleWatcher::OnHandleReady() #29 0x7f205fa243d3 _ZN4base8internal13FunctorTraitsIMN4mojo13SimpleWatcherEFvijRKNS2_18HandleSignalsStateEEvE6InvokeIRKNS_7WeakPtrIS3_EEJRKiRKjS6_EEEvS8_OT_DpOT0_ #30 0x7f205fa242e5 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN4mojo13SimpleWatcherEFvijRKNS4_18HandleSignalsStateEERKNS_7WeakPtrIS5_EEJRKiRKjS8_EEEvOT_OT0_DpOT1_ #31 0x7f205fa24242 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #32 0x7f205fa240bc _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE3RunEPNS0_13BindStateBaseE #33 0x7f206135c861 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv #34 0x7f20613b5e27 base::debug::TaskAnnotator::RunTask() #35 0x7f204e53cfba blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue() #36 0x7f204e53815a blink::scheduler::TaskQueueManager::DoWork() #37 0x7f204e544847 _ZN4base8internal13FunctorTraitsIMN5blink9scheduler16TaskQueueManagerEFvbEvE6InvokeIRKNS_7WeakPtrIS4_EEJRKbEEEvS6_OT_DpOT0_ #38 0x7f204e5447a5 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN5blink9scheduler16TaskQueueManagerEFvbERKNS_7WeakPtrIS6_EEJRKbEEEvOT_OT0_DpOT1_ #39 0x7f204e54471d _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvbEJNS_7WeakPtrIS5_EEbEEEFvvEE7RunImplIRKS7_RKNSt3__15tupleIJS9_bEEEJLm0ELm1EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #40 0x7f204e54462c _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvbEJNS_7WeakPtrIS5_EEbEEEFvvEE3RunEPNS0_13BindStateBaseE #41 0x7f206135c861 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv #42 0x7f20613b5e27 base::debug::TaskAnnotator::RunTask() #43 0x7f206146e7b3 base::MessageLoop::RunTask() #44 0x7f206146ea37 base::MessageLoop::DeferOrRunPendingTask() #45 0x7f206146f7ba base::MessageLoop::DoWork() #46 0x7f20614760d8 base::MessagePumpDefault::Run() #47 0x7f206146dec4 base::MessageLoop::Run() #48 0x7f2061523e9d base::RunLoop::Run() #49 0x7f205c38c1ab content::RendererMain() #50 0x7f205c8496bc content::RunZygote() #51 0x7f205c84a389 content::RunNamedProcessTypeMain() #52 0x7f205c84cdde content::ContentMainRunnerImpl::Run() #53 0x7f205c847c9d content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #54 0x7f2061cb9075 service_manager::Main() #55 0x7f205c84905f content::ContentMain() #56 0x55c806e5903e ChromeMain #57 0x55c806e58f52 main #58 0x7f2048836f45 __libc_start_main #59 0x55c806e58e34 <unknown> Received signal 6 #0 0x7f20613b11dd base::debug::StackTrace::StackTrace() #1 0x7f20613af5ac base::debug::StackTrace::StackTrace() #2 0x7f20613b0b95 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f2061a12330 <unknown> #4 0x7f204884bc37 gsignal #5 0x7f204884f028 abort #6 0x7f20613ac5a6 base::debug::(anonymous namespace)::DebugBreak() #7 0x7f20613ac588 base::debug::BreakDebugger() #8 0x7f2061440706 logging::LogMessage::~LogMessage() #9 0x55c80c4308e4 autofill::AutofillAgent::ClearPreviewedForm() #10 0x55c8079ef73e autofill::mojom::AutofillAgentStubDispatch::Accept() #11 0x55c80c434423 autofill::mojom::AutofillAgentStub<>::Accept() #12 0x7f205fa80dd6 mojo::InterfaceEndpointClient::HandleValidatedMessage() #13 0x7f205fa7f9a1 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept() #14 0x7f205fa7dcdc mojo::FilterChain::Accept() #15 0x7f205fa83821 mojo::InterfaceEndpointClient::HandleIncomingMessage() #16 0x7f205fa9c42a mojo::internal::MultiplexRouter::ProcessIncomingMessage() #17 0x7f205fa9bb11 mojo::internal::MultiplexRouter::Accept() #18 0x7f205fa7dcdc mojo::FilterChain::Accept() #19 0x7f205fa708d4 mojo::Connector::ReadSingleMessage() #20 0x7f205fa7193a mojo::Connector::ReadAllAvailableMessages() #21 0x7f205fa716fe mojo::Connector::OnHandleReadyInternal() #22 0x7f205fa715db mojo::Connector::OnWatcherHandleReady() #23 0x7f205fa7502f _ZN4base8internal13FunctorTraitsIMN4mojo9ConnectorEFvjEvE6InvokeIPS3_JjEEEvS5_OT_DpOT0_ #24 0x7f205fa74f5f _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4mojo9ConnectorEFvjEJPS5_jEEEvOT_DpOT0_ #25 0x7f205fa74ef5 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOj #26 0x7f205fa74e34 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE3RunEPNS0_13BindStateBaseEOj #27 0x7f205fa6abac _ZNKR4base8CallbackIFvjELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEj #28 0x7f205fa73fcf mojo::SimpleWatcher::DiscardReadyState() #29 0x7f205fa74244 _ZN4base8internal13FunctorTraitsIPFvRKNS_8CallbackIFvjELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEjRKN4mojo18HandleSignalsStateEEvE6InvokeIJS8_jSC_EEEvSE_DpOT_ #30 0x7f205fa741f0 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKPFvRKNS_8CallbackIFvjELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEjRKN4mojo18HandleSignalsStateEEJSA_jSE_EEEvOT_DpOT0_ #31 0x7f205fa74190 _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_8CallbackIFvjELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEjRKN4mojo18HandleSignalsStateEEJS7_EEEFvjSD_EE7RunImplIRKSF_RKNSt3__15tupleIJS7_EEEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOjSD_ #32 0x7f205fa740c4 _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_8CallbackIFvjELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEjRKN4mojo18HandleSignalsStateEEJS7_EEEFvjSD_EE3RunEPNS0_13BindStateBaseEOjSD_ #33 0x7f205fa2387c _ZNKR4base8CallbackIFvjRKN4mojo18HandleSignalsStateEELNS_8internal8CopyModeE1ELNS6_10RepeatModeE1EE3RunEjS4_ #34 0x7f205fa22e35 mojo::SimpleWatcher::OnHandleReady() #35 0x7f205fa243d3 _ZN4base8internal13FunctorTraitsIMN4mojo13SimpleWatcherEFvijRKNS2_18HandleSignalsStateEEvE6InvokeIRKNS_7WeakPtrIS3_EEJRKiRKjS6_EEEvS8_OT_DpOT0_ #36 0x7f205fa242e5 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN4mojo13SimpleWatcherEFvijRKNS4_18HandleSignalsStateEERKNS_7WeakPtrIS5_EEJRKiRKjS8_EEEvOT_OT0_DpOT1_ #37 0x7f205fa24242 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #38 0x7f205fa240bc _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE3RunEPNS0_13BindStateBaseE #39 0x7f206135c861 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv #40 0x7f20613b5e27 base::debug::TaskAnnotator::RunTask() #41 0x7f204e53cfba blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue() #42 0x7f204e53815a blink::scheduler::TaskQueueManager::DoWork() #43 0x7f204e544847 _ZN4base8internal13FunctorTraitsIMN5blink9scheduler16TaskQueueManagerEFvbEvE6InvokeIRKNS_7WeakPtrIS4_EEJRKbEEEvS6_OT_DpOT0_ #44 0x7f204e5447a5 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN5blink9scheduler16TaskQueueManagerEFvbERKNS_7WeakPtrIS6_EEJRKbEEEvOT_OT0_DpOT1_ #45 0x7f204e54471d _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvbEJNS_7WeakPtrIS5_EEbEEEFvvEE7RunImplIRKS7_RKNSt3__15tupleIJS9_bEEEJLm0ELm1EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #46 0x7f204e54462c _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvbEJNS_7WeakPtrIS5_EEbEEEFvvEE3RunEPNS0_13BindStateBaseE #47 0x7f206135c861 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv #48 0x7f20613b5e27 base::debug::TaskAnnotator::RunTask() #49 0x7f206146e7b3 base::MessageLoop::RunTask() #50 0x7f206146ea37 base::MessageLoop::DeferOrRunPendingTask() #51 0x7f206146f7ba base::MessageLoop::DoWork() #52 0x7f20614760d8 base::MessagePumpDefault::Run() #53 0x7f206146dec4 base::MessageLoop::Run() #54 0x7f2061523e9d base::RunLoop::Run() #55 0x7f205c38c1ab content::RendererMain() #56 0x7f205c8496bc content::RunZygote() #57 0x7f205c84a389 content::RunNamedProcessTypeMain() #58 0x7f205c84cdde content::ContentMainRunnerImpl::Run() #59 0x7f205c847c9d content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #60 0x7f2061cb9075 service_manager::Main() #61 0x7f205c84905f content::ContentMain() r8: fffffffffffffed8 r9: fffffffffffffec8 r10: 0000000000000008 r11: 0000000000000202 r12: 000055c806e58e0b r13: 00007ffe4e5a6cc0 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000000001 si: 0000000000000001 bp: 00007ffe4e59db80 bx: 0000000000000000 dx: 0000000000000006 ax: 0000000000000000 cx: 00007f204884bc37 sp: 00007ffe4e59da48 ip: 00007f204884bc37 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated.
,
Aug 17 2017
,
May 1 2018
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned". |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rogerm@chromium.org
, Aug 15 2017