New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755542 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Changes to the page title are not announced by screen readers

Project Member Reported by katiehockman@google.com, Aug 15 2017

Issue description

Chrome Version       : 59.0.3071.134 (Official Build) (64-bit)
URLs (if applicable) : http://dr/corp/drive/starred
Other browsers tested: None
  Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
     Safari: -
    Firefox: -
         IE: -

What steps will reproduce the problem?
(0) Start ChromeVox by pressing ctrl+alt+z.
(1) Open a new page which results in a page title change.
 or
(1) Within a site, click a navigation link that updates the page title of the site.

What is the expected result?
The title should be read out to the user when it updates. This is crucial as navigation in many sites rely on title updates to communicate to users that the page content has changed, and that the user has been sent to a new place. This gives Chromevox users important contextual information about the page they are now on.

What happens instead?
The title updates are not read out. If the page title updates when a user selects a navigation link on the page, there is no feedback to the user that the title has changed.
 
Components: -UI>Accessibility UI>Accessibility>ChromeVox
Labels: OS-Chrome
Components: Blink>Accessibility
Status: Available (was: Unconfirmed)
Same as b/30029909

We need to fix this in Blink accessibility first, then make sure ChromeVox announces such changes.


Summary: Changes to the page title are not announced by screen readers (was: [Chromevox] Page title not read to users when it updates)
Owner: jamwalla@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7

commit 6fcde312b4eebcbf61d171a855c36fa06d1a9fa7
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Tue Jul 10 16:06:31 2018

Post accessibility event when document title changes

When Document::UpdateTitle() is called, post a new event corresponding
to ui::AXEventGenerator::Event::DOCUMENT_TITLE_CHANGED. ChromeVox will
speak the new title when it changes.

DumpAccessibilityTreeTest.AccessibilityTitleChanged
TBR=slan@chromium.org

Test: in content_browsertests,
Test: in chromevox_tests, BackgroundTest.DocumentTitleChanged
Bug:  755542 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I335d39393a2b70cc84389aebc21417bee8788e5e
Reviewed-on: https://chromium-review.googlesource.com/1119353
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573757}
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/chrome/renderer/extensions/automation_ax_tree_wrapper.cc
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/chromecast/common/extensions_api/automation.idl
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/chromecast/renderer/extensions/automation_ax_tree_wrapper.cc
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/content/shell/test_runner/web_frame_test_client.cc
[add] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/content/test/data/accessibility/html/title-changed-expected-blink.txt
[add] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/content/test/data/accessibility/html/title-changed.html
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/third_party/blink/public/web/web_ax_enums.h
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/third_party/blink/renderer/core/dom/ax_object_cache.h
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/ui/accessibility/ax_enum_util.cc
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/ui/accessibility/ax_event_generator.cc
[modify] https://crrev.com/6fcde312b4eebcbf61d171a855c36fa06d1a9fa7/ui/accessibility/ax_event_generator_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment