[WPT export] commit was exported twice, leading to duplicated tests in wpt (and reimported) |
||
Issue descriptionhttps://chromium-review.googlesource.com/550076 was exported to wpt twice: https://github.com/w3c/web-platform-tests/pull/6350 https://github.com/w3c/web-platform-tests/pull/6525 This was possible without conflicts because they were moved out of the way in between: https://github.com/w3c/web-platform-tests/pull/6442 The exporter must have considered it not exported and tried again, but why?
,
Aug 15 2017
Fixing it in https://github.com/w3c/web-platform-tests/pull/6894
,
Aug 15 2017
I took a quick look at the PRs. I have strong belief that the reason being the first PR had slipped out of the pr_history_window, which used to be only 100 before we implemented issue 740175 , when the second PR was created. I searched for PRs with the chromium-export label on GitHub and there were indeed more than 100 of them between #6350 and #6525 (in other words, most of the PRs in between were made by our chromium bot). Now that we support pagination and fetch all PRs from GitHub, this should not happen again. (Well, strictly speaking, the window is now 5000, which means "all" in the near future, but we will revisit the window size later in issue 752214.) Marking as fixed as both the anomaly itself and the underlying cause have been fixed. |
||
►
Sign in to add a comment |
||
Comment 1 by foolip@chromium.org
, Aug 15 2017