New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755504 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Rename VirtualKeyboardBrowserTest

Project Member Reported by oka@chromium.org, Aug 15 2017

Issue description

It only tests the default IME chrome://keyboard, and every private APIs are mocked.

Let's rename it to something like DefaultKeyboardExtensionBrowserTest to avoid confusion that it's testing internal of private API.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f7eaed4b82ca184db6155afd743ac9cb4a4efb0

commit 4f7eaed4b82ca184db6155afd743ac9cb4a4efb0
Author: oka@chromium.org <oka@chromium.org>
Date: Thu Sep 21 05:45:10 2017

Rename VirtualKeyboardBrowserTest

It only tests the default IME chrome://keyboard, and every private APIs
are mocked.
This change renames it to DefaultKeyboardExtensionBrowserTest
to avoid confusion that it's testing internal of private API,
and also moves test files into a separate folder.

Also ran `git cl format --js`.

Bug:  755504 
Test: try
Change-Id: Ic80f8a4a580e381db83d5467ae78c8cd68574faa
Reviewed-on: https://chromium-review.googlesource.com/614827
Commit-Queue: Keigo Oka <oka@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503365}
[rename] https://crrev.com/4f7eaed4b82ca184db6155afd743ac9cb4a4efb0/chrome/browser/chromeos/extensions/default_keyboard_extension_browser_test.cc
[rename] https://crrev.com/4f7eaed4b82ca184db6155afd743ac9cb4a4efb0/chrome/browser/chromeos/extensions/default_keyboard_extension_browser_test.h
[modify] https://crrev.com/4f7eaed4b82ca184db6155afd743ac9cb4a4efb0/chrome/test/BUILD.gn
[rename] https://crrev.com/4f7eaed4b82ca184db6155afd743ac9cb4a4efb0/chrome/test/data/chromeos/virtual_keyboard/default_extension/end_to_end_test.html
[rename] https://crrev.com/4f7eaed4b82ca184db6155afd743ac9cb4a4efb0/chrome/test/data/chromeos/virtual_keyboard/default_extension/end_to_end_test.js
[rename] https://crrev.com/4f7eaed4b82ca184db6155afd743ac9cb4a4efb0/chrome/test/data/chromeos/virtual_keyboard/default_extension/hide_keyboard_key_test.js
[rename] https://crrev.com/4f7eaed4b82ca184db6155afd743ac9cb4a4efb0/chrome/test/data/chromeos/virtual_keyboard/default_extension/layout_test.js
[rename] https://crrev.com/4f7eaed4b82ca184db6155afd743ac9cb4a4efb0/chrome/test/data/chromeos/virtual_keyboard/default_extension/modifier_test.js
[rename] https://crrev.com/4f7eaed4b82ca184db6155afd743ac9cb4a4efb0/chrome/test/data/chromeos/virtual_keyboard/default_extension/typing_test.js
[rename] https://crrev.com/4f7eaed4b82ca184db6155afd743ac9cb4a4efb0/chrome/test/data/chromeos/virtual_keyboard/default_extension/virtual_keyboard_test_base.js

Comment 2 by oka@chromium.org, Sep 21 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment