VTTRegion id was recently re-introduced in the spec. Spec https://w3c.github.io/webvtt/#dom-vttregion-id Test https://github.com/w3c/web-platform-tests/pull/6885
submitted patch https://chromium-review.googlesource.com/#/c/chromium/src/+/700178
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b290cde60c5a9f0b39501762937feefb24a6d14a commit b290cde60c5a9f0b39501762937feefb24a6d14a Author: k2.nagaraju <k2.nagaraju@samsung.com> Date: Fri Oct 06 09:25:34 2017 Add support for WebVTT VTTRegion id Bug: 755487 Change-Id: I711a903200e0acef9deed18c03afee5843a33094 Reviewed-on: https://chromium-review.googlesource.com/700178 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#507015} [modify] https://crrev.com/b290cde60c5a9f0b39501762937feefb24a6d14a/AUTHORS [delete] https://crrev.com/1c0926bb2d1e6a2aedccfd7b351fc1a7106cfd88/third_party/WebKit/LayoutTests/external/wpt/webvtt/api/VTTRegion/id-expected.txt [modify] https://crrev.com/b290cde60c5a9f0b39501762937feefb24a6d14a/third_party/WebKit/LayoutTests/external/wpt/webvtt/api/interfaces-expected.txt [modify] https://crrev.com/b290cde60c5a9f0b39501762937feefb24a6d14a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/b290cde60c5a9f0b39501762937feefb24a6d14a/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp [modify] https://crrev.com/b290cde60c5a9f0b39501762937feefb24a6d14a/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp [modify] https://crrev.com/b290cde60c5a9f0b39501762937feefb24a6d14a/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.h [modify] https://crrev.com/b290cde60c5a9f0b39501762937feefb24a6d14a/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.idl
Also needs support for the newly introduced :cue-region(id) pseudo-class in the spec, see https://github.com/w3c/webvtt/issues/355
Need some info In VTTRegion.idl spec given as https://w3c.github.io/webvtt But in VTTRegion.cpp file spec given as https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/region.html Which spec need to follow for updating WebVTT support ?
The former (https://w3c.github.io/webvtt)
started working on REGION support for webVTT. WIP patch is submitted https://chromium-review.googlesource.com/c/chromium/src/+/787071
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a009af831ef36f0fc1e0d97e97cfded447d1e9d7 commit a009af831ef36f0fc1e0d97e97cfded447d1e9d7 Author: k2.nagaraju <k2.nagaraju@samsung.com> Date: Tue Dec 12 06:30:47 2017 Update parsing of WebVTT regions to current/latest spec updated parsing logic updated test cases and expected results Bug: 755487 Change-Id: Ia5d55a117f5f5fa7217e7671337fa4bc7fafbf41 Reviewed-on: https://chromium-review.googlesource.com/787071 Reviewed-by: Fredrik Söderquist <fs@opera.com> Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#523357} [add] https://crrev.com/a009af831ef36f0fc1e0d97e97cfded447d1e9d7/third_party/WebKit/LayoutTests/external/wpt/webvtt/parsing/file-parsing/tests/regions-edge-case.html [modify] https://crrev.com/a009af831ef36f0fc1e0d97e97cfded447d1e9d7/third_party/WebKit/LayoutTests/external/wpt/webvtt/parsing/file-parsing/tests/regions-lines-expected.txt [delete] https://crrev.com/bdd6381bda3548bbca99e1f030302f957ce2bcb6/third_party/WebKit/LayoutTests/external/wpt/webvtt/parsing/file-parsing/tests/regions-old-expected.txt [delete] https://crrev.com/bdd6381bda3548bbca99e1f030302f957ce2bcb6/third_party/WebKit/LayoutTests/external/wpt/webvtt/parsing/file-parsing/tests/regions-regionanchor-expected.txt [delete] https://crrev.com/bdd6381bda3548bbca99e1f030302f957ce2bcb6/third_party/WebKit/LayoutTests/external/wpt/webvtt/parsing/file-parsing/tests/regions-scroll-expected.txt [delete] https://crrev.com/bdd6381bda3548bbca99e1f030302f957ce2bcb6/third_party/WebKit/LayoutTests/external/wpt/webvtt/parsing/file-parsing/tests/regions-viewportanchor-expected.txt [delete] https://crrev.com/bdd6381bda3548bbca99e1f030302f957ce2bcb6/third_party/WebKit/LayoutTests/external/wpt/webvtt/parsing/file-parsing/tests/settings-region-expected.txt [add] https://crrev.com/a009af831ef36f0fc1e0d97e97cfded447d1e9d7/third_party/WebKit/LayoutTests/external/wpt/webvtt/parsing/file-parsing/tests/support/regions-edge-case.vtt [modify] https://crrev.com/a009af831ef36f0fc1e0d97e97cfded447d1e9d7/third_party/WebKit/LayoutTests/media/track/captions-webvtt/captions-regions.vtt [modify] https://crrev.com/a009af831ef36f0fc1e0d97e97cfded447d1e9d7/third_party/WebKit/LayoutTests/media/track/captions-webvtt/header-regions.vtt [modify] https://crrev.com/a009af831ef36f0fc1e0d97e97cfded447d1e9d7/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp [modify] https://crrev.com/a009af831ef36f0fc1e0d97e97cfded447d1e9d7/third_party/WebKit/Source/core/html/track/vtt/VTTParser.h [modify] https://crrev.com/a009af831ef36f0fc1e0d97e97cfded447d1e9d7/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp [modify] https://crrev.com/a009af831ef36f0fc1e0d97e97cfded447d1e9d7/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fb26fdd1ccb836c2f02e4dbf213afaed0a00e50 commit 2fb26fdd1ccb836c2f02e4dbf213afaed0a00e50 Author: k2.nagaraju <k2.nagaraju@samsung.com> Date: Thu Feb 01 06:09:26 2018 Update the region lines property to latest spec updated idl file and VTTScanner updated test cases and expected results https://w3c.github.io/webvtt/#dom-vttregion-lines https://github.com/w3c/webvtt/pull/423 Bug: 755487 Change-Id: Ifd1ef26ede8cbc4f6bfe817aae9bce1191c18d24 Reviewed-on: https://chromium-review.googlesource.com/826666 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#533586} [modify] https://crrev.com/2fb26fdd1ccb836c2f02e4dbf213afaed0a00e50/third_party/WebKit/LayoutTests/external/wpt/webvtt/api/VTTRegion/constructor.html [modify] https://crrev.com/2fb26fdd1ccb836c2f02e4dbf213afaed0a00e50/third_party/WebKit/LayoutTests/external/wpt/webvtt/api/VTTRegion/lines.html [modify] https://crrev.com/2fb26fdd1ccb836c2f02e4dbf213afaed0a00e50/third_party/WebKit/LayoutTests/external/wpt/webvtt/parsing/file-parsing/tests/regions-lines-expected.txt [modify] https://crrev.com/2fb26fdd1ccb836c2f02e4dbf213afaed0a00e50/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp [modify] https://crrev.com/2fb26fdd1ccb836c2f02e4dbf213afaed0a00e50/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp [modify] https://crrev.com/2fb26fdd1ccb836c2f02e4dbf213afaed0a00e50/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.h [modify] https://crrev.com/2fb26fdd1ccb836c2f02e4dbf213afaed0a00e50/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.idl [modify] https://crrev.com/2fb26fdd1ccb836c2f02e4dbf213afaed0a00e50/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.cpp [modify] https://crrev.com/2fb26fdd1ccb836c2f02e4dbf213afaed0a00e50/third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h [modify] https://crrev.com/2fb26fdd1ccb836c2f02e4dbf213afaed0a00e50/third_party/WebKit/Source/core/html/track/vtt/VTTScannerTest.cpp
Comment 1 by f...@opera.com
, Aug 15 2017