New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755478 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 619103



Sign in to add a comment

CHECK failure: false in PaintController.cpp

Project Member Reported by ClusterFuzz, Aug 15 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6146499355607040

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false in PaintController.cpp
  blink::PaintController::EndSubsequence
  blink::PaintLayerPainter::PaintLayerContents
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=419848:419971

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6146499355607040

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: msrchandra@chromium.org
Components: Blink>Paint
Labels: Test-Predator-Wrong-CLs M-62
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "PaintController.cpp" assigning to the concern owner from GIT Blame.

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/67161fd023615beeb90c01c878220b5485cd057c

@chrishtr -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Labels: BugSource-Chromium PaintTeamTriaged-20170816
Owner: schenney@chromium.org
Cc: chrishtr@chromium.org
Components: -Blink>Paint Blink>Paint>Invalidation
Labels: -Pri-1 -Stability-Crash -Stability-Memory-AddressSanitizer -M-62 Pri-2
Owner: wangxianzhu@chromium.org
Actual minimized case. This is an under-invalidation bug.

To reproduce, run content_hell --run-layout-test with the attached file.

There are no security or crash implications of this bug, so removed those labels.
clusterfuzz-testcase-minimized-6146499355607040.html
796 bytes View Download
Blocking: 619103
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb0f9dfbaeceba296cbc055b9dee797d902136e2

commit bb0f9dfbaeceba296cbc055b9dee797d902136e2
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Sep 12 02:49:42 2017

Fix false-positive of under-invalidation checking

If a subsequence was fully painted the last time, we don't repaint the
subsequence on interest rect change because the fully painted result is
still useable. However this triggers false-positive of under-
invalidation checking which strictly matches new and cached
subsequences.

Bug:  755478 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I24f8fa9c2e3167ff3c54954bf5e994a74ef70056
Reviewed-on: https://chromium-review.googlesource.com/661379
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501161}
[modify] https://crrev.com/bb0f9dfbaeceba296cbc055b9dee797d902136e2/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/bb0f9dfbaeceba296cbc055b9dee797d902136e2/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/bb0f9dfbaeceba296cbc055b9dee797d902136e2/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp
[modify] https://crrev.com/bb0f9dfbaeceba296cbc055b9dee797d902136e2/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/bb0f9dfbaeceba296cbc055b9dee797d902136e2/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/bb0f9dfbaeceba296cbc055b9dee797d902136e2/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 7 by ClusterFuzz, Sep 12 2017

ClusterFuzz has detected this issue as fixed in range 501156:501180.

Detailed report: https://clusterfuzz.com/testcase?key=6146499355607040

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false in PaintController.cpp
  blink::PaintController::EndSubsequence
  blink::PaintLayerPainter::PaintLayerContents
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=419848:419971
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=501156:501180

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6146499355607040

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Sep 12 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6146499355607040 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment