PaymentHandler: e.openWindow() should match up with the spec. |
||
Issue descriptionResolve with null instead of reject with 'SecurityError' if PaymentRequestEvent.openWindow is opened in a different origin The spec was changed. - https://github.com/w3c/payment-handler/pull/202
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48ccefb2c117c57376de3f91697672228445abad commit 48ccefb2c117c57376de3f91697672228445abad Author: gogerald <gogerald@google.com> Date: Tue Aug 15 16:45:03 2017 [Payments] Resolve with null if the openWindow origin is not the same as the service worker https://github.com/w3c/payment-handler/pull/202 Bug: 755474 Change-Id: Iee7df4e8f6cf54404be4e74ec2ab5e2401723ac8 Reviewed-on: https://chromium-review.googlesource.com/615362 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#494411} [modify] https://crrev.com/48ccefb2c117c57376de3f91697672228445abad/content/test/data/payments/payment_app.js [modify] https://crrev.com/48ccefb2c117c57376de3f91697672228445abad/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d92bb0a3d9eb07dd53a9ae263bdedb7dad601e7 commit 0d92bb0a3d9eb07dd53a9ae263bdedb7dad601e7 Author: Jinho Bang <jinho.bang@samsung.com> Date: Wed Aug 16 20:16:12 2017 PaymentHandler: openWindow() should return Promise<WindowClient?>. The PaymentHandler spec was changed[1]. its behavior was already fixed but missed IDL change[2]. [1] https://w3c.github.io/payment-handler/#openwindow()-method [2] https://chromium-review.googlesource.com/c/615362 Bug: 755474 Change-Id: I816471f89d7ec16d0c158aabd0c6838f74205f74 Reviewed-on: https://chromium-review.googlesource.com/616861 Reviewed-by: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#494920} [modify] https://crrev.com/0d92bb0a3d9eb07dd53a9ae263bdedb7dad601e7/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl
,
Nov 8 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by gogerald@chromium.org
, Aug 15 2017