New issue
Advanced search Search tips

Issue 755466 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: revise shopfloor & factory server retrieval

Project Member Reported by hungte@chromium.org, Aug 15 2017

Issue description

Discussed with stimim offline.

Previously we rely on test list to decide factory server (shopfloor server) URL, however many partners will need shopfloor server to be located per station (SMT/RunIn/FATP) so it becomes a problem for deciding shopfloor server - dirty hacks everywhere that even created shopfloor URL dict in test list options.

Also, shopfloor module tries to cache the shopfloor URL in shared data. This was because we designed in a way that when doing installation from mini-omaha, the URL to server will be cached, to simplify development process. However, this was known to not helpful today because (1) partners need server URL defined in test list because they have to deal with copy machines. (2) developers may want to run only toolkit, not through full installation process.

We think the ideal process is

 (1) Change shopfloor.py to use Runtime JSON Config, no more caches.
 (2) Write a new factory test to allow setting shopfloor server url (by writing to runtime config)
 

Comment 1 by hungte@chromium.org, Sep 21 2017

Owner: hungte@chromium.org
Status: Verified (was: Untriaged)
(1) is done by https://chromium-review.googlesource.com/642627
(2) is done by https://chromium-review.googlesource.com/616587

Sign in to add a comment