New issue
Advanced search Search tips

Issue 755462 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Task
Launch-Accessibility: NA
Launch-Legal: NA
Launch-M-Target: 63-Dev , 63-Beta , 63-Stable-Exp , 63-Stable
Launch-Privacy: NA
Launch-Security: NA
Launch-Test: NA
Launch-UI: NA



Sign in to add a comment

Support font-variant-east-asian

Project Member Reported by kojii@chromium.org, Aug 15 2017

Issue description

Change description:
Add support for font-variant-numeric and respective mapping from the font: CSS shorthand and into the font-variant: shorthand.

Changes to API surface:
Additional CSS property font-variant-east-asian

Links:
https://drafts.csswg.org/css-fonts-3/#font-variant-east-asian-prop

Chrome Platform Status feature dashboard:
https://www.chromestatus.com/features/4965040604053504

Support in other browsers:
Internet Explorer: No signal
Firefox: Shipped
Safari: Shipped

 

Comment 1 by kojii@chromium.org, Aug 15 2017

Description: Show this description

Comment 2 by kojii@chromium.org, Aug 15 2017

Cc: kojii@chromium.org
 Issue 712944  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc295adf69f0eb35eeb2453d6b4382f8238e1261

commit fc295adf69f0eb35eeb2453d6b4382f8238e1261
Author: Koji Ishii <kojii@chromium.org>
Date: Wed Sep 06 17:17:52 2017

Implement platform/fonts part of 'font-variant-east-asian'

This patch implements platform/fonts part of the CSS
'font-variant-east-asian' property.

The property is not exposed until CSS parser part is done in CL:651528.

Bug:  755462 
Change-Id: I9194f67b111aeb4dd15bf711a0d928937001631e
Reviewed-on: https://chromium-review.googlesource.com/652066
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499995}
[modify] https://crrev.com/fc295adf69f0eb35eeb2453d6b4382f8238e1261/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/fc295adf69f0eb35eeb2453d6b4382f8238e1261/third_party/WebKit/Source/platform/fonts/FontDescription.cpp
[modify] https://crrev.com/fc295adf69f0eb35eeb2453d6b4382f8238e1261/third_party/WebKit/Source/platform/fonts/FontDescription.h
[add] https://crrev.com/fc295adf69f0eb35eeb2453d6b4382f8238e1261/third_party/WebKit/Source/platform/fonts/FontVariantEastAsian.h
[modify] https://crrev.com/fc295adf69f0eb35eeb2453d6b4382f8238e1261/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e

commit 65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e
Author: Koji Ishii <kojii@chromium.org>
Date: Mon Sep 11 07:08:50 2017

Implement CSS parser for 'font-variant-east-asian'

This patch implements CSS parser for the 'font-variant-east-asian'
property.

All tests in wpt/css/css-fonts-3/font-variant-east-asian* pass.

The platform/fonts part is in CL:652066.

Intent to Ship in blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zNaJRd3tjw4/xmJH_M0MBQAJ

Bug:  755462 
Change-Id: I06f6df0a1eb95ebe4648b040ba7535a4498eebe3
Reviewed-on: https://chromium-review.googlesource.com/651528
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500852}
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/external/wpt/cssom/serialize-values-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/external/wpt/editing/run/removeformat-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/fast/css/font-property-priority-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/fast/css/font-shorthand-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/fast/css/font-variant-shorthand-from-longhands-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/fast/css/font-variant-shorthand-from-longhands.html
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/fast/inspector-support/style-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-properties-overload-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/LayoutTests/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/CSSValueKeywords.json5
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
[add] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/parser/FontVariantEastAsianParser.h
[add] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontVariantEastAsian.cpp
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFont.cpp
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/properties/CSSShorthandPropertyAPIFontVariant.cpp
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/resolver/CSSPropertyPriority.h
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/resolver/FontBuilder.h
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/platform/fonts/FontDescription.h
[modify] https://crrev.com/65138fc7bfffdf7f1be7ebb18e7fcb7bf776513e/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Comment 6 by owe...@chromium.org, Sep 12 2017

Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d506175364ea2af02b66e74f2a57eae922c41003

commit d506175364ea2af02b66e74f2a57eae922c41003
Author: Koji Ishii <kojii@chromium.org>
Date: Fri Sep 15 03:33:03 2017

DevTools: Add 'font-variant-east-asian' property to CSSMetadata.js

The syntax in the spec:
https://drafts.csswg.org/css-fonts-3/#font-variant-east-asian-prop

These values are added to the 'font-variant' shorthand property.
https://drafts.csswg.org/css-fonts-3/#font-variant-prop

Bug:  755462 
Change-Id: Ie5d612b4a1d861454e23b542176453b26e90364b
Reviewed-on: https://chromium-review.googlesource.com/662980
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502149}
[modify] https://crrev.com/d506175364ea2af02b66e74f2a57eae922c41003/third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js

Comment 8 by kojii@chromium.org, Sep 17 2017

Status: Fixed (was: Assigned)
Verified on Canary.

Comment 9 by kojii@chromium.org, Sep 17 2017

Description: Show this description

Comment 10 by kojii@chromium.org, Sep 17 2017

Updated Chrome Platform Status:
https://www.chromestatus.com/feature/4965040604053504
M63 stable launch is coming soon and this feature is targeted for M63 Stable, please have cross functional bits flipped ASAP. Thank you.
Labels: -Launch-Test-NotReviewed Launch-Test-NA
I don't think manual testing is needed, set Launch-Test to NA as advised from govind@.
Labels: -Launch-Privacy-NotReviewed -Launch-UI-NotReviewed -Launch-Security-NotReviewed -Launch-Legal-NotReviewed -Launch-Accessibility-NotReviewed Launch-Accessibility-NA Launch-Legal-NA Launch-Privacy-NA Launch-Security-NA Launch-UI-NA
Talked with govind@ and emilyschechter@, this doesn't need launch review.

Sign in to add a comment