New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755460 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Remove references to kDisableNewVirtualKeyboardBehavior

Project Member Reported by blakeo@chromium.org, Aug 15 2017

Issue description

This isn't used anywhere aside from old unittests, so it's safe to remove. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e41f4db2dc377e37413aa44a1b0e6a91b447058a

commit e41f4db2dc377e37413aa44a1b0e6a91b447058a
Author: Blake O'Hare <blakeo@chromium.org>
Date: Wed Sep 27 01:58:47 2017

Remove instances of adding "kDisableNewVirtualKeyboardBehavior" to unit tests

Bug:  755460 
Change-Id: I0809d668d971a5b9fde2136ca154dbac466cbb81
Reviewed-on: https://chromium-review.googlesource.com/615204
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504544}
[modify] https://crrev.com/e41f4db2dc377e37413aa44a1b0e6a91b447058a/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/e41f4db2dc377e37413aa44a1b0e6a91b447058a/ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc
[modify] https://crrev.com/e41f4db2dc377e37413aa44a1b0e6a91b447058a/ui/keyboard/keyboard_controller_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6340701d861ad75d5997137a6feee17b460b571

commit b6340701d861ad75d5997137a6feee17b460b571
Author: Blake O'Hare <blakeo@chromium.org>
Date: Fri Oct 06 06:25:24 2017

Remove usage of kDisableNewVirtualKeyboardBehavior

This is part II of The kDisableNewVirtualKeyboardBehavior Removal
Trilogy.

Part I: Unit tests [DONE!]
Part II: Remove usage [this CL]
Part III: Removal of the flag definition [Fall 2017]

Bug:  755460 
Change-Id: I17dee62334c1687d6647ea62d1eadf210b0f8e5a
Reviewed-on: https://chromium-review.googlesource.com/686027
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506995}
[modify] https://crrev.com/b6340701d861ad75d5997137a6feee17b460b571/ash/BUILD.gn
[modify] https://crrev.com/b6340701d861ad75d5997137a6feee17b460b571/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/b6340701d861ad75d5997137a6feee17b460b571/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/b6340701d861ad75d5997137a6feee17b460b571/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/b6340701d861ad75d5997137a6feee17b460b571/ui/keyboard/keyboard_ui.cc
[modify] https://crrev.com/b6340701d861ad75d5997137a6feee17b460b571/ui/keyboard/keyboard_util.cc
[modify] https://crrev.com/b6340701d861ad75d5997137a6feee17b460b571/ui/wm/core/ime_util_chromeos.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e030df093ba0a97870f022b7f185e856eaa34b47

commit e030df093ba0a97870f022b7f185e856eaa34b47
Author: Blake O'Hare <blakeo@chromium.org>
Date: Mon Oct 16 03:10:48 2017

Remove the kDisableNewVirtualKeyboardBehavior flag definition.

The last references to this flag were removed in:
crrev.com/c/686027

There is notably still a reference to the
disable-new-virtual-keyboard-behavior flag in
tools/metrics/histograms/enums.xml which should not be removed.


Bug:  755460 
Change-Id: I5d63f5fdde1884527baded293110c681d8869371
Reviewed-on: https://chromium-review.googlesource.com/718156
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508976}
[modify] https://crrev.com/e030df093ba0a97870f022b7f185e856eaa34b47/chrome/browser/about_flags.cc
[modify] https://crrev.com/e030df093ba0a97870f022b7f185e856eaa34b47/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/e030df093ba0a97870f022b7f185e856eaa34b47/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/e030df093ba0a97870f022b7f185e856eaa34b47/ui/base/ui_base_switches.cc
[modify] https://crrev.com/e030df093ba0a97870f022b7f185e856eaa34b47/ui/base/ui_base_switches.h

Comment 4 by blakeo@chromium.org, Oct 16 2017

Status: Fixed (was: Assigned)

Sign in to add a comment