New issue
Advanced search Search tips

Issue 755416 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ChromeOS Gaia screen: fix support for dialogShown/Hidden messages for GLIF MM.

Project Member Reported by alemate@chromium.org, Aug 15 2017

Issue description

Support for dialogShown/dialogHidden messages was aparently missing in GLIF MM
support on ChromeOS. This CL implements disabling Gaia screen controls
when dialog is shown.

(see b/64684270 )

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0cabc438f627623dd131666ddc74e7a1a7bc4b4

commit f0cabc438f627623dd131666ddc74e7a1a7bc4b4
Author: Alexander Alekseev <alemate@chromium.org>
Date: Tue Aug 15 03:18:58 2017

ChromeOS Gaia screen: fix support for dialogShown/Hidden messages for GLIF MM.

Support for dialogShown/dialogHidden messages was aparently missing in GLIF MM
support on ChromeOS. This CL implements disabling Gaia screen controls
when dialog is shown.

Bug: b/64684270, chromium:755416
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I46ba8b4e044c4d840d422c175b5ddb044e39e950
Reviewed-on: https://chromium-review.googlesource.com/615004
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494315}
[modify] https://crrev.com/f0cabc438f627623dd131666ddc74e7a1a7bc4b4/chrome/browser/resources/chromeos/login/screen_gaia_signin.css
[modify] https://crrev.com/f0cabc438f627623dd131666ddc74e7a1a7bc4b4/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/f0cabc438f627623dd131666ddc74e7a1a7bc4b4/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Labels: Merge-Request-61
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 16 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/426f7f3f2eec769c159142df76b728429a2efbb2

commit 426f7f3f2eec769c159142df76b728429a2efbb2
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 16 22:43:37 2017

ChromeOS Gaia screen: fix support for dialogShown/Hidden messages for GLIF MM.

Support for dialogShown/dialogHidden messages was aparently missing in GLIF MM
support on ChromeOS. This CL implements disabling Gaia screen controls
when dialog is shown.

TBR=alemate@chromium.org

(cherry picked from commit f0cabc438f627623dd131666ddc74e7a1a7bc4b4)

Bug: b/64684270, chromium:755416
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I46ba8b4e044c4d840d422c175b5ddb044e39e950
Reviewed-on: https://chromium-review.googlesource.com/615004
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#494315}
Reviewed-on: https://chromium-review.googlesource.com/617908
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#611}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/426f7f3f2eec769c159142df76b728429a2efbb2/chrome/browser/resources/chromeos/login/screen_gaia_signin.css
[modify] https://crrev.com/426f7f3f2eec769c159142df76b728429a2efbb2/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/426f7f3f2eec769c159142df76b728429a2efbb2/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment