New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755413 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 797128
issue 763426
issue 776205

Blocking:
issue 578868



Sign in to add a comment

refactor message center

Project Member Reported by est...@chromium.org, Aug 15 2017

Issue description

Message center code is spread across ash/system/, ui/message_center/, chrome/browser/ui/views/message_center, and chrome/browser/ui/cocoa/notifications. It seems a lot of the structure is obsolete and can be simplified or moved to new locations, which will be a helpful precursor to mojofication.
 
Cc: xiy...@chromium.org
Steven & Xiyuan, do you know if there are features under development for M61 that touch the message center?

I'm not aware of any, but I don't review code in that directory very often.

Comment 2 by est...@chromium.org, Aug 15 2017

Cc: yoshiki@chromium.org
there is active work to MD-ify the notifications but I believe that is pretty limited in scope (just touches NotificationView[MD] essentially).

Comment 3 by peter@chromium.org, Aug 15 2017

Cc: peter@chromium.org awdf@chromium.org
The Cocoa implementation will be removed in the next month or so.

It would be good to understand what direction you'd like to take it in. We want to create a more generic Notification service that also has the ability to defer to system notification centers on other platforms. (We'll continue using the message center on Windows and Linux for the foreseeable future.)

Specific to the message center, it would be interesting to figure out an appropriate API for Chrome OS vs. the other platforms, given that it's way more capable on the former.
If the MD-ify work is being backported it might be nice not to move that file, or to do it in a safe way that can also be backported.

Re: an interface for notifications, I see the ARC guys have added one, presumably to support Android notifications showing up on the Chrome OS side of the fence:

https://cs.chromium.org/chromium/src/components/arc/common/notifications.mojom?q=notification.*mojom&sq=package:chromium&dr


Comment 5 by est...@chromium.org, Aug 15 2017

re #3: right now my only real plan is to start removing unnecessary dependencies and moving code to where it's used/needed so that it will be clearer what might be exposed via mojo vs. what can go in a public/cpp directory.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cf7882c119abbde76e58371f67991b760d9b4e2

commit 9cf7882c119abbde76e58371f67991b760d9b4e2
Author: Evan Stade <estade@chromium.org>
Date: Wed Aug 16 18:32:13 2017

Merge MessageBubbleBase and MessageCenterBubble

MessageCenterBubble is the only inheritor of MessageBubbleBase. It's
only used in ash, so only build it for ash. For cleaner code
modification history, don't yet move it to the ash/ directory (that will
be a follow-up).

Bug:  755413 ,585175
Change-Id: I41cc9c1039a1cd980668eb76ff355babe4551214
Reviewed-on: https://chromium-review.googlesource.com/615025
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494874}
[modify] https://crrev.com/9cf7882c119abbde76e58371f67991b760d9b4e2/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/9cf7882c119abbde76e58371f67991b760d9b4e2/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/9cf7882c119abbde76e58371f67991b760d9b4e2/ui/message_center/BUILD.gn
[delete] https://crrev.com/960b992576af4ded24dd6b572f907496e44f2a04/ui/message_center/views/message_bubble_base.cc
[delete] https://crrev.com/960b992576af4ded24dd6b572f907496e44f2a04/ui/message_center/views/message_bubble_base.h
[modify] https://crrev.com/9cf7882c119abbde76e58371f67991b760d9b4e2/ui/message_center/views/message_center_bubble.cc
[modify] https://crrev.com/9cf7882c119abbde76e58371f67991b760d9b4e2/ui/message_center/views/message_center_bubble.h
[modify] https://crrev.com/9cf7882c119abbde76e58371f67991b760d9b4e2/ui/message_center/views/notifier_settings_view.h

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80

commit 2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80
Author: Evan Stade <estade@chromium.org>
Date: Fri Aug 18 23:38:06 2017

Move MessageCenterBubble into ash/.

Also move CreateMessageCenterTray into chrome/ (only place it's used).

Bug:  755413 
Change-Id: I6def4206eb749c1ab868790510dc15f5c950c59f
Reviewed-on: https://chromium-review.googlesource.com/617807
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495746}
[modify] https://crrev.com/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80/ash/BUILD.gn
[rename] https://crrev.com/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80/ash/system/web_notification/message_center_bubble.cc
[rename] https://crrev.com/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80/ash/system/web_notification/message_center_bubble.h
[modify] https://crrev.com/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80/chrome/browser/notifications/message_center_notification_manager.cc
[modify] https://crrev.com/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80/chrome/browser/notifications/message_center_notification_manager.h
[modify] https://crrev.com/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.mm
[modify] https://crrev.com/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80/chrome/browser/ui/views/message_center/web_notification_tray.cc
[modify] https://crrev.com/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80/chrome/browser/ui/views/message_center/web_notification_tray.h
[modify] https://crrev.com/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80/ui/message_center/BUILD.gn
[modify] https://crrev.com/2b9cc98867ac7f3a4e8baf76e94fe3a899c10c80/ui/message_center/message_center_tray.h

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d07c42aed35bc2b2b64af43cbf7f19a4336e2ef

commit 4d07c42aed35bc2b2b64af43cbf7f19a4336e2ef
Author: Evan Stade <estade@chromium.org>
Date: Fri Sep 01 21:51:51 2017

Split ash code out of FullscreenNotificationBlocker and move it to ash/.

Bug:  755413 
Change-Id: Ib5c20eb105a570104ae485dcd8b66011c208fbe0
Reviewed-on: https://chromium-review.googlesource.com/641772
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499319}
[modify] https://crrev.com/4d07c42aed35bc2b2b64af43cbf7f19a4336e2ef/ash/BUILD.gn
[modify] https://crrev.com/4d07c42aed35bc2b2b64af43cbf7f19a4336e2ef/ash/shell.cc
[add] https://crrev.com/4d07c42aed35bc2b2b64af43cbf7f19a4336e2ef/ash/system/web_notification/fullscreen_notification_blocker.cc
[add] https://crrev.com/4d07c42aed35bc2b2b64af43cbf7f19a4336e2ef/ash/system/web_notification/fullscreen_notification_blocker.h
[modify] https://crrev.com/4d07c42aed35bc2b2b64af43cbf7f19a4336e2ef/ash/system/web_notification/message_center_controller.cc
[modify] https://crrev.com/4d07c42aed35bc2b2b64af43cbf7f19a4336e2ef/ash/system/web_notification/message_center_controller.h
[modify] https://crrev.com/4d07c42aed35bc2b2b64af43cbf7f19a4336e2ef/chrome/browser/BUILD.gn
[modify] https://crrev.com/4d07c42aed35bc2b2b64af43cbf7f19a4336e2ef/chrome/browser/notifications/fullscreen_notification_blocker.cc
[modify] https://crrev.com/4d07c42aed35bc2b2b64af43cbf7f19a4336e2ef/chrome/browser/notifications/fullscreen_notification_blocker.h
[modify] https://crrev.com/4d07c42aed35bc2b2b64af43cbf7f19a4336e2ef/chrome/browser/notifications/message_center_notification_manager.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a3d37bd11074f6299fa652e5959d0b9bfba7993

commit 2a3d37bd11074f6299fa652e5959d0b9bfba7993
Author: Evan Stade <estade@chromium.org>
Date: Thu Sep 07 18:37:26 2017

Remove message center notification change queue.

This code has been dead for 2 years since kMessageCenterChangesWhileOpen
was switched to enabled by default.

Bug:  372422 , 755413 
Change-Id: Ib165143736174b3aeabc9cdeb1bf9c6b9cf55aea
Reviewed-on: https://chromium-review.googlesource.com/653587
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500339}
[modify] https://crrev.com/2a3d37bd11074f6299fa652e5959d0b9bfba7993/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/2a3d37bd11074f6299fa652e5959d0b9bfba7993/chrome/browser/download/notification/download_notification.cc
[modify] https://crrev.com/2a3d37bd11074f6299fa652e5959d0b9bfba7993/chrome/browser/download/notification/download_notification.h
[modify] https://crrev.com/2a3d37bd11074f6299fa652e5959d0b9bfba7993/chrome/browser/notifications/message_center_notifications_browsertest.cc
[modify] https://crrev.com/2a3d37bd11074f6299fa652e5959d0b9bfba7993/ui/message_center/fake_message_center.cc
[modify] https://crrev.com/2a3d37bd11074f6299fa652e5959d0b9bfba7993/ui/message_center/fake_message_center.h
[modify] https://crrev.com/2a3d37bd11074f6299fa652e5959d0b9bfba7993/ui/message_center/message_center.h
[modify] https://crrev.com/2a3d37bd11074f6299fa652e5959d0b9bfba7993/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/2a3d37bd11074f6299fa652e5959d0b9bfba7993/ui/message_center/message_center_impl.h
[modify] https://crrev.com/2a3d37bd11074f6299fa652e5959d0b9bfba7993/ui/message_center/message_center_impl_unittest.cc
[modify] https://crrev.com/2a3d37bd11074f6299fa652e5959d0b9bfba7993/ui/message_center/message_center_switches.cc
[modify] https://crrev.com/2a3d37bd11074f6299fa652e5959d0b9bfba7993/ui/message_center/message_center_switches.h
[modify] https://crrev.com/2a3d37bd11074f6299fa652e5959d0b9bfba7993/ui/message_center/message_center_tray_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f

commit 353058c9a5e2ac98097b76a1a1e22a4db63e0d0f
Author: Evan Stade <estade@chromium.org>
Date: Fri Sep 08 21:31:13 2017

Create public cpp directory for Message Center, move constants and flags
there.

Bug:  755413 
Change-Id: I8d804a160e33b8667942aa723e031beb3d67bf8e
Reviewed-on: https://chromium-review.googlesource.com/651568
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500688}
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ash/BUILD.gn
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ash/system/system_notifier.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ash/system/system_notifier.h
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ash/system/tray/system_tray.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ash/system/tray_accessibility.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ash/system/tray_caps_lock.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ash/system/web_notification/ash_popup_alignment_delegate.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ash/system/web_notification/message_center_bubble.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/BUILD.gn
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/about_flags.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/chromeos/eol_notification.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/chromeos/hats/hats_notification_controller.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/chromeos/printing/cups_print_job_notification.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/extensions/api/notifications/notifications_api.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/notifications/message_center_notification_manager.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/notifications/message_center_notifications_browsertest.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/notifications/message_center_settings_controller.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/notifications/notification_interactive_uitest.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/signin/signin_error_notifier_ash.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/ui/extensions/extension_installed_notification.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/ui/views/message_center/message_center_frame_view.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/common/BUILD.gn
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/chrome/common/extensions/api/notifications/notification_style.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/arc/BUILD.gn
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/arc/notification/arc_notification_content_view.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/arc/notification/arc_notification_item_impl.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/arc/notification/arc_notification_view.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/BUILD.gn
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/cocoa/notification_controller.mm
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/cocoa/notification_controller_unittest.mm
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/cocoa/popup_collection.mm
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/cocoa/popup_collection_unittest.mm
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/message_center.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/message_center.h
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/message_center_impl_unittest.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/message_center_style.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/message_center_style.h
[delete] https://crrev.com/b30f7c7ec99855d695a06c2c55651c8f03e941e4/ui/message_center/message_center_switches.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/notification.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/notification_list.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/notification_list_unittest.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/popup_timers_controller.cc
[add] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/public/cpp/BUILD.gn
[add] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/public/cpp/message_center_constants.h
[add] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/public/cpp/message_center_public_export.h
[add] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/public/cpp/message_center_switches.cc
[add] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/public/cpp/message_center_switches.h
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/constants.h
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/desktop_popup_alignment_delegate.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/message_center_button_bar.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/message_center_view.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/message_center_view_unittest.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/message_list_view.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/message_popup_collection.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/message_popup_collection_unittest.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/message_view.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/message_view_factory.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/notification_button.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/notification_control_buttons_view.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/notification_header_view.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/notification_header_view.h
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/notification_view.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/notification_view_md_unittest.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/notifier_settings_view.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/padded_button.cc
[modify] https://crrev.com/353058c9a5e2ac98097b76a1a1e22a4db63e0d0f/ui/message_center/views/toast_contents_view.cc

Blockedon: 763426
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/844ad7f86cf81bd601adbf597664d4f1255ac6ef

commit 844ad7f86cf81bd601adbf597664d4f1255ac6ef
Author: Evan Stade <estade@chromium.org>
Date: Wed Sep 20 18:05:31 2017

Message center notifier / settings cleanup.

- enable/disable notifiers by NotifierId rather than Notifier. Add notes
  to rename these classes: NotifierId is a source of notifications, and
  Notifier is a NotifierId plus UI-specific information.
- use URL, not display name, to track web page notifiers. URL and
  display name are the same for these notifiers anyway (and may not be
  valid URLs, e.g. may contain wildcards).
- Fix a typo in a class name.

Bug:  755413 
Change-Id: I67dc1f4606dffd19f894445ffc124e2162843b71
Reviewed-on: https://chromium-review.googlesource.com/674026
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503195}
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/chrome/browser/notifications/application_notifier_source.cc
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/chrome/browser/notifications/application_notifier_source.h
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/chrome/browser/notifications/arc_application_notifier_source_chromeos.cc
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/chrome/browser/notifications/arc_application_notifier_source_chromeos.h
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/chrome/browser/notifications/message_center_settings_controller.cc
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/chrome/browser/notifications/message_center_settings_controller.h
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/chrome/browser/notifications/message_center_settings_controller_unittest.cc
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/chrome/browser/notifications/notifier_source.h
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/chrome/browser/notifications/system_component_notifier_source_chromeos.cc
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/chrome/browser/notifications/system_component_notifier_source_chromeos.h
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/chrome/browser/notifications/web_page_notifier_source.cc
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/chrome/browser/notifications/web_page_notifier_source.h
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/ui/message_center/notifier_settings.h
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/ui/message_center/views/notifier_settings_view.cc
[modify] https://crrev.com/844ad7f86cf81bd601adbf597664d4f1255ac6ef/ui/message_center/views/notifier_settings_view_unittest.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecc7e745ff9363cee143bda36a41b50a81cbc5a8

commit ecc7e745ff9363cee143bda36a41b50a81cbc5a8
Author: Evan Stade <estade@chromium.org>
Date: Fri Sep 22 20:36:22 2017

MessageCenterSettingsController: Don't observe profile related notifications

In this case, "notification" is referring to the kind found in
content/public/browser/, i.e. NotificationService notifications, not the user
visible notifications managed by the message center.

As far as I can tell, this has been redundant with ProfileInfoCache/
ProfileAttributesStorage observerhood since 75ca0190e37b841400182d657d44ee07.

BUG=268984, 755413 

Change-Id: I68bf45695d3cb3e15e46991435825b243572839f
Reviewed-on: https://chromium-review.googlesource.com/676259
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503840}
[modify] https://crrev.com/ecc7e745ff9363cee143bda36a41b50a81cbc5a8/chrome/browser/notifications/message_center_settings_controller.cc
[modify] https://crrev.com/ecc7e745ff9363cee143bda36a41b50a81cbc5a8/chrome/browser/notifications/message_center_settings_controller.h

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744

commit 69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744
Author: Evan Stade <estade@chromium.org>
Date: Fri Sep 22 21:44:08 2017

Move some message center views from ui/message_center to ash/.

These are some classes that are only used in the message center (not in
standalone notifications). Thus they're only used in ash/, even though
we've been compiling them on all platforms.

There are probably more classes than can move and certainly some
constants as well; this is just a first step.

Bug: 585175,  755413 
Change-Id: Ib5a2e41880fbc8389c54419f6a36533399f2847a
Reviewed-on: https://chromium-review.googlesource.com/676466
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503864}
[modify] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/BUILD.gn
[modify] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/ash_strings.grd
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/message_center_bubble.cc
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/message_center_bubble.h
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/message_center_button_bar.cc
[add] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/message_center_button_bar.h
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/message_center_controller.cc
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/message_center_controller.h
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/message_center_view.cc
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/message_center_view.h
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/message_center_view_unittest.cc
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/message_list_view.cc
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/message_list_view.h
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/message_list_view_unittest.cc
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/notifier_settings_view.cc
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/notifier_settings_view.h
[rename] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/message_center/notifier_settings_view_unittest.cc
[modify] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/shell.cc
[modify] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ui/message_center/BUILD.gn
[modify] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ui/message_center/public/cpp/message_center_constants.h
[delete] https://crrev.com/2bdb98f2d1fb748e13dfc5d1782f0b495d0fd1ac/ui/message_center/views/message_center_button_bar.h
[modify] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ui/message_center/views/message_view_context_menu_controller.h
[delete] https://crrev.com/2bdb98f2d1fb748e13dfc5d1782f0b495d0fd1ac/ui/resources/default_100_percent/common/notification_bubble_close.png
[delete] https://crrev.com/2bdb98f2d1fb748e13dfc5d1782f0b495d0fd1ac/ui/resources/default_100_percent/common/notification_bubble_close_hover.png
[delete] https://crrev.com/2bdb98f2d1fb748e13dfc5d1782f0b495d0fd1ac/ui/resources/default_100_percent/common/notification_bubble_close_pressed.png
[delete] https://crrev.com/2bdb98f2d1fb748e13dfc5d1782f0b495d0fd1ac/ui/resources/default_200_percent/common/notification_bubble_close.png
[delete] https://crrev.com/2bdb98f2d1fb748e13dfc5d1782f0b495d0fd1ac/ui/resources/default_200_percent/common/notification_bubble_close_hover.png
[delete] https://crrev.com/2bdb98f2d1fb748e13dfc5d1782f0b495d0fd1ac/ui/resources/default_200_percent/common/notification_bubble_close_pressed.png
[modify] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ui/resources/ui_resources.grd
[modify] https://crrev.com/69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744/ui/strings/ui_strings.grd

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77183bf34f6d571dac9298d24bac4410f098217c

commit 77183bf34f6d571dac9298d24bac4410f098217c
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Sep 22 22:23:13 2017

Revert "Move some message center views from ui/message_center to ash/."

This reverts commit 69b1a3dd0c9f3fbff1430d57e90cf3f61c5aa744.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 503864 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzY5YjFhM2RkMGM5ZjNmYmZmMTQzMGQ1N2U5MGNmM2Y2MWM1YWE3NDQM

Sample Failed Build: https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Builder%20%28dbg%29/92258

Original change's description:
> Move some message center views from ui/message_center to ash/.
> 
> These are some classes that are only used in the message center (not in
> standalone notifications). Thus they're only used in ash/, even though
> we've been compiling them on all platforms.
> 
> There are probably more classes than can move and certainly some
> constants as well; this is just a first step.
> 
> Bug: 585175,  755413 
> Change-Id: Ib5a2e41880fbc8389c54419f6a36533399f2847a
> Reviewed-on: https://chromium-review.googlesource.com/676466
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503864}

Change-Id: I8fbdacb01d7bd448e0ad03bcd06ec5ffc3e29852
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 585175,  755413 
Reviewed-on: https://chromium-review.googlesource.com/679237
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503872}
[modify] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ash/BUILD.gn
[modify] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ash/ash_strings.grd
[delete] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/message_center/message_center_button_bar.h
[modify] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ash/shell.cc
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ash/system/web_notification/message_center_bubble.cc
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ash/system/web_notification/message_center_bubble.h
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ash/system/web_notification/message_center_controller.cc
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ash/system/web_notification/message_center_controller.h
[modify] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/BUILD.gn
[modify] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/public/cpp/message_center_constants.h
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/views/message_center_button_bar.cc
[add] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/views/message_center_button_bar.h
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/views/message_center_view.cc
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/views/message_center_view.h
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/views/message_center_view_unittest.cc
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/views/message_list_view.cc
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/views/message_list_view.h
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/views/message_list_view_unittest.cc
[modify] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/views/message_view_context_menu_controller.h
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/views/notifier_settings_view.cc
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/views/notifier_settings_view.h
[rename] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/message_center/views/notifier_settings_view_unittest.cc
[add] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/resources/default_100_percent/common/notification_bubble_close.png
[add] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/resources/default_100_percent/common/notification_bubble_close_hover.png
[add] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/resources/default_100_percent/common/notification_bubble_close_pressed.png
[add] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/resources/default_200_percent/common/notification_bubble_close.png
[add] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/resources/default_200_percent/common/notification_bubble_close_hover.png
[add] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/resources/default_200_percent/common/notification_bubble_close_pressed.png
[modify] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/resources/ui_resources.grd
[modify] https://crrev.com/77183bf34f6d571dac9298d24bac4410f098217c/ui/strings/ui_strings.grd

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158

commit e9974e2cd7d88cd7ba1bf40d5f57b169b146b158
Author: Evan Stade <estade@chromium.org>
Date: Sat Sep 23 00:02:26 2017

Reland 69b1a3dd0c9f3fbff: Move some message center views...
Move some message center views from ui/message_center to ash/.

These are some classes that are only used in the message center (not in
standalone notifications). Thus they're only used in ash/, even though
we've been compiling them on all platforms.

There are probably more classes than can move and certainly some
constants as well; this is just a first step.

TBR=jamescook@chromium.org,stevenjb@chromium.org,oshima@chromium.org

Bug: 585175,  755413 
Change-Id: I3a47b69c31061d92d98b4d880708c50688c415f9
Reviewed-on: https://chromium-review.googlesource.com/679486
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503912}
[modify] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/BUILD.gn
[modify] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/ash_strings.grd
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/message_center_bubble.cc
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/message_center_bubble.h
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/message_center_button_bar.cc
[add] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/message_center_button_bar.h
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/message_center_controller.cc
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/message_center_controller.h
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/message_center_view.cc
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/message_center_view.h
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/message_center_view_unittest.cc
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/message_list_view.cc
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/message_list_view.h
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/message_list_view_unittest.cc
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/notifier_settings_view.cc
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/notifier_settings_view.h
[rename] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/message_center/notifier_settings_view_unittest.cc
[modify] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/shell.cc
[modify] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ui/message_center/BUILD.gn
[modify] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ui/message_center/public/cpp/message_center_constants.h
[delete] https://crrev.com/6a151e60dad836ffa604f07449238de43a774433/ui/message_center/views/message_center_button_bar.h
[modify] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ui/message_center/views/message_view_context_menu_controller.h
[delete] https://crrev.com/6a151e60dad836ffa604f07449238de43a774433/ui/resources/default_100_percent/common/notification_bubble_close.png
[delete] https://crrev.com/6a151e60dad836ffa604f07449238de43a774433/ui/resources/default_100_percent/common/notification_bubble_close_hover.png
[delete] https://crrev.com/6a151e60dad836ffa604f07449238de43a774433/ui/resources/default_100_percent/common/notification_bubble_close_pressed.png
[delete] https://crrev.com/6a151e60dad836ffa604f07449238de43a774433/ui/resources/default_200_percent/common/notification_bubble_close.png
[delete] https://crrev.com/6a151e60dad836ffa604f07449238de43a774433/ui/resources/default_200_percent/common/notification_bubble_close_hover.png
[delete] https://crrev.com/6a151e60dad836ffa604f07449238de43a774433/ui/resources/default_200_percent/common/notification_bubble_close_pressed.png
[modify] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ui/resources/ui_resources.grd
[modify] https://crrev.com/e9974e2cd7d88cd7ba1bf40d5f57b169b146b158/ui/strings/ui_strings.grd

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc63b18681d5cff7eb15d0beb418f0e125d4549d

commit cc63b18681d5cff7eb15d0beb418f0e125d4549d
Author: Evan Stade <estade@chromium.org>
Date: Tue Sep 26 16:05:12 2017

Switch EolNotification from direct use of MessageCenter to
NotificationDisplayService.

Allow notification sources, like EolNotification, to register their
custom handlers with NotificationDisplayService.

Bug:  578868 , 755413 
Change-Id: Ie7c4464c174625dc4de4c8e5f3053a47659e6d66
Reviewed-on: https://chromium-review.googlesource.com/648474
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504381}
[modify] https://crrev.com/cc63b18681d5cff7eb15d0beb418f0e125d4549d/chrome/browser/BUILD.gn
[modify] https://crrev.com/cc63b18681d5cff7eb15d0beb418f0e125d4549d/chrome/browser/chromeos/eol_notification.cc
[modify] https://crrev.com/cc63b18681d5cff7eb15d0beb418f0e125d4549d/chrome/browser/notifications/message_center_display_service.cc
[modify] https://crrev.com/cc63b18681d5cff7eb15d0beb418f0e125d4549d/chrome/browser/notifications/notification_common.h
[modify] https://crrev.com/cc63b18681d5cff7eb15d0beb418f0e125d4549d/chrome/browser/notifications/notification_display_service.cc
[modify] https://crrev.com/cc63b18681d5cff7eb15d0beb418f0e125d4549d/chrome/browser/notifications/notification_display_service.h
[add] https://crrev.com/cc63b18681d5cff7eb15d0beb418f0e125d4549d/chrome/browser/notifications/notification_handler.cc
[modify] https://crrev.com/cc63b18681d5cff7eb15d0beb418f0e125d4549d/chrome/browser/notifications/notification_handler.h

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6d837f513eec8a60b4652ece033bda8e4413e53

commit d6d837f513eec8a60b4652ece033bda8e4413e53
Author: Evan Stade <estade@chromium.org>
Date: Fri Sep 29 02:51:02 2017

NotifierSource cleanup.

- Remove unused function NotifierSource::GetNotifierType
- Rename NotifierSource to NotifierController
- Add docs

Bug:  755413 
Change-Id: Ib214b452548c348661569fe4496a06e67004809e
Reviewed-on: https://chromium-review.googlesource.com/682108
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505266}
[modify] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/chrome/browser/BUILD.gn
[delete] https://crrev.com/4731f0a33247230fc9ef47a6a08ed362d24d3691/chrome/browser/notifications/application_notifier_source.h
[rename] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/chrome/browser/notifications/arc_application_notifier_controller_chromeos.cc
[rename] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/chrome/browser/notifications/arc_application_notifier_controller_chromeos.h
[rename] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/chrome/browser/notifications/extension_notifier_controller.cc
[add] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/chrome/browser/notifications/extension_notifier_controller.h
[modify] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/chrome/browser/notifications/message_center_settings_controller.cc
[modify] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/chrome/browser/notifications/message_center_settings_controller.h
[rename] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/chrome/browser/notifications/notifier_controller.h
[rename] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/chrome/browser/notifications/system_component_notifier_controller_chromeos.cc
[add] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/chrome/browser/notifications/system_component_notifier_controller_chromeos.h
[delete] https://crrev.com/4731f0a33247230fc9ef47a6a08ed362d24d3691/chrome/browser/notifications/system_component_notifier_source_chromeos.h
[rename] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/chrome/browser/notifications/web_page_notifier_controller.cc
[rename] https://crrev.com/d6d837f513eec8a60b4652ece033bda8e4413e53/chrome/browser/notifications/web_page_notifier_controller.h

Cc: tetsui@chromium.org
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bf465e5263df4edd0dce43189ea47ff66496a07

commit 0bf465e5263df4edd0dce43189ea47ff66496a07
Author: Evan Stade <estade@chromium.org>
Date: Tue Oct 03 18:12:00 2017

Migrate download notifications to use of NotificationDisplayService.

The less mechanical changes:
- Expand PassThroughDelegate a little bit.
- Flip the default for RichNotificationData.clickable to false. This
  bit just (partially) controls whether we display a hand cursor or
  a normal cursor. Making it default to false matches
  NotificationDelegate, which defaults HasClickedHandler to false.
- To make sure download notification re-pop-up (e.g. upon completion,
  after the notification was stuffed into the non-toast message center),
  adjust the notification's priority. This is necessary because we can
  no longer easily distinguish between showing as toast and showing in
  center.

TBR=benwells@chromium.org

Bug:  578868 , 755413 
Change-Id: Ib1566197e5c1d2618927a975af1ab14d200de9f5
Reviewed-on: https://chromium-review.googlesource.com/688455
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506105}
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/chromeos/arc/notification/arc_provision_notification_service.cc
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/download/notification/download_item_notification.h
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/download/notification/download_item_notification_unittest.cc
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/download/notification/download_notification_browsertest.cc
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/download/notification/download_notification_manager.cc
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/download/notification/download_notification_manager.h
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/extensions/api/file_system/request_file_system_notification.cc
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/notifications/message_center_display_service.cc
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/notifications/message_center_display_service.h
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/notifications/native_notification_display_service.cc
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/notifications/notification_common.h
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/notifications/notification_display_service.cc
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/notifications/notification_display_service.h
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/notifications/notification_display_service_factory.cc
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/ui/message_center/notification.h
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/ui/message_center/views/notification_view.cc
[modify] https://crrev.com/0bf465e5263df4edd0dce43189ea47ff66496a07/ui/message_center/views/notification_view_md.cc

Blockedon: 776205
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feec2d11be84d01ba3456a684a484d01a8ac0780

commit feec2d11be84d01ba3456a684a484d01a8ac0780
Author: Evan Stade <estade@chromium.org>
Date: Thu Oct 19 03:24:53 2017

Remove NotifierGroup.

{Profile}NotifierGroup had one purpose, which was to separate
notification settings from different profiles on Win-ash. ChromeOS
doesn't mix notification settings from different profiles and only shows
those from the active user, so they're not needed.

MessageCenterSettingsController is only used by NotifierSettingsView,
which now only compiles on ash/. Hence it can be ChromeOS only now
(although it's still difficult to move to ash/). This class gets a lot
simpler.

Other random cleanups:
- move more code into NotifierController
- cut NotificationUiManager out of the settings provider initialization
  loop; instead set it directly on MessageCenter.

Change-Id: Ib9a60e0eb3c167513eba555938369bad3f9d4634
Bug:  755413 
Reviewed-on: https://chromium-review.googlesource.com/685986
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509987}
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/ash/message_center/message_center_button_bar.h
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/ash/message_center/notifier_settings_view.cc
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/ash/message_center/notifier_settings_view.h
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/ash/message_center/notifier_settings_view_unittest.cc
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/chrome/browser/BUILD.gn
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/chrome/browser/notifications/extension_notifier_controller.cc
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/chrome/browser/notifications/extension_notifier_controller.h
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/chrome/browser/notifications/message_center_notification_manager.cc
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/chrome/browser/notifications/message_center_notification_manager.h
[delete] https://crrev.com/7c12136f8c0a75e611a6150fcc161f0e9c65fa4a/chrome/browser/notifications/message_center_settings_controller.cc
[delete] https://crrev.com/7c12136f8c0a75e611a6150fcc161f0e9c65fa4a/chrome/browser/notifications/message_center_settings_controller.h
[add] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/chrome/browser/notifications/message_center_settings_controller_chromeos.cc
[add] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/chrome/browser/notifications/message_center_settings_controller_chromeos.h
[rename] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/chrome/browser/notifications/message_center_settings_controller_chromeos_unittest.cc
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/chrome/browser/notifications/notification_ui_manager_desktop.cc
[add] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/chrome/browser/notifications/notifier_controller.cc
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/chrome/browser/notifications/notifier_controller.h
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/chrome/test/BUILD.gn
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/ui/message_center/fake_message_center.cc
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/ui/message_center/fake_message_center.h
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/ui/message_center/message_center.h
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/ui/message_center/message_center_impl.h
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/ui/message_center/notifier_settings.cc
[modify] https://crrev.com/feec2d11be84d01ba3456a684a484d01a8ac0780/ui/message_center/notifier_settings.h

Project Member

Comment 24 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f065b30cc128489d3ceb63498572ea322ae37f11

commit f065b30cc128489d3ceb63498572ea322ae37f11
Author: Evan Stade <estade@chromium.org>
Date: Thu Oct 26 20:54:57 2017

Remove NotifierSettingsProvider::OnNotifierSettingsClosing().

This isn't been called from anywhere. That would be somewhat worrisome,
but it appears it was removed in r207466 which landed over 4 years ago,
so I guess it's not an issue.

Bug:  755413 
Change-Id: I99f15d3aed6a67e2b7609c3a43ff739e7d49f791
Reviewed-on: https://chromium-review.googlesource.com/738627
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511950}
[modify] https://crrev.com/f065b30cc128489d3ceb63498572ea322ae37f11/ash/message_center/notifier_settings_view_unittest.cc
[modify] https://crrev.com/f065b30cc128489d3ceb63498572ea322ae37f11/chrome/browser/notifications/arc_application_notifier_controller_chromeos.cc
[modify] https://crrev.com/f065b30cc128489d3ceb63498572ea322ae37f11/chrome/browser/notifications/arc_application_notifier_controller_chromeos.h
[modify] https://crrev.com/f065b30cc128489d3ceb63498572ea322ae37f11/chrome/browser/notifications/message_center_settings_controller_chromeos.cc
[modify] https://crrev.com/f065b30cc128489d3ceb63498572ea322ae37f11/chrome/browser/notifications/message_center_settings_controller_chromeos.h
[modify] https://crrev.com/f065b30cc128489d3ceb63498572ea322ae37f11/chrome/browser/notifications/notifier_controller.h
[modify] https://crrev.com/f065b30cc128489d3ceb63498572ea322ae37f11/chrome/browser/notifications/web_page_notifier_controller.cc
[modify] https://crrev.com/f065b30cc128489d3ceb63498572ea322ae37f11/chrome/browser/notifications/web_page_notifier_controller.h
[modify] https://crrev.com/f065b30cc128489d3ceb63498572ea322ae37f11/ui/message_center/notifier_settings.h

Project Member

Comment 25 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ad675f9174f551100c743a4094f05526d157135

commit 9ad675f9174f551100c743a4094f05526d157135
Author: Evan Stade <estade@chromium.org>
Date: Tue Nov 07 22:26:38 2017

Message center cleanups:

- remove unused functions
- rename MessageCenterController to MessageViewDelegate to better
  reflect its role (it's an interface used by views, and has no
  relationship to the MessageCenter class)

TBR=yoshiki@chromium.org,dewittj@chromium.org

Bug:  755413 
Change-Id: I690360c61af220824beb11961e4d65978a2d3e7e
Reviewed-on: https://chromium-review.googlesource.com/754326
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514617}
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ash/message_center/message_center_view.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ash/message_center/message_center_view_unittest.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ash/message_center/message_list_view_unittest.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.mm
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/chrome/browser/ui/views/message_center/web_notification_tray.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/chrome/browser/ui/views/message_center/web_notification_tray.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/arc/notification/arc_notification_content_view_unittest.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/arc/notification/arc_notification_delegate.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/arc/notification/arc_notification_delegate.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/arc/notification/arc_notification_manager.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/arc/notification/arc_notification_view.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/arc/notification/arc_notification_view.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/arc/notification/arc_notification_view_unittest.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/BUILD.gn
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/fake_message_center_tray_delegate.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/fake_message_center_tray_delegate.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/message_center_tray_delegate.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/message_center_tray_unittest.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/message_popup_collection.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/message_popup_collection.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/message_view.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/message_view.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/message_view_context_menu_controller.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/message_view_context_menu_controller.h
[rename] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/message_view_delegate.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/message_view_factory.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/message_view_factory.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/notification_view.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/notification_view.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/notification_view_md.h
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/notification_view_md_unittest.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/notification_view_unittest.cc
[modify] https://crrev.com/9ad675f9174f551100c743a4094f05526d157135/ui/message_center/views/toast_contents_view.h

Project Member

Comment 26 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf27dae13b5876434e1d8061596316927d89a4e5

commit cf27dae13b5876434e1d8061596316927d89a4e5
Author: Evan Stade <estade@chromium.org>
Date: Tue Nov 07 23:57:51 2017

NotificationDisplayService: create TRANSIENT type that uses
NotificationDelegate rather than NotificationHandler.

Update EolNotification and AuthPolicyCredentialsManager notification.

Bug:  755413 
Change-Id: I31c785a23b70b7096069c1e501b0ec866990c598
Reviewed-on: https://chromium-review.googlesource.com/755153
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514662}
[modify] https://crrev.com/cf27dae13b5876434e1d8061596316927d89a4e5/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[modify] https://crrev.com/cf27dae13b5876434e1d8061596316927d89a4e5/chrome/browser/chromeos/eol_notification.cc
[modify] https://crrev.com/cf27dae13b5876434e1d8061596316927d89a4e5/chrome/browser/notifications/message_center_display_service.cc
[modify] https://crrev.com/cf27dae13b5876434e1d8061596316927d89a4e5/chrome/browser/notifications/native_notification_display_service.cc
[modify] https://crrev.com/cf27dae13b5876434e1d8061596316927d89a4e5/chrome/browser/notifications/notification_common.h

Project Member

Comment 27 by bugdroid1@chromium.org, Nov 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0798aac5cb3433e63a605303e4876b7d837e5c7d

commit 0798aac5cb3433e63a605303e4876b7d837e5c7d
Author: Evan Stade <estade@chromium.org>
Date: Sat Nov 11 00:40:40 2017

Move knowledge of screen lock state out of MessageCenter, confine to
MessageCenterView.

- Update login state notification blocker to hide all notifications in
  message center when screen is locked to maintain the behavior:
      "Don't make notifications read when opening the message 
       center on lock screen"
- Remove methods/variables/structs related to UnreadCount, which is
  not used anywhere except in tests.
- It's questionable whether we have any reason to still track is_read
  at all, but it's used for UMA in at least one place.

Bug:  755413 
Change-Id: Ic00a24900992735870338a9544e6af61da744974
Reviewed-on: https://chromium-review.googlesource.com/757132
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515765}
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ash/message_center/message_center_view.cc
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ash/message_center/message_center_view.h
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ash/message_center/message_center_view_unittest.cc
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ash/system/status_area_widget.cc
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ash/system/web_notification/login_state_notification_blocker.cc
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ash/system/web_notification/login_state_notification_blocker.h
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ui/message_center/fake_message_center.cc
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ui/message_center/fake_message_center.h
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ui/message_center/message_center.h
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ui/message_center/message_center_impl.h
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ui/message_center/message_center_impl_unittest.cc
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ui/message_center/message_center_observer.h
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ui/message_center/notification_list.cc
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ui/message_center/notification_list.h
[modify] https://crrev.com/0798aac5cb3433e63a605303e4876b7d837e5c7d/ui/message_center/notification_list_unittest.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c749795633f7aab02913e8310c183495e4dac9a7

commit c749795633f7aab02913e8310c183495e4dac9a7
Author: Evan Stade <estade@chromium.org>
Date: Mon Nov 13 20:33:05 2017

Message center cleanup: rename some classes to better reflect roles.
All mentions of "tray" should now be confined to ash.

- MessageCenterTray => UiController
- MessageCenterTrayDelegate => UiDelegate
- (Chrome's) WebNotificationTray => MessageCenterUiDelegate

Also remove some unnecessary includes.

TBR=atwilson@chromium.org

Bug:  755413 
Change-Id: Ic7774387ad313ed3ce356e5122a97dd9427699a9
Reviewed-on: https://chromium-review.googlesource.com/758931
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516028}
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ash/message_center/message_center_bubble.cc
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ash/message_center/message_center_bubble.h
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ash/message_center/message_center_button_bar.cc
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ash/message_center/message_center_view.cc
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ash/message_center/message_center_view.h
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ash/message_center/message_center_view_unittest.cc
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/chrome/browser/background/background_contents_service_unittest.cc
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/chrome/browser/chromeos/hats/hats_notification_controller_unittest.cc
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/chrome/browser/notifications/message_center_notification_manager.cc
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/chrome/browser/notifications/message_center_notification_manager.h
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/chrome/browser/notifications/message_center_notifications_unittest.cc
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/chrome/browser/ui/cocoa/notifications/message_center_bridge.h
[add] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/chrome/browser/ui/cocoa/notifications/message_center_bridge.mm
[delete] https://crrev.com/784862bff4c5eb377f9371575bbb2a630f5795dd/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h
[delete] https://crrev.com/784862bff4c5eb377f9371575bbb2a630f5795dd/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.mm
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/chrome/browser/ui/views/message_center/OWNERS
[delete] https://crrev.com/784862bff4c5eb377f9371575bbb2a630f5795dd/chrome/browser/ui/views/message_center/message_center_frame_view.cc
[delete] https://crrev.com/784862bff4c5eb377f9371575bbb2a630f5795dd/chrome/browser/ui/views/message_center/message_center_frame_view.h
[add] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/chrome/browser/ui/views/message_center/popups_only_ui_delegate.cc
[add] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/chrome/browser/ui/views/message_center/popups_only_ui_delegate.h
[rename] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/chrome/browser/ui/views/message_center/popups_only_ui_delegate_browsertest.cc
[delete] https://crrev.com/784862bff4c5eb377f9371575bbb2a630f5795dd/chrome/browser/ui/views/message_center/web_notification_tray.cc
[delete] https://crrev.com/784862bff4c5eb377f9371575bbb2a630f5795dd/chrome/browser/ui/views/message_center/web_notification_tray.h
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/chrome/test/BUILD.gn
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ui/message_center/BUILD.gn
[delete] https://crrev.com/784862bff4c5eb377f9371575bbb2a630f5795dd/ui/message_center/fake_message_center_tray_delegate.cc
[delete] https://crrev.com/784862bff4c5eb377f9371575bbb2a630f5795dd/ui/message_center/fake_message_center_tray_delegate.h
[add] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ui/message_center/fake_ui_delegate.cc
[add] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ui/message_center/fake_ui_delegate.h
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ui/message_center/message_center.h
[delete] https://crrev.com/784862bff4c5eb377f9371575bbb2a630f5795dd/ui/message_center/message_center_tray_unittest.cc
[rename] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ui/message_center/ui_controller.cc
[rename] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ui/message_center/ui_controller.h
[add] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ui/message_center/ui_controller_unittest.cc
[rename] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ui/message_center/ui_delegate.h
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ui/message_center/views/message_popup_collection.cc
[modify] https://crrev.com/c749795633f7aab02913e8310c183495e4dac9a7/ui/message_center/views/message_popup_collection.h

Project Member

Comment 29 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2465a5493d38ca9b3376240bcefd6325e112bf3e

commit 2465a5493d38ca9b3376240bcefd6325e112bf3e
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Nov 14 00:47:15 2017

Revert "Message center cleanup: rename some classes to better reflect roles."

This reverts commit c749795633f7aab02913e8310c183495e4dac9a7.

Reason for revert: suspected to consistently break Linux Tests (dbg). Example: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/45886

Original change's description:
> Message center cleanup: rename some classes to better reflect roles.
> All mentions of "tray" should now be confined to ash.
> 
> - MessageCenterTray => UiController
> - MessageCenterTrayDelegate => UiDelegate
> - (Chrome's) WebNotificationTray => MessageCenterUiDelegate
> 
> Also remove some unnecessary includes.
> 
> TBR=atwilson@chromium.org
> 
> Bug:  755413 
> Change-Id: Ic7774387ad313ed3ce356e5122a97dd9427699a9
> Reviewed-on: https://chromium-review.googlesource.com/758931
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Drew Wilson <atwilson@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516028}

TBR=stevenjb@chromium.org,atwilson@chromium.org,dewittj@chromium.org,estade@chromium.org,rsesek@chromium.org

Change-Id: Iaf1fe86a8a5e06e47dd35e3ed32ad1fa114bb260
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  755413 
Reviewed-on: https://chromium-review.googlesource.com/767828
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516121}
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ash/message_center/message_center_bubble.cc
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ash/message_center/message_center_bubble.h
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ash/message_center/message_center_button_bar.cc
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ash/message_center/message_center_view.cc
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ash/message_center/message_center_view.h
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ash/message_center/message_center_view_unittest.cc
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/background/background_contents_service_unittest.cc
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/chromeos/hats/hats_notification_controller_unittest.cc
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/notifications/message_center_notification_manager.cc
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/notifications/message_center_notification_manager.h
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/notifications/message_center_notifications_unittest.cc
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/8c25a4566488b6ee01283f05eaec0806008aaac7/chrome/browser/ui/cocoa/notifications/message_center_bridge.h
[delete] https://crrev.com/8c25a4566488b6ee01283f05eaec0806008aaac7/chrome/browser/ui/cocoa/notifications/message_center_bridge.mm
[add] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h
[add] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.mm
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/ui/views/message_center/OWNERS
[add] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/ui/views/message_center/message_center_frame_view.cc
[add] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/ui/views/message_center/message_center_frame_view.h
[delete] https://crrev.com/8c25a4566488b6ee01283f05eaec0806008aaac7/chrome/browser/ui/views/message_center/popups_only_ui_delegate.cc
[delete] https://crrev.com/8c25a4566488b6ee01283f05eaec0806008aaac7/chrome/browser/ui/views/message_center/popups_only_ui_delegate.h
[add] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/ui/views/message_center/web_notification_tray.cc
[add] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/ui/views/message_center/web_notification_tray.h
[rename] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/chrome/test/BUILD.gn
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ui/message_center/BUILD.gn
[add] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ui/message_center/fake_message_center_tray_delegate.cc
[add] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ui/message_center/fake_message_center_tray_delegate.h
[delete] https://crrev.com/8c25a4566488b6ee01283f05eaec0806008aaac7/ui/message_center/fake_ui_delegate.cc
[delete] https://crrev.com/8c25a4566488b6ee01283f05eaec0806008aaac7/ui/message_center/fake_ui_delegate.h
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ui/message_center/message_center.h
[rename] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ui/message_center/message_center_tray.cc
[rename] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ui/message_center/message_center_tray.h
[rename] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ui/message_center/message_center_tray_delegate.h
[add] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ui/message_center/message_center_tray_unittest.cc
[delete] https://crrev.com/8c25a4566488b6ee01283f05eaec0806008aaac7/ui/message_center/ui_controller_unittest.cc
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ui/message_center/views/message_popup_collection.cc
[modify] https://crrev.com/2465a5493d38ca9b3376240bcefd6325e112bf3e/ui/message_center/views/message_popup_collection.h

Project Member

Comment 30 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a34eccc19fc7329830d5d336662540e7fbd5948d

commit a34eccc19fc7329830d5d336662540e7fbd5948d
Author: Evan Stade <estade@chromium.org>
Date: Tue Nov 14 04:53:11 2017

Message center cleanup: rename some classes to better reflect roles.
All mentions of "tray" should now be confined to ash.

- MessageCenterTray => UiController
- MessageCenterTrayDelegate => UiDelegate
- (Chrome's) WebNotificationTray => MessageCenterUiDelegate

Also remove some unnecessary includes.

(This is a re-land of c749795633f7aab02913)

TBR=atwilson@chromium.org,stevenjb@chromium.org,rsesek@chromium.org

Bug:  755413 
Change-Id: I23ffbb94b2ad9678a92d8337f36b7f061a1e9252
Reviewed-on: https://chromium-review.googlesource.com/768087
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516196}
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ash/message_center/message_center_bubble.cc
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ash/message_center/message_center_bubble.h
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ash/message_center/message_center_button_bar.cc
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ash/message_center/message_center_view.cc
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ash/message_center/message_center_view.h
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ash/message_center/message_center_view_unittest.cc
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/chrome/browser/background/background_contents_service_unittest.cc
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/chrome/browser/chromeos/hats/hats_notification_controller_unittest.cc
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/chrome/browser/notifications/message_center_notification_manager.cc
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/chrome/browser/notifications/message_center_notification_manager.h
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/chrome/browser/notifications/message_center_notifications_unittest.cc
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/chrome/browser/ui/cocoa/notifications/message_center_bridge.h
[add] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/chrome/browser/ui/cocoa/notifications/message_center_bridge.mm
[delete] https://crrev.com/78e7c1ed1fd822dc070da8a4078d76f11789db9c/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h
[delete] https://crrev.com/78e7c1ed1fd822dc070da8a4078d76f11789db9c/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.mm
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/chrome/browser/ui/views/message_center/OWNERS
[delete] https://crrev.com/78e7c1ed1fd822dc070da8a4078d76f11789db9c/chrome/browser/ui/views/message_center/message_center_frame_view.cc
[delete] https://crrev.com/78e7c1ed1fd822dc070da8a4078d76f11789db9c/chrome/browser/ui/views/message_center/message_center_frame_view.h
[add] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/chrome/browser/ui/views/message_center/popups_only_ui_delegate.cc
[add] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/chrome/browser/ui/views/message_center/popups_only_ui_delegate.h
[rename] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/chrome/browser/ui/views/message_center/popups_only_ui_delegate_browsertest.cc
[delete] https://crrev.com/78e7c1ed1fd822dc070da8a4078d76f11789db9c/chrome/browser/ui/views/message_center/web_notification_tray.cc
[delete] https://crrev.com/78e7c1ed1fd822dc070da8a4078d76f11789db9c/chrome/browser/ui/views/message_center/web_notification_tray.h
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/chrome/test/BUILD.gn
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ui/message_center/BUILD.gn
[delete] https://crrev.com/78e7c1ed1fd822dc070da8a4078d76f11789db9c/ui/message_center/fake_message_center_tray_delegate.cc
[delete] https://crrev.com/78e7c1ed1fd822dc070da8a4078d76f11789db9c/ui/message_center/fake_message_center_tray_delegate.h
[add] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ui/message_center/fake_ui_delegate.cc
[add] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ui/message_center/fake_ui_delegate.h
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ui/message_center/message_center.h
[delete] https://crrev.com/78e7c1ed1fd822dc070da8a4078d76f11789db9c/ui/message_center/message_center_tray_unittest.cc
[rename] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ui/message_center/ui_controller.cc
[rename] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ui/message_center/ui_controller.h
[add] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ui/message_center/ui_controller_unittest.cc
[rename] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ui/message_center/ui_delegate.h
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ui/message_center/views/message_popup_collection.cc
[modify] https://crrev.com/a34eccc19fc7329830d5d336662540e7fbd5948d/ui/message_center/views/message_popup_collection.h

Project Member

Comment 31 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb

commit 7e2ee7a1a5a218b09493821e6651d1c51c07f5bb
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Wed Nov 29 10:38:25 2017

Separate NotificationMenuModel from UiController

This Cl moves NotificationMenuModel to ui/message_center/views, since this
is used only in views platform now. Previously both several platform (views
and cocoa) shared this code but the notification implementation for cocoa
has removed.

Bug:  755413 
Change-Id: I6d614396d406c7ced235105d64fda354894fd94f
Reviewed-on: https://chromium-review.googlesource.com/792312
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520066}
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ash/message_center/message_center_view.cc
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ash/message_center/message_center_view.h
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ash/message_center/message_center_view_unittest.cc
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ash/message_center/message_list_view_unittest.cc
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/arc/notification/arc_notification_content_view_unittest.cc
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/arc/notification/arc_notification_view_unittest.cc
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/BUILD.gn
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/ui_controller.cc
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/ui_controller.h
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/ui_controller_unittest.cc
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/views/message_popup_collection.cc
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/views/message_popup_collection.h
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/views/message_view_context_menu_controller.cc
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/views/message_view_context_menu_controller.h
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/views/message_view_delegate.h
[add] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/views/notification_menu_model.cc
[add] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/views/notification_menu_model.h
[add] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/views/notification_menu_model_unittest.cc
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/views/notification_view_md_unittest.cc
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/views/notification_view_unittest.cc
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/views/toast_contents_view.cc
[modify] https://crrev.com/7e2ee7a1a5a218b09493821e6651d1c51c07f5bb/ui/message_center/views/toast_contents_view.h

Project Member

Comment 32 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf003ede2455374930c094b425ba81d5bfe0763e

commit cf003ede2455374930c094b425ba81d5bfe0763e
Author: Evan Stade <estade@chromium.org>
Date: Sat Dec 02 02:24:55 2017

Migrate some more uses of g_browser_process->notification_ui_manager()
to NotificationDisplayService.

Also combine the two generic click handling NotificationDelegates.

Bug:  783018 ,  755413 
Change-Id: I180350bfa0507851f658d619f2918c04a81c5d7a
Reviewed-on: https://chromium-review.googlesource.com/765047
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521182}
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/chrome/browser/chromeos/net/network_state_notifier.cc
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/chrome/browser/chromeos/status/data_promo_notification.cc
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/chrome/browser/chromeos/ui/low_disk_notification.cc
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/chrome/browser/extensions/extension_storage_monitor.cc
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/chrome/browser/extensions/extension_storage_monitor.h
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/chrome/browser/notifications/native_notification_display_service.cc
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/chrome/browser/signin/signin_error_notifier_ash.cc
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/chrome/browser/ui/extensions/extension_installed_notification.cc
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/ui/message_center/notification.cc
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/ui/message_center/notification_delegate.cc
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/ui/message_center/notification_delegate.h
[modify] https://crrev.com/cf003ede2455374930c094b425ba81d5bfe0763e/ui/message_center/notification_delegate_unittest.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c709c89fb5a0ccd06dcc886160edc185eab8a7e9

commit c709c89fb5a0ccd06dcc886160edc185eab8a7e9
Author: Evan Stade <estade@chromium.org>
Date: Mon Dec 11 20:41:29 2017

Remove MessageViewDelegate::UpdateNotificationSize in favor of observing
preferred size changes.

This removes the only method from the interface which isn't just a thunk
to an identical method on MessageCenter. After this, we can get rid of
MessageViewDelegate and remove this layer of somewhat confusing
indirection.

Bug:  755413 
Change-Id: I9338e3ff533116fb3a91d3e4909755d3b64be0d5
Reviewed-on: https://chromium-review.googlesource.com/812444
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523196}
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ash/message_center/message_center_view.cc
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ash/message_center/message_center_view.h
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ash/message_center/message_center_view_unittest.cc
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ash/message_center/message_list_view_unittest.cc
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/arc/notification/arc_notification_content_view_unittest.cc
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/arc/notification/arc_notification_view.cc
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/arc/notification/arc_notification_view_unittest.cc
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/message_center/views/message_popup_collection.cc
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/message_center/views/message_popup_collection.h
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/message_center/views/message_view.cc
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/message_center/views/message_view.h
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/message_center/views/message_view_delegate.h
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/message_center/views/notification_view_md_unittest.cc
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/message_center/views/notification_view_unittest.cc
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/message_center/views/toast_contents_view.cc
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/message_center/views/toast_contents_view.h
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/views/view.cc
[modify] https://crrev.com/c709c89fb5a0ccd06dcc886160edc185eab8a7e9/ui/views/view_observer.h

Project Member

Comment 34 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1

commit d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1
Author: Evan Stade <estade@chromium.org>
Date: Wed Dec 13 21:04:39 2017

Remove MessageViewDelegate

Aside from being used in unit tests, it's just a pass-through to the MessageCenter
object. There is one minor exception in MessagePopupCollection::RemoveNotificationn
and that behavior is moved to MessageCenter::RemoveNotification.

Bug:  755413 
Change-Id: I2face04b359dfaa5cdead5f7e27da09acb9a3e69
Reviewed-on: https://chromium-review.googlesource.com/811991
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523875}
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ash/message_center/message_center_view.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ash/message_center/message_center_view.h
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ash/message_center/message_center_view_unittest.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ash/message_center/message_list_view_unittest.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/arc/notification/arc_notification_content_view_unittest.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/arc/notification/arc_notification_delegate.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/arc/notification/arc_notification_delegate.h
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/arc/notification/arc_notification_manager.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/arc/notification/arc_notification_view.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/arc/notification/arc_notification_view.h
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/arc/notification/arc_notification_view_unittest.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/BUILD.gn
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/message_popup_collection.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/message_popup_collection.h
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/message_view.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/message_view.h
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/message_view_context_menu_controller.cc
[delete] https://crrev.com/07e89c39b8060fc25c20187de28cd39b604e79d4/ui/message_center/views/message_view_delegate.h
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/message_view_factory.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/message_view_factory.h
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/notification_view.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/notification_view.h
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/notification_view_md.h
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/notification_view_md_unittest.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/notification_view_unittest.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/toast_contents_view.cc
[modify] https://crrev.com/d1f8c228bd7e1827e1bcb65635ea8550cc95f0b1/ui/message_center/views/toast_contents_view.h

Blockedon: 797128
Project Member

Comment 36 by bugdroid1@chromium.org, Jan 19 2018

Project Member

Comment 37 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a631940472461eaa4093e7c1f762f92c2227cc1

commit 1a631940472461eaa4093e7c1f762f92c2227cc1
Author: Evan Stade <estade@chromium.org>
Date: Mon Jan 22 22:49:21 2018

Remove NativeNotificationDisplayService files.

These were removed from the build in 7426194d8300ebf006ad87d1 but
accidentally left in the tree.

TBR=peter@chromium.org

Bug:  755413 
Change-Id: Iba88cc7091f897c00a9d2b2173482f2fbaf86317
Reviewed-on: https://chromium-review.googlesource.com/878909
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531030}
[delete] https://crrev.com/142de38acea69021afc8defc32ddbc4763b11baf/chrome/browser/notifications/native_notification_display_service.cc
[delete] https://crrev.com/142de38acea69021afc8defc32ddbc4763b11baf/chrome/browser/notifications/native_notification_display_service.h

Status: Fixed (was: Started)
Project Member

Comment 39 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a

commit e0921095b83f1e63d0b2cdde9d7f76a71c6d046a
Author: Evan Stade <estade@chromium.org>
Date: Wed Apr 04 21:13:09 2018

Message center/notifications clean ups

- Some interfaces had separate functions for click and button click, while
  some used parameters to distinguish. Consolidate on shared functions.
- Update some notifications to use HandleClickNotificationDelegate or
  ThunkNotificationDelegate.

BUG= 776205 , 755413 

Change-Id: Ib133bdf93277c84c99311256c47a250d2b8e571f
Reviewed-on: https://chromium-review.googlesource.com/963619
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548198}
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/display/display_util.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/display/resolution_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/display/resolution_notification_controller.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/message_center/message_center_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/system/bluetooth/bluetooth_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/system/locale/locale_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/system/power/dual_role_notification.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/system/screen_layout_observer_unittest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/system/screen_security/screen_security_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/background/background_contents_service.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/arc/arc_migration_guide_notification.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/eol_notification.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/file_system_provider/notification_manager.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/file_system_provider/notification_manager.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/first_run/drive_first_run_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/hats/hats_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/hats/hats_notification_controller.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller_chromeos_unittest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/net/network_portal_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/printing/cups_print_job_notification.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/printing/cups_print_job_notification.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/download/notification/download_item_notification.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/download/notification/download_item_notification_unittest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/extensions/api/networking_config_chromeos_apitest_chromeos.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/extensions/extension_storage_monitor_browsertest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/notifications/message_center_notifications_browsertest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/notifications/notification_interactive_uitest_support.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/notifications/notification_platform_bridge_chromeos.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/notifications/notification_platform_bridge_message_center.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/notifications/stub_notification_display_service.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/printing/cloud_print/privet_notifications.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/printing/cloud_print/privet_notifications.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/ui/ash/network/tether_notification_presenter_unittest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/ui/extensions/extension_installed_notification.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/ui/extensions/extension_installed_notification.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/usb/web_usb_detector.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/usb/web_usb_detector_unittest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/arc/notification/arc_notification_delegate.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/arc/notification/arc_notification_delegate.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/message_center_observer.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/message_center_stats_collector.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/message_center_stats_collector.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/public/cpp/notification.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/public/cpp/notification_delegate.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/public/cpp/notification_delegate.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/public/cpp/notification_delegate_unittest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/ui_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/ui_controller.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/views/notification_view_md_unittest.cc

Sign in to add a comment