New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755407 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Deprecate support for repeating metrics in UKM entries.

Project Member Reported by holte@chromium.org, Aug 15 2017

Issue description

Should prefer to have repeating entries, which may use something else to indicate the context.
 

Comment 1 by holte@chromium.org, Aug 18 2017

PasswordForm UKM has some metrics that currently depend on this.

Comment 2 by holte@chromium.org, Sep 1 2017

Components: Internals>Metrics>UKM
Project Member

Comment 3 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27e653f958c14b464f2f7a98ba262af25fc40c13

commit 27e653f958c14b464f2f7a98ba262af25fc40c13
Author: Steven Holte <holte@google.com>
Date: Wed May 09 02:09:01 2018

Use a map for storing UKM metrics.

Bug: 755407
Change-Id: If7dc53455d023c653e184cdbfe5066875aea7052
Reviewed-on: https://chromium-review.googlesource.com/1028851
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557063}
[modify] https://crrev.com/27e653f958c14b464f2f7a98ba262af25fc40c13/chrome/browser/ui/tabs/tab_ukm_test_helper.cc
[modify] https://crrev.com/27e653f958c14b464f2f7a98ba262af25fc40c13/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/27e653f958c14b464f2f7a98ba262af25fc40c13/components/ukm/debug/ukm_debug_data_extractor.cc
[modify] https://crrev.com/27e653f958c14b464f2f7a98ba262af25fc40c13/components/ukm/test_ukm_recorder.cc
[modify] https://crrev.com/27e653f958c14b464f2f7a98ba262af25fc40c13/components/ukm/ukm_recorder_impl.cc
[modify] https://crrev.com/27e653f958c14b464f2f7a98ba262af25fc40c13/services/metrics/public/cpp/ukm_entry_builder_base.cc
[modify] https://crrev.com/27e653f958c14b464f2f7a98ba262af25fc40c13/services/metrics/public/mojom/ukm_interface.mojom

Sign in to add a comment