Issue metadata
Sign in to add a comment
|
[A11y Assessment - Function Keys] Need better spoken feedback for volume and brightness sliders |
||||||||||||||||||||||||
Issue descriptionOS: Chrome Version: 61.0.3163.38 1. Enable ChromeVox Ctrl Alt Z 2. Attempt to use the brightness up / down keys and the volume up / down keys Notice that when you press brightness up, as one example, you only hear the percentage (e.g. "53%". However, you don't hear what the percentage is for. We should make a change so that as you press either the brightness up, brightness down, volume or, or volume down keys, that we say the percentage and then what it's for. For example, "53% brightness", "60% brightness", "22% volume" "52% volume". This would make the experience much more clear.
,
Sep 27 2017
zork@, please help take a look whether this is a good start to fix A11Y bugs. Thanks.
,
Sep 27 2017
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b670fbd9b422c527e64de25ab38cad84149291e4 commit b670fbd9b422c527e64de25ab38cad84149291e4 Author: David Tseng <dtseng@chromium.org> Date: Thu Nov 30 21:00:56 2017 Fix slider accessibility 1. the initial value change on sliders sometimes did not get dispatched because a client user of the Slider class can and does set the initial slider value before attaching it to a widget and making that widget visible. Fire the value change when visibility changes for the slider if needed. An example of where this occurs is the Chrome OS volume slider which changes without it actually receiving focus. The system tray briefly shows the volume control. 2. ChromeVox specific: make ChromeVox output the entire node including role and any states when it first encounters the node. Note that these nodes are transient so disappear quickly. We don't reset the value of |lastValueChangedTarget_ as a result. Test: manual. Bug: 755392 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I86da8d1f5aed933dcc36a460202402f576a8a5f9 Reviewed-on: https://chromium-review.googlesource.com/777599 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#520681} [modify] https://crrev.com/b670fbd9b422c527e64de25ab38cad84149291e4/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc [modify] https://crrev.com/b670fbd9b422c527e64de25ab38cad84149291e4/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js [modify] https://crrev.com/b670fbd9b422c527e64de25ab38cad84149291e4/ui/views/controls/slider.cc [modify] https://crrev.com/b670fbd9b422c527e64de25ab38cad84149291e4/ui/views/controls/slider.h [modify] https://crrev.com/b670fbd9b422c527e64de25ab38cad84149291e4/ui/views/controls/slider_unittest.cc
,
Jan 25 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dtseng@chromium.org
, Sep 18 2017Status: available (was: Assigned)