New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 755382 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
etienneb@chromium.org
ssid@chromium.org
erikc...@chromium.org
█ dskiba@chromium.org
█ brettw@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 751321



Sign in to add a comment

memlog: trace metadata has wrong command_line. Will break symbol downloading in symbolize_trace

Project Member Reported by ajwong@chromium.org, Aug 14 2017 
Currently, the trace metadata is generated in the profiling process. The symbolize_trace script tries to mine out the binary name from the command_line JSON entry in the trace file to determine if the build is a dev build or an official one.

Because the metadata is generated in the profiling process, it grabs the child commandline which in a system with a zygote ends up being something like /proc/self/exe which is unhelpful.

Fix.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21a2cabf7f10d9f415ded0c68a12a98e818c16a0

commit 21a2cabf7f10d9f415ded0c68a12a98e818c16a0
Author: erikchen <erikchen@chromium.org>
Date: Mon Aug 21 20:50:44 2017

Plumb through metadata for traces generated by profiling process.

The metadata contains the necessary and sufficient information to symbolize the
trace.

Bug:  755382 
Change-Id: Ie13690618bd055512a6311d4b65eac3dc47e6eb3
Reviewed-on: https://chromium-review.googlesource.com/622281
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496053}
[modify] https://crrev.com/21a2cabf7f10d9f415ded0c68a12a98e818c16a0/chrome/browser/profiling_host/profiling_process_host.cc
[modify] https://crrev.com/21a2cabf7f10d9f415ded0c68a12a98e818c16a0/chrome/browser/profiling_host/profiling_process_host.h
[modify] https://crrev.com/21a2cabf7f10d9f415ded0c68a12a98e818c16a0/chrome/common/profiling/memlog.mojom
[modify] https://crrev.com/21a2cabf7f10d9f415ded0c68a12a98e818c16a0/chrome/profiling/json_exporter.cc
[modify] https://crrev.com/21a2cabf7f10d9f415ded0c68a12a98e818c16a0/chrome/profiling/json_exporter.h
[modify] https://crrev.com/21a2cabf7f10d9f415ded0c68a12a98e818c16a0/chrome/profiling/json_exporter_unittest.cc
[modify] https://crrev.com/21a2cabf7f10d9f415ded0c68a12a98e818c16a0/chrome/profiling/memlog_connection_manager.cc
[modify] https://crrev.com/21a2cabf7f10d9f415ded0c68a12a98e818c16a0/chrome/profiling/memlog_connection_manager.h
[modify] https://crrev.com/21a2cabf7f10d9f415ded0c68a12a98e818c16a0/chrome/profiling/memlog_impl.cc
[modify] https://crrev.com/21a2cabf7f10d9f415ded0c68a12a98e818c16a0/chrome/profiling/memlog_impl.h

Comment 2 by erikc...@chromium.org, Aug 21 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment