New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755370 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

testBrowserRestartsAfterEachPage failure on ChromeOS

Project Member Reported by achuith@chromium.org, Aug 14 2017

Issue description

First failing build:
https://uberchromegw.corp.google.com/i/chromiumos.chromium/builders/amd64-generic-telemetry/builds/12158

Log snippet:
08/14 10:58:33.785 INFO |run_chromeos_tests:0052| [596/1132] telemetry.page.page_run_end_to_end_unittest.ActualPageRunEndToEndTests.testBrowserRestartsAfterEachPage failed unexpectedly 21.8268s:
08/14 10:58:33.787 INFO |run_chromeos_tests:0052|   Traceback (most recent call last):
08/14 10:58:33.788 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/page/page_run_end_to_end_unittest.py", line 176, in testBrowserRestartsAfterEachPage
08/14 10:58:33.789 INFO |run_chromeos_tests:0052|       self.assertEquals(2, test.browser_starts)
08/14 10:58:33.790 INFO |run_chromeos_tests:0052|   AssertionError: 2 != 1

Catapult roll:
https://chromium-review.googlesource.com/c/613181

CL in roll:
https://codereview.chromium.org/2998773002
 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0ec1bba917bc9790356c5c93b531cf788313d4f

commit c0ec1bba917bc9790356c5c93b531cf788313d4f
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Tue Aug 15 01:57:43 2017

Roll src/third_party/catapult/ 0476b2d1d..2ebc30b5d (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0476b2d1dd02..2ebc30b5d9bd

$ git log 0476b2d1d..2ebc30b5d --date=short --no-merges --format='%ad %ae %s'
2017-08-14 achuith Disable testBrowserRestartsAfterEachPage on chromeos.

Created with:
  roll-dep src/third_party/catapult
BUG= 755370 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I63c023133d4bb911c205e902d960e5f9dd73800e
Reviewed-on: https://chromium-review.googlesource.com/614916
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494301}
[modify] https://crrev.com/c0ec1bba917bc9790356c5c93b531cf788313d4f/DEPS

Status: Assigned (was: Untriaged)
Neat, this is actually working as expected: Namely on ChromeOS, unlike other platforms, the browser is not restarted.

I'll fix the test to take this into account and re-enable.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ee76385b5a77683b02957cc49f1a13659d09b20

commit 6ee76385b5a77683b02957cc49f1a13659d09b20
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Tue Aug 15 17:54:41 2017

Roll src/third_party/catapult/ 11749b52f..d27175a04 (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/11749b52ff6b..d27175a0446e

$ git log 11749b52f..d27175a04 --date=short --no-merges --format='%ad %ae %s'
2017-08-15 perezju [tools/perf] Fix testBrowserRestartsAfterEachPage in ChromeOS

Created with:
  roll-dep src/third_party/catapult
BUG= 755370 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I88d991a5963b327ddc168f25dd3bee792747768c
Reviewed-on: https://chromium-review.googlesource.com/615188
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494441}
[modify] https://crrev.com/6ee76385b5a77683b02957cc49f1a13659d09b20/DEPS

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment