New issue
Advanced search Search tips

Issue 755369 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 13
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

`git cl split` cryptically crashes if no upstream is configured for current branch

Project Member Reported by thakis@chromium.org, Aug 14 2017

Issue description

I figured I'd give `git cl split` a try. It just crashed for me; with some debugging I tracked it down to this:

thakis@thakis:~/src/chrome/src$ git rev-parse --abbrev-ref --symbolic-full-name base@{upstream}
fatal: no upstream configured for branch 'base'


I always create my branches off master (`git checkout master; git checkout -b hack` basically).

Not sure if that's easy to support or if it should be supported, or if the error message should just be nicer.



$ git cl split --description=desc.txt
Will split current branch (base) in 135 CLs.

Traceback (most recent call last):
  File "/usr/local/google/home/thakis/src/depot_tools/git_cl.py", line 6088, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/thakis/src/depot_tools/git_cl.py", line 6070, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/thakis/src/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/thakis/src/depot_tools/git_cl.py", line 4962, in CMDsplit
    Changelist, WrappedCMDupload)
  File "/usr/local/google/home/thakis/src/depot_tools/split_cl.py", line 185, in SplitCl
    cmd_upload)
  File "/usr/local/google/home/thakis/src/depot_tools/split_cl.py", line 90, in UploadCl
    refactor_branch, directory, refactor_branch_upstream):
  File "/usr/local/google/home/thakis/src/depot_tools/split_cl.py", line 44, in CreateBranchForDirectory
    git.run('checkout', '-t', upstream, '-b', branch_name)
  File "/usr/local/google/home/thakis/src/depot_tools/git_common.py", line 688, in run
    return run_with_stderr(*cmd, **kwargs)[0]
  File "/usr/local/google/home/thakis/src/depot_tools/git_common.py", line 753, in run_with_stderr
    proc = subprocess2.Popen(cmd, **kwargs)
  File "/usr/local/google/home/thakis/src/depot_tools/subprocess2.py", line 210, in __init__
    tmp_str = ' '.join(args)
TypeError: sequence item 5: expected string, NoneType found

 
Labels: Needs-Milestone TE-NeedsTriageHelp
Seems this issue is out of TE scope ,adding 'TE-NeedsTriageHelp' to remove this from TE's Unconfirmed triaging bucket.
Thank you!
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 13

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment