New issue
Advanced search Search tips

Issue 755363 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 731899



Sign in to add a comment

[Tab Metrics] Track tab load time during session restore and background tab loading

Project Member Reported by shaseley@google.com, Aug 14 2017

Issue description

Add metrics for tracking tab load time during session restore and background tab loading, which will help measure user wait time.

This is one of several metrics related to https://bugs.chromium.org/p/chromium/issues/detail?id=731899.

 

Comment 1 by holte@chromium.org, Aug 21 2017

Components: -Internals>Metrics
Labels: Hotlist-Metrics
Moving bugs about specific metrics recording out of Internals>Metrics component into Hotlist-Metrics
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e5968e25d05ae0589fb55e8293f053b07af6eaf

commit 5e5968e25d05ae0589fb55e8293f053b07af6eaf
Author: Scott Haseley <shaseley@google.com>
Date: Wed Aug 23 02:06:30 2017

[Tab Metrics] Adding tab switch load time and tab state metrics

This CL adds tab switch load time metrics to TabManagerStatsCollector
during session restore and background tab opening. Since it is possible
to have background tab loading or session restore occurring simultaneously
in multiple windows, the implementation tracks all new foreground tabs as
they are switched to, and records metrics when receiving the done
loading signal from the TabManager for tracked tabs. The new metrics are
TabManager.Experimental.BackgroundTabOpening.TabSwitchLoadTime and
TabManager.Experimental.SessionRestore.TabSwitchLoadTime.

This CL also adds the TabManager.BackgroundTabOpening.SwitchToTab metric,
which is the background tab opening version of
TabManager.SessionRestore.SwitchToTab.

Bug:  755363 
Change-Id: Ie43b48e325b14a93c806b12f3a483415ccff8cef
Reviewed-on: https://chromium-review.googlesource.com/614723
Commit-Queue: Scott Haseley <shaseley@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: lpy <lpy@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496552}
[modify] https://crrev.com/5e5968e25d05ae0589fb55e8293f053b07af6eaf/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/5e5968e25d05ae0589fb55e8293f053b07af6eaf/chrome/browser/resource_coordinator/tab_manager.h
[modify] https://crrev.com/5e5968e25d05ae0589fb55e8293f053b07af6eaf/chrome/browser/resource_coordinator/tab_manager_stats_collector.cc
[modify] https://crrev.com/5e5968e25d05ae0589fb55e8293f053b07af6eaf/chrome/browser/resource_coordinator/tab_manager_stats_collector.h
[modify] https://crrev.com/5e5968e25d05ae0589fb55e8293f053b07af6eaf/chrome/browser/resource_coordinator/tab_manager_stats_collector_unittest.cc
[modify] https://crrev.com/5e5968e25d05ae0589fb55e8293f053b07af6eaf/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfed89f01334fbb1799ced576d18ca134b3f860d

commit bfed89f01334fbb1799ced576d18ca134b3f860d
Author: Scott Haseley <shaseley@google.com>
Date: Sun Aug 27 21:34:38 2017

[Tab Metrics] Do not report TabSwitchLoadTime if the foreground tab navigates to a new page

This CL sends a signal from TabManager::WebContentsData to TabManagerStatsCollector
when a navigation begins in the main frame. If the stats collector is tracking the
tab that navigates, i.e. it is a foreground tab that was switched to, it untracks it.
This suppresses reporting in cases where the user navigates to a new page before the
page finishes loading, which could arbitrarily inflate the load time.

This CL also adds a test to not change tab loading state for same
document navigations.

Bug:  755363 
Change-Id: Iba9858d8b64220a24a2b36edde898f720b2dfbed
Reviewed-on: https://chromium-review.googlesource.com/630596
Commit-Queue: Scott Haseley <shaseley@google.com>
Reviewed-by: lpy <lpy@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497681}
[modify] https://crrev.com/bfed89f01334fbb1799ced576d18ca134b3f860d/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/bfed89f01334fbb1799ced576d18ca134b3f860d/chrome/browser/resource_coordinator/tab_manager.h
[modify] https://crrev.com/bfed89f01334fbb1799ced576d18ca134b3f860d/chrome/browser/resource_coordinator/tab_manager_grc_tab_signal_observer.cc
[modify] https://crrev.com/bfed89f01334fbb1799ced576d18ca134b3f860d/chrome/browser/resource_coordinator/tab_manager_stats_collector.cc
[modify] https://crrev.com/bfed89f01334fbb1799ced576d18ca134b3f860d/chrome/browser/resource_coordinator/tab_manager_stats_collector.h
[modify] https://crrev.com/bfed89f01334fbb1799ced576d18ca134b3f860d/chrome/browser/resource_coordinator/tab_manager_stats_collector_unittest.cc
[modify] https://crrev.com/bfed89f01334fbb1799ced576d18ca134b3f860d/chrome/browser/resource_coordinator/tab_manager_web_contents_data.cc
[modify] https://crrev.com/bfed89f01334fbb1799ced576d18ca134b3f860d/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1d9b7866cae8280d447ede757763e4f96e569cf

commit c1d9b7866cae8280d447ede757763e4f96e569cf
Author: Scott Haseley <shaseley@google.com>
Date: Thu Aug 31 21:58:20 2017

[Tab Metrics] Change histogram range for TabSwitchLoadTime

The range for the existing TabManager.Experimental.*.TabSwitchLoadTime
metrics was not large enough, causing too many entries in the overflow
bucket. This change expands the maximum range from 10 seconds to 3
minutes, marks the old metrics as obsolete, and replaces the old
metrics with TabManager.Experimental.SessionRestore.TabSwitchLoadTime.UntilTabIsLoaded
and TabManager.Experimental.BackgroundTabOpening.TabSwitchLoadTime.UntilTabIsLoaded

Bug:  755363 
Change-Id: I1ef241340072983095afe42032325ca678dc3c90
Reviewed-on: https://chromium-review.googlesource.com/644851
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Commit-Queue: Scott Haseley <shaseley@google.com>
Cr-Commit-Position: refs/heads/master@{#499025}
[modify] https://crrev.com/c1d9b7866cae8280d447ede757763e4f96e569cf/chrome/browser/resource_coordinator/tab_manager_stats_collector.cc
[modify] https://crrev.com/c1d9b7866cae8280d447ede757763e4f96e569cf/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment