Revert with "No-Tree-Checks: true" still blocked on closed tree -- not skip CQ |
||||||
Issue descriptionThis change was automatically created by FindIt and add the following special flags: No-Presubmit: true No-Tree-Checks: true No-Try: true Despite this the CQ still ran a number of tests and the patch was blocked from landing because of the tree closure. https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/614469/1
,
Aug 15 2017
This is very possible, I think I saw another report of the same thing. Is this actually Pri-3 for you? Btw, please don't cc folks who used to work on CQ; we still actively triage bugs.
,
Aug 15 2017
This is actually a bug in FindIt, description is just wrong:
=========
...
> Cr-Commit-Position: refs/heads/master@{#494191}
No-Presubmit: true # <---- missing empty line before.
No-Tree-Checks: true
No-Try: true
Bug: 669240
# Because of this line,...
Change-Id: I59fdef03a3b7ec98a644bf013c84d91551262b33 # ...only Change-Id is counted as metadata footer
=============
Assuming Change-Id was added by git cl, Findit should have added an empty line before 4 metadata lines (footers) it added.
,
Aug 15 2017
,
Aug 15 2017
Issue 755349 has been merged into this issue.
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/a3bd7c66506e7534bd525e54ff0db0fedd193046 commit a3bd7c66506e7534bd525e54ff0db0fedd193046 Author: Chan <chanli@chromium.org> Date: Tue Aug 15 18:25:53 2017 [Findit] Add empty line before footers. Bug: 755347 Change-Id: If8af13e38cf43e7c08486d01900bd8d4ab0e91b0 Reviewed-on: https://chromium-review.googlesource.com/614872 Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/a3bd7c66506e7534bd525e54ff0db0fedd193046/appengine/findit/infra_api_clients/codereview/gerrit.py [modify] https://crrev.com/a3bd7c66506e7534bd525e54ff0db0fedd193046/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/d2f0386d75bcc206af23d6f843916f71b862ea8a commit d2f0386d75bcc206af23d6f843916f71b862ea8a Author: Chan <chanli@chromium.org> Date: Mon Aug 28 20:35:29 2017 [Findit] Remove the '\n' at the end of generated revert CL description. Bug: 755347 Change-Id: I7d86d389b8f28b6443540a98e5a001b4bb2738e1 Reviewed-on: https://chromium-review.googlesource.com/636083 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/d2f0386d75bcc206af23d6f843916f71b862ea8a/appengine/findit/infra_api_clients/codereview/gerrit.py [modify] https://crrev.com/d2f0386d75bcc206af23d6f843916f71b862ea8a/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py
,
Aug 31 2017
Issue 755348 has been merged into this issue.
,
Sep 23 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by reillyg@chromium.org
, Aug 14 2017