pstore: console-ramoops renamed to console-ramoops-0 |
||||||
Issue descriptionstarting with linux-3.19, all files now have index suffixes in their name. e.g. /dev/pstore/console-ramoops will never exist ... instead it is named /dev/pstore/console-ramoops-0. the upstream commit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/cpufreq?id=d4bf205da618bbd0b038e404d646f14e76915718 Android has been tracking this in b/63058217. basically we'll need to update our code to check both locations until we drop all <=linux-3.18 devices, or we decide to backport that change.
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c10b6e053565d44a6a8742310beefbddcdd45045 commit c10b6e053565d44a6a8742310beefbddcdd45045 Author: Mike Frysinger <vapier@chromium.org> Date: Wed Aug 16 01:29:21 2017 platform_FilePerms: allow /sys/fs/pstore too Depending on the system, pstore might be mounted at the old /dev/pstore path, or the new /sys/fs/pstore path. Allow them both. BUG= chromium:755343 TEST=precq passes Change-Id: Id799c505ba65882a9b65c52d48979182c42b22a4 Reviewed-on: https://chromium-review.googlesource.com/616000 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> [modify] https://crrev.com/c10b6e053565d44a6a8742310beefbddcdd45045/client/site_tests/platform_FilePerms/platform_FilePerms.py
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e5ae86aa06e2b5d3e16f118aca878f2617c2cdd7 commit e5ae86aa06e2b5d3e16f118aca878f2617c2cdd7 Author: Mike Frysinger <vapier@chromium.org> Date: Wed Aug 16 05:21:59 2017 logs_to_collect: grab all pstore files The exact file name here has changed in newer kernel versions, but we can simplify this code by grabbing all possible entries. We want to do that anyways as there might be interesting content in them. BUG= chromium:755343 TEST=precq passes Change-Id: I5f191079deecc42069686b31d35b9ea54bd2f7fc Reviewed-on: https://chromium-review.googlesource.com/615545 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Dan Shi <dshi@google.com> [modify] https://crrev.com/e5ae86aa06e2b5d3e16f118aca878f2617c2cdd7/client/common_lib/logs_to_collect
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b56ba75954e8463adbe9449d7e2a95af488e4626 commit b56ba75954e8463adbe9449d7e2a95af488e4626 Author: Mike Frysinger <vapier@chromium.org> Date: Wed Aug 16 07:17:51 2017 kernel_MemoryRamoop: snarf up all console ramoops files With linux-3.19, the filename has changed to include the record id at the end. Adjust the code here to snarf up all matching paths. BUG= chromium:755343 TEST=precq passes Change-Id: I4f4190b40b6af94aba42f0434a39554a05a80dc5 Reviewed-on: https://chromium-review.googlesource.com/616002 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Luigi Semenzato <semenzato@chromium.org> [modify] https://crrev.com/b56ba75954e8463adbe9449d7e2a95af488e4626/server/site_tests/kernel_MemoryRamoop/kernel_MemoryRamoop.py
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/b7e0a04b50cc088ee8818e551365ae93471f5d51 commit b7e0a04b50cc088ee8818e551365ae93471f5d51 Author: Mike Frysinger <vapier@chromium.org> Date: Wed Aug 16 07:17:50 2017 support old/new filenames for console-ramoops Starting with linux-3.19, "console-ramoops" has been renamed to "console-ramoops-0". Refactor the code to support both. BUG= chromium:755343 TEST=precq passes Change-Id: I929238c63cd41e4a5b0414caeaa2a52c6b5c7b61 Reviewed-on: https://chromium-review.googlesource.com/614842 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/b7e0a04b50cc088ee8818e551365ae93471f5d51/py/test/diagnosis/system_logs.yaml [modify] https://crrev.com/b7e0a04b50cc088ee8818e551365ae93471f5d51/py/utils/sys_utils.py
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/387db4001ba93746a81ca85b1a80a03be1390a82 commit 387db4001ba93746a81ca85b1a80a03be1390a82 Author: Mike Frysinger <vapier@chromium.org> Date: Wed Aug 16 09:05:59 2017 init: gather all console-ramoops records Starting with linux-3.19, "console-ramoops" has been renamed to "console-ramoops-0". Use a glob to pick up old/new names and all possible records. BUG= chromium:755343 TEST=precq passes Change-Id: I74515f761bf46bd5c2358265daab995a480d019f Reviewed-on: https://chromium-review.googlesource.com/614421 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/387db4001ba93746a81ca85b1a80a03be1390a82/init/clobber-log
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/32cdf3e317a13c8e8b0277225640bfa6fff507b9 commit 32cdf3e317a13c8e8b0277225640bfa6fff507b9 Author: Mike Frysinger <vapier@chromium.org> Date: Thu Aug 17 18:31:49 2017 debugd: gather all console-ramoops records Starting with linux-3.19, "console-ramoops" has been renamed to "console-ramoops-0". Use a glob to pick up old/new names and all possible records. BUG= chromium:755343 TEST=precq passes Change-Id: Ic07c8e78002719fa0c10c34068b35e24e8d70e07 Reviewed-on: https://chromium-review.googlesource.com/614701 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/32cdf3e317a13c8e8b0277225640bfa6fff507b9/debugd/src/log_tool.cc
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/145d2de158363fc0890bd1e3a3b4ad9f6984bbef commit 145d2de158363fc0890bd1e3a3b4ad9f6984bbef Author: Mike Frysinger <vapier@chromium.org> Date: Thu Aug 17 23:30:27 2017 crash: gather all console-ramoops records Starting with linux-3.19, "console-ramoops" has been renamed to "console-ramoops-0". Refactor the code to support both. BUG= chromium:755343 TEST=precq passes Change-Id: Ie1e5ae523b0832e31957ffdcaad09752a2ff2464 Reviewed-on: https://chromium-review.googlesource.com/614840 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/145d2de158363fc0890bd1e3a3b4ad9f6984bbef/crash-reporter/kernel_collector.h [modify] https://crrev.com/145d2de158363fc0890bd1e3a3b4ad9f6984bbef/crash-reporter/kernel_collector_test.cc [modify] https://crrev.com/145d2de158363fc0890bd1e3a3b4ad9f6984bbef/crash-reporter/kernel_collector.cc
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/34ec31f138f0aa6f03c04827e5efa37c2637ea11 commit 34ec31f138f0aa6f03c04827e5efa37c2637ea11 Author: Mike Frysinger <vapier@chromium.org> Date: Fri Aug 18 07:57:28 2017 platform_BootPerf: snarf up all console ramoops files With linux-3.19, the filename has changed to include the record id at the end. Adjust the code here to snarf up all matching paths. BUG= chromium:755343 TEST=precq passes Change-Id: I5fa1999b171e30821b5bc423a164443c1e910d27 Reviewed-on: https://chromium-review.googlesource.com/616001 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Po-Hsien Wang <pwang@chromium.org> [modify] https://crrev.com/34ec31f138f0aa6f03c04827e5efa37c2637ea11/client/site_tests/platform_BootPerf/platform_BootPerf.py
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2dc4a41a1a5b7f0d57ed0390700a4d1caf37f97f commit 2dc4a41a1a5b7f0d57ed0390700a4d1caf37f97f Author: Mike Frysinger <vapier@chromium.org> Date: Fri Aug 18 07:57:27 2017 grab all files in pstore paths When grabbing logs from the DUT, rather than look at just the single console-ramoops file, pull all files that might exist. This makes the code work with newer/older kernels (where the "console-ramoops" filename has changed), and lets us pick up any additional files we might find interesting. BUG= chromium:755343 TEST=precq passes Change-Id: I17178189e5106e09f91ed4747370c3c74982b391 Reviewed-on: https://chromium-review.googlesource.com/616005 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Dan Shi <dshi@google.com> [modify] https://crrev.com/2dc4a41a1a5b7f0d57ed0390700a4d1caf37f97f/server/crashcollect.py [modify] https://crrev.com/2dc4a41a1a5b7f0d57ed0390700a4d1caf37f97f/client/bin/base_sysinfo.py [modify] https://crrev.com/2dc4a41a1a5b7f0d57ed0390700a4d1caf37f97f/client/cros/constants.py
,
Aug 18 2017
i believe they're all updated now
,
Sep 12 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/abdee77685393623ae982254e8985293a9f7fa9f commit abdee77685393623ae982254e8985293a9f7fa9f Author: Mike Frysinger <vapier@chromium.org> Date: Tue Sep 12 08:12:02 2017
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ace0eb09ecff68a19a3a598d3ae164114b4ae191 commit ace0eb09ecff68a19a3a598d3ae164114b4ae191 Author: Guenter Roeck <groeck@chromium.org> Date: Tue Nov 21 09:59:13 2017 Revert "CHROMIUM: HACK: pstore: Rename console-ramoops-<id> to console-ramoops" This reverts commit 94d896ab1fbc1f7d8fe9af314e074e5bb4f870dc. No longer needed. BUG= chromium:787152 , chromium:755343 TEST=Build and test various platforms to ensure that the new file name is handled correctly. Change-Id: I00f8eefa1e9daa49ce9609220fb9499ddaa0d54b Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/780848 Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/ace0eb09ecff68a19a3a598d3ae164114b4ae191/fs/pstore/inode.c
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/8d20df4f61eac3b18090d768f2f5d859ee96b996 commit 8d20df4f61eac3b18090d768f2f5d859ee96b996 Author: Mike Frysinger <vapier@chromium.org> Date: Tue Nov 21 09:59:08 2017 init: pstore: grant read access to debugd In order to support globbing to find all the console-ramoops names, we need to grant read access to the debugd group. BUG= chromium:755343 , chromium:787152 TEST=`sudo -u debugd ls /dev/pstore/` works now Change-Id: Icdfa657b1aef91579e78b5d9b4dcd6e1ab784007 Reviewed-on: https://chromium-review.googlesource.com/780526 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> [modify] https://crrev.com/8d20df4f61eac3b18090d768f2f5d859ee96b996/init/upstart/pstore.conf
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/62ad6dd8a5b75e316875358dd68e3c7795d67c6b commit 62ad6dd8a5b75e316875358dd68e3c7795d67c6b Author: Guenter Roeck <groeck@chromium.org> Date: Tue Nov 21 12:25:09 2017 Revert "CHROMIUM: HACK: pstore: Rename console-ramoops-<id> to console-ramoops" This reverts commit 94d896ab1fbc1f7d8fe9af314e074e5bb4f870dc. No longer needed. BUG= chromium:787152 , chromium:755343 TEST=Build and test various platforms to ensure that the new file name is handled correctly. Change-Id: I00f8eefa1e9daa49ce9609220fb9499ddaa0d54b Signed-off-by: Guenter Roeck <groeck@chromium.org> (cherry picked from commit fc3e9c32efc6d95bd61c256b21d474baad8a4bf1 and resolved conflicts) Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/780923 Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/62ad6dd8a5b75e316875358dd68e3c7795d67c6b/fs/pstore/inode.c
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a1befd450f1936817732f20c523a30c7e2d3a2c8 commit a1befd450f1936817732f20c523a30c7e2d3a2c8 Author: Mike Frysinger <vapier@chromium.org> Date: Wed Nov 22 21:36:52 2017 init: pstore: grant read access to debugd In order to support globbing to find all the console-ramoops names, we need to grant read access to the debugd group. BUG= chromium:755343 , chromium:787152 TEST=`sudo -u debugd ls /dev/pstore/` works now Change-Id: Icdfa657b1aef91579e78b5d9b4dcd6e1ab784007 Reviewed-on: https://chromium-review.googlesource.com/780526 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> (cherry picked from commit commit 8d20df4f61eac3b18090d768f2f5d859ee96b996) [Context adjustment, since this was refactored in the meantime for moving to /sys/fs/pstore/ path] Reviewed-on: https://chromium-review.googlesource.com/786272 Commit-Queue: Brian Norris <briannorris@chromium.org> Tested-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/a1befd450f1936817732f20c523a30c7e2d3a2c8/init/upstart/pstore.conf
,
Nov 27 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vapier@chromium.org
, Aug 15 2017