New issue
Advanced search Search tips

Issue 755332 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: return expiration date for cookies in seconds (fix to conform to docs)

Project Member Reported by pfeldman@chromium.org, Aug 14 2017

Issue description

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/inspector/browser_protocol.json?q=browser_protocol.&sq=package:chromium&dr&l=1412

is saying we return time in seconds since epoch, but in reality we return it in millis. I'm about to fix this, but clients might rely upon this change.

@john: heads up, you might need to detect / multiply values by 1000 on your side now...
 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b0f8f321dde1278e831ba6a4ce0c79999c45de4

commit 5b0f8f321dde1278e831ba6a4ce0c79999c45de4
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Tue Aug 15 23:40:39 2017

DevTools: introduce Network.addCookies, make getCookies conform to the protocol docs.

Bug:  755332 
Change-Id: I8e0661c573cc3803b12ff0556d1a606070c8a002
TBR: for protocol client changes
Reviewed-on: https://chromium-review.googlesource.com/614721
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494605}
[modify] https://crrev.com/5b0f8f321dde1278e831ba6a4ce0c79999c45de4/chrome/test/chromedriver/chrome/web_view_impl.cc
[modify] https://crrev.com/5b0f8f321dde1278e831ba6a4ce0c79999c45de4/chrome/test/chromedriver/window_commands.cc
[modify] https://crrev.com/5b0f8f321dde1278e831ba6a4ce0c79999c45de4/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/5b0f8f321dde1278e831ba6a4ce0c79999c45de4/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/5b0f8f321dde1278e831ba6a4ce0c79999c45de4/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/5b0f8f321dde1278e831ba6a4ce0c79999c45de4/headless/lib/headless_browser_browsertest.cc
[modify] https://crrev.com/5b0f8f321dde1278e831ba6a4ce0c79999c45de4/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test-expected.txt
[modify] https://crrev.com/5b0f8f321dde1278e831ba6a4ce0c79999c45de4/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test.js
[modify] https://crrev.com/5b0f8f321dde1278e831ba6a4ce0c79999c45de4/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/5b0f8f321dde1278e831ba6a4ce0c79999c45de4/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
[modify] https://crrev.com/5b0f8f321dde1278e831ba6a4ce0c79999c45de4/third_party/WebKit/Source/devtools/front_end/sdk/CookieModel.js

Cc: -zhanliang@chromium.org johnchen@chromium.org
Adding the correct email id of John.
My testing shows that ChromeDriver is still working correct with cookie expiration time. The change in comment #2 contains fix needed for ChromeDriver.
Status: Fixed (was: Assigned)

Sign in to add a comment