Check in with secops about adding internal links to ChOpsDash
Confirmed with SecOps that a security review is not necessary. The internal links we will be exposing are a/i/******* which go to urls that require authentication. "so exposing a/i/** links is fine because non-Googlers won't be able to access them"
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/30a954d75449a12cd39a528910f181e20b294bfb commit 30a954d75449a12cd39a528910f181e20b294bfb Author: Joanna Wang <jojwang@google.com> Date: Tue Oct 03 00:23:06 2017 Get alertmanager incident link Part of an effort to give signed in Googlers access to more information on each incident. Bug:755330 Change-Id: Id7f5e9cb9c5d81e9751808d06a095268fc8066a2 Reviewed-on: https://chromium-review.googlesource.com/688831 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Joanna Wang <jojwang@google.com> [modify] https://crrev.com/30a954d75449a12cd39a528910f181e20b294bfb/go/src/infra/appengine/dashboard/api/dashboard/pb.discovery.go [modify] https://crrev.com/30a954d75449a12cd39a528910f181e20b294bfb/go/src/infra/appengine/dashboard/frontend/helpers.go [modify] https://crrev.com/30a954d75449a12cd39a528910f181e20b294bfb/go/src/infra/appengine/dashboard/frontend/helpers_test.go [modify] https://crrev.com/30a954d75449a12cd39a528910f181e20b294bfb/go/src/infra/appengine/dashboard/frontend/service.go [modify] https://crrev.com/30a954d75449a12cd39a528910f181e20b294bfb/go/src/infra/appengine/dashboard/api/dashboard/dashboard.pb.go [modify] https://crrev.com/30a954d75449a12cd39a528910f181e20b294bfb/go/src/infra/appengine/dashboard/api/dashboard/dashboard.proto
Comment 1 by jojwang@chromium.org
, Aug 14 2017Owner: jojwang@chromium.org