All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=755321

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=2ec5cfc7779911116c2da8ab3bdb7003bd48589e0fe792835f034a6b88a52b46


Bot(s) for this bug's original alert(s):

Android Builder

See attached diff for more details.

It's not clear to me whether or not this increase was expected. Please have a look and either:

1. Close as “Won't Fix” with a short justification, or
2. Land a revert / fix-up.

Deleted: diff_results.txt 60.5 KB

diff_results.txt 60.5 KB View Download

Hi, I'm so sorry! I completely missed this. I'll take a look with my intern host this afternoon and get back to you ASAP.

I opened a CL to switch from using std::regex to the RE2 library, which is included elsewhere in Chrome. This should shrink the size of the APK.

https://chromium-review.googlesource.com/c/chromium/src/+/634280

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/567501229d406f9874f0a68a8972310e389eddac

commit 567501229d406f9874f0a68a8972310e389eddac
Author: Sasha Perigo <sperigo@chromium.org>
Date: Fri Aug 25 01:50:57 2017

Switched from std::regexes to re2::RE2s in ssl_error_handler.cc.

The RE2 library is used in place of the standard regex library
elsewhere in the Chrome code base. I updated ssl_error_handler.cc to
match this pattern.

Bug:  crbug.com/755321 
Change-Id: I750b35549e2a74e935fb25c83e057e3e5dec784b
Reviewed-on: https://chromium-review.googlesource.com/634280
Commit-Queue: Sasha Perigo <sperigo@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497289}
[modify] https://crrev.com/567501229d406f9874f0a68a8972310e389eddac/chrome/browser/ssl/ssl_error_handler.cc

567501229d406f9874f0a68a8972310e389eddac brought the size down by 24kb! Thanks for looking into this :).

https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=497289

Nice! To avoid this in the future, should we have a presubmit that checks for std::regex and suggest re2 instead?

Good idea! Filed 759548 for this.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b42732c9ecff24281c801ab1ef4758f33e501e3

commit 6b42732c9ecff24281c801ab1ef4758f33e501e3
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Thu Dec 21 22:23:04 2017

PRESUBMIT: make crbug references copy+pastable

BUG= 755321 ,714018, 570091 

Change-Id: I7cfe86901561910107919e18102ade3a4015f471
Reviewed-on: https://chromium-review.googlesource.com/838060
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525829}
[modify] https://crrev.com/6b42732c9ecff24281c801ab1ef4758f33e501e3/PRESUBMIT.py