Rearrange compositor frame struct traits header files to reduce call sites includes |
||
Issue descriptionRight now callsites trying to directly serialize/deserialize compositor frames need to include all the struct traits header files of all the datastructures in compositor frame. Move to the case where the struct traits header files include other struct traits header files so the callsites don't need to know about every struct traits header files that need to be included. For example, compositor frame struct traits header file should include compositor_frame_metadata_struct_traits.h so that unittests and serialization perftests won't need to.
,
May 25 2018
I don't see a bunch of includers of the struct traits tho, to update after changing this. services/viz/public/cpp/compositing/compositor_frame_struct_traits.h is only included by the services unit/perf tests for the struct traits.
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/312bce054cdd77e65a149dc32f8641772c3e6e7c commit 312bce054cdd77e65a149dc32f8641772c3e6e7c Author: danakj <danakj@chromium.org> Date: Fri May 25 23:21:20 2018 viz: Include StructTraits headers that are used in the header The CompositorFrame StructTraits uses the traits of RenderPass and CompositorFrameMetadata, so they should be included. R=weiliangc@chromium.org Bug: 755319 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If8a895128953dc4049e7c446667bdfb022a94ae3 Reviewed-on: https://chromium-review.googlesource.com/1073965 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: weiliangc <weiliangc@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#562055} [modify] https://crrev.com/312bce054cdd77e65a149dc32f8641772c3e6e7c/services/viz/public/cpp/compositing/compositor_frame_struct_traits.cc [modify] https://crrev.com/312bce054cdd77e65a149dc32f8641772c3e6e7c/services/viz/public/cpp/compositing/compositor_frame_struct_traits.h [modify] https://crrev.com/312bce054cdd77e65a149dc32f8641772c3e6e7c/services/viz/public/cpp/compositing/render_pass_struct_traits.cc [modify] https://crrev.com/312bce054cdd77e65a149dc32f8641772c3e6e7c/services/viz/public/cpp/compositing/struct_traits_perftest.cc
,
May 26 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by danakj@chromium.org
, May 25 2018Status: Started (was: Available)